Should the Writeable trait consume self? about icu4x HOT 4 OPEN

OK, it sounds like we're okay with the status quo for the time being. A change should come with concrete examples of how it benefits performance. So I'll keep this issue open as a place to collect such examples.

from icu4x.

CC @robertbastian @Manishearth, thoughts on this?

from icu4x.

I think it's valuable for Writeable to be trait safe.

from icu4x.

I don't think this makes sense for the main write method.

I think it may make sense for write_to_string() and write_to_parts() . I'd like to keep this issue around to track situations where we feel like this would be useful before proactively implementing it.

Object safety can be partially solved by fn ... where Self: Sized, however that does tend to still be annoying in generic contexts.

I think the ergonomics are fine; "whether there is to be something gained from this" is something we should collect data on imo.

from icu4x.