Comments (7)
I would keep all "Islamic"s. I know for a fact that Saudi Arabia uses islamic-umalqura, that Iran uses islamic observational, and that some Arab countries use the tabular and civil calendars. All four are needed.
from icu4x.
I think this is a good idea and is a great example of why the neo model works much better overall.
We may need to eventually figure out what counts as extended but for now "Japanext + community calendars" seems fine.
from icu4x.
- @robertbastian - We could also just exclude JapaneseExtended from AnyCalendar, and if clients want to use it, they need to use TypedDateTimeFormatter.
- @sffc - It would be a pain if a client did need JapaneseExtended but had to use a special code path for it. But, we can cross that bridge later. We can add
try_new_extended
if needed.
Conclusion: In 2.0, remove JapaneseExtended from AnyCalendar and DateTimeFormatter bounds
LGTM: @sffc @robertbastian
@Manishearth thoughts?
from icu4x.
I'm fine with this. Should we also consider removing any of the Islamic ones? I'm not sure which ones are "major" or in active civil use.
from icu4x.
The CLDR data has each calendar except Julian (and Japanese Extended) listed in at least one locale:
<calendarPreferenceData>
<calendarPreference territories="001" ordering="gregorian"/>
<calendarPreference territories="BD DJ DZ EH ER ID IQ JO KM LB LY MA MR MY NE OM PK PS SD SY TD TN YE" ordering="gregorian islamic islamic-civil islamic-tbla"/>
<calendarPreference territories="AL AZ MV TJ TM TR UZ XK" ordering="gregorian islamic-civil islamic-tbla"/>
<calendarPreference territories="AE BH KW QA" ordering="gregorian islamic-umalqura islamic islamic-civil islamic-tbla"/>
<calendarPreference territories="AF IR" ordering="persian gregorian islamic islamic-civil islamic-tbla"/>
<calendarPreference territories="CN CX HK MO SG" ordering="gregorian chinese"/>
<calendarPreference territories="EG" ordering="gregorian coptic islamic islamic-civil islamic-tbla"/>
<calendarPreference territories="ET" ordering="gregorian ethiopic"/>
<calendarPreference territories="IL" ordering="gregorian hebrew islamic islamic-civil islamic-tbla"/>
<calendarPreference territories="IN" ordering="gregorian indian"/>
<calendarPreference territories="JP" ordering="gregorian japanese"/>
<calendarPreference territories="KR" ordering="gregorian dangi"/>
<calendarPreference territories="SA" ordering="islamic-umalqura gregorian islamic islamic-rgsa"/>
<calendarPreference territories="TH" ordering="buddhist gregorian"/>
<calendarPreference territories="TW" ordering="gregorian roc chinese"/>
</calendarPreferenceData>
That said, I don't have a very great sense of which Hijri calendars are needed in which contexts. For example, would it be acceptable if we included islamic-umalqura
in the default set but not islamic
(observational)? I was having a lot of trouble getting islamic
to behave correctly in the stress testing in #4904.
from icu4x.
CC @roozbehp @younies for potential feedback on calendar selection.
from icu4x.
Yeah that's what I'm trying to figure out; it's unclear which ones are actually in use.
from icu4x.
Related Issues (20)
- Separate the AM, PM for vertical layout ? HOT 1
- Support for single types without context HOT 2
- Investigate performance impact of rearranging "can combine backwards" bit HOT 1
- 1 BCE returned as 0 CE in the Japanese calendar HOT 3
- Failing debug_assert when formatting week_of_year HOT 1
- Start of epoch for Islamic observational calendar doesn't match CLDR/ICU4C HOT 1
- Feature-gate UTF8 and UTF16 normalization HOT 2
- Data key thoughts HOT 5
- Word segmentation is incorrect
- Custom variants for icu_preferences HOT 1
- Fallback option for South East Asian line breaking? HOT 2
- Rename icu_pattern types to indicate that they can hold multiple numbers of placeholders HOT 2
- Panic while formatting date in beta and nightly compilers HOT 6
- Develop Sign, Unsign, Nan & Inf for FixedDecimal HOT 3
- Debug assertion: "Found year with more than one excess day!" with IslamicObservational
- Dates don't roundtrip when converting to ISO and back again with non-always-calculating IslamicObservational/IslamicUmmAlQura calendars HOT 2
- Indian calendar can return ISO-date with zero day_of_month HOT 2
- Julian Revised
- Iai benches in icu_collections fail with latest valgrind version HOT 6
- Incorrect output for en-GB unit/narrow list formatter HOT 16
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from icu4x.