Giter Club home page Giter Club logo

Comments (3)

robertbastian avatar robertbastian commented on June 7, 2024
pub enum DimensionEquivalency {
  Equivalent, // i.e. length and length
  Reciprocal, // i.e. length/time and time/length
  Unrelated,
}

pub enum UnitConvertibility {
    Convertible, // i.e. meter and foot
    InverseConvertible, // i.e. mpg and l/100km
    NotConvertible, // i.e. meter and square meter
}
  • robertbastian: why do we need this type? does the caller of the API actually need to distinguish between Convertible and InverseConvertible?
  • younies@: google project A uses are_convertible
  • robertbastian@: so it's just a boolean instead of three values
  • younies@: we can return Option<Converter> instead of having this enum
impl ConverterFactory { 
    pub fn converter(&self, unit1: &MeasureUnit, unit2: &MeasureUnit2) -> Option<Converter> { ... }
}

impl Converter {
    pub fn convert(&self, ...) -> ... { ... }
    // potential future extensions:
    pub fn is_inverse(&self) -> bool { ... }
    pub fn info(&self) -> ConversionInfo { ... }
}

ConversionInfo {
    offset: Ratio<BigInt>, 
    rate: Ratio<BigInt>,
    is_reciprocal: bool,
}

lgtm: @younies, @robertbastian
?: @sffc

from icu4x.

sffc avatar sffc commented on June 7, 2024

How about naming the struct based on what it is instead of what it is used for, like DimensionRegistry

impl DimensionRegistry { 
    pub fn converter_for(&self, unit1: &MeasureUnit, unit2: &MeasureUnit2) -> Option<Converter> { ... }
}

On Converter, seems info is sufficient here, right? We don't need to add is_inverse and bikeshed the name of it.

from icu4x.

younies avatar younies commented on June 7, 2024

We do not use is_reciprocal anymore because we are having three converters right now.

  1. Proportional
  2. Reciprocal
  3. Offset

from icu4x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.