unibiodicts / vsm-dictionary-bioportal Goto Github PK

Because of this issue (multiple ontology terms with the same ID), I had to implement a way to infer the ontology acronym from the entry id. This is done in the function inferDictAbbrevFromId(id) in DIctionaryBioPoral.js.

So, if more regexes are found that can clearly distinguish the ontology acronym from the id in some cases, then I have to add them to the ontologyRegexes array of the aforementioned function.

If in the future the issue is solved (e.g. BioPortal provides an endpoint that returns a source ontology for a term), then I will have to re-design getEntries() and remove the hack.

John.

There is a same bug in getDictInfos(), getEntries(), and getEntryMatchesForString() :
In their for-loop, each iteration can make its own call call cb(), if an error occurs. See:

for (let url of urlArray) {
  ...
  this.request(url, (err, res) => {
    if (err) return cb(err);   //  <---- THAT

'THAT' line will get called urlArray.length times if each of the request errors for each of the urls.

Solution: set an answered = true when an error causes a cb() call.
And when answered is already true, do not call cb. Not in the final call, and not when possible next error is received.