Giter Club home page Giter Club logo

Comments (6)

diego3g avatar diego3g commented on May 13, 2024 2

@dudusotero Yeah, i'm working on that already! Sending a PR in a few minutes.

from unform.

dudusotero avatar dudusotero commented on May 13, 2024

A Conditional render of a textarea instead of an input will be the solution for this?

from unform.

jpdemagalhaes avatar jpdemagalhaes commented on May 13, 2024

Sounds good to me!

I just took a look at the Input.tsx and Textarea.tsx files and they even have the same amount of lines 😄 .

Unifying this would be nice.

Could you make a PR about this @diego3g? I also agree with @dudusotero a simple conditional render would be enough I think.

from unform.

pellizzetti avatar pellizzetti commented on May 13, 2024

Makes sense to me, they are pretty much the same. Let's remove this redundancy! 😄

from unform.

TiagoCunhaF avatar TiagoCunhaF commented on May 13, 2024

@diego3g , it would have been better to keep the Textarea component, and only modify it to call the input with the multiline parameter, while maintaining compatibility with applications that were implemented using the Textarea component.

from unform.

viniciushernandes avatar viniciushernandes commented on May 13, 2024

It makes sense to me. Less redundancy!

from unform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.