unfoldingword-box3 / content-validation-app Goto Github PK

As of this writing, the trigger is when app first starts or on a page refresh. This means that once a session begins, the data is fixed, unchanging.

It may be desirable to clear the cache and fetch fresh data each time the user returns to the first step where org and lang is selected.

Allow the user to choose the target language for the validator using a radio button group.

The languages/orgs are:
Russian (RU)/ru_gl
Hindi (HI)/translationCore-Create-BCS
Kannada (KN)/translationCore-Create-BCS
Latin-American Spanish (ES-419)/Es-419_gl

Many columns in the results table are too wide. Reduce the size of the following:
Resource
Priority
Chapter
Verse
Line
RowID
Character POS

Increase the width of:
Message

Need to update code to use latest CV package.

See here

If you quickly click next on first step, the repo validation step is rendered before having data; it then shows the spinner, but when data arrives it does not update, so the spinner stays.

Workaround: click back, then next again.

When discussing CV results with others, it would be nice to confirm that we're using the same software. This app displays no version number, nor could I find one in Help / About or anywhere similar.

Secondly, since the guts of this app is the uw-content-validation package, it would actually be very helpful to display the version of this as well, as we discuss what bugs in the checks may or may not have been fixed.

I expect the need for these version numbers to multiply once we also start having GL users (as well as our own BP editors).

The package shouldn't have to handle this.

If this is needed for 3x3 initiative, please prioritize.
@birchamp @BincyJ

Here is link to conversation on Zulip on this topic.

In theory, there were three categories of notices:

• Breaking
• Non-breaking
• Warning

If so, what are the numeric ranges for each?

While not as simple as it sounds, here are the ranges suggested:

• Breaking: 800 and above
• Non-breaking: 600-799
• Warning: below 600

The first call in https://github.com/unfoldingWord-box3/content-validation-app/blob/master/src/core/book-package-check.js#L261 is correct, but not the second one in https://github.com/unfoldingWord-box3/content-validation-app/blob/master/src/core/book-package-check.js#L268

Would just help to remind me to refresh the page to get the latest version.

• 1st iteration: Validate English content
• 2nd iteration: Add 3x3 GLs (Hindi, Kannada, ES-419, Russian)
  Allow the 4 GLs in the 3x3 strategy to use the validator on their own repos.

Just so we don't lose track of ideas we might try to improve performance. I found that prefetching all the org/lang repos actually decreased performance slightly. Not enough to undo the prefetching, but enough to wonder what might be going on to slow things down.

• Use a different library for zip reading that performs better (do not know if any are optimized for reading, but this seems to be a slow part of the app)
• Process all repos for a given book concurrently; for example using PromiseAll. Currently repos are processed in series.
• Ensure that the new unzipped-store is always checked first (since it is new, perhaps something was missed?)

This could be done by adjusting the drawer nav element or removing it altogether since it isn't used.

See link below for mockup, requirements.
https://docs.google.com/document/d/1ACaK6CXHE2RQDUyyV9gF3H7orWJknzpKyKO-OpXrH9k/edit