undermywheel / vscode-luau Goto Github PK

These numbers don't get highlighted when they should be:

However, add a space and it's fine:

In my color theme (Atom One Dark), this would greatly help discern between keywords and library functions:

Lua	Luau

Some color themes are better at making this difference noticeable, like default Dark+:

Lua	Luau

And some others are not, like Material Darker:

Lua	Luau

or VS Dark:

Lua	Luau

I wrote this in consideration of the vscode repository's existing Lua syntax highlighter (L234-237):

{
	"match": "(?<![^.]\\.|:)\\b(coroutine\\.(create|resume|running|status|wrap|yield)|string\\.(byte|char|dump|find|format|gmatch|gsub|len|lower|match|rep|reverse|sub|upper)|table\\.(concat|insert|maxn|remove|sort)|math\\.(abs|acos|asin|atan2?|ceil|cosh?|deg|exp|floor|fmod|frexp|ldexp|log|log10|max|min|modf|pow|rad|random|randomseed|sinh?|sqrt|tanh?)|io\\.(close|flush|input|lines|open|output|popen|read|tmpfile|type|write)|os\\.(clock|date|difftime|execute|exit|getenv|remove|rename|setlocale|time|tmpname)|package\\.(cpath|loaded|loadlib|path|preload|seeall)|debug\\.(debug|[gs]etfenv|[gs]ethook|getinfo|[gs]etlocal|[gs]etmetatable|getregistry|[gs]etupvalue|traceback))\\b(?=\\s*(?:[({\"']|\\[\\[))",
	"name": "support.function.library.lua"
},

It would also help to use constant highlighting for math.pi and math.huge like vscode repo does (L222-225), or just remove it altogether:

{
	"match": "(?<![^.]\\.|:)\\b(false|nil|true|_G|_VERSION|math\\.(pi|huge))\\b|(?<![.])\\.{3}(?!\\.)",
	"name": "constant.language.lua"
},

Although I would probably make the name of those two constant patterns support.constant.luau.

game gets highlighted as a key word here, but it's part of a parameter identifier!

This extension uses a special language id (luau) in the package.json contributions instead of the normal "lua" language id that other extensions use, such as the VSCode extension for Selene. This make the extension incompatible with Selene for linting.

It's only a simple macro and will help a lot with workflow and efficiency.

Several spaces following each other (any type, newline, tabs, normal space) will break syntax highligting as of version 1.0.3

+ and - are operators normally, but when followed by a numeric digit, they become part of the numeric constant scope.

This is annoying since it means something like x + 1 gets highlighted with + as the same token as 1.

A pretty small problem, not that big of an issue.

I've seen it mark this stuff as wrong when it's actually valid Luau code:

• Type checking

• The += & -= operators

That code is all valid Luau (runs fine in-game and in studio)