Giter Club home page Giter Club logo

create-wdi5's Introduction

we're UI5, folks!

This is the head space of the UI5 community.

create-wdi5's People

Contributors

archer57 avatar jkoenig134 avatar marianfoo avatar siolto avatar vobu avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Forkers

siolto

create-wdi5's Issues

Rethink the folder structure created by wdi5

@vobu - just notice something while checking a reported issue for the ecosystem. When we create a new project for TypeScript, wdi5 adds the webapp/test/e2e folder which includes Node runtime related code. When using this in combination with the ui5-tooling-modules either an excludes must be maintained or better we move non-UI5-runtime code into another folder. This doesn't make sense to have it in the webapp folder, isn't it?

Happy to discuss this with you!

wdi5 tests are not integrated into git init

When i execute a standard yo easy-ui5 app and agree to the git init, the files generated for wdi5 integration are not added and commited.
My expectation is that they are added
image

Problem with custom command line options in wdi5's "init" function.

Just a heads-up: there's a wdi5 setup tutorial in the SAP Developer Center. I was running through it and encountered a problem with "npm init wdi5@latest -- ..." on step 10 (reported here with full error transcript: sap-tutorials/btp-foundation#81). I will be reaching out to the tutorial author to sort it out, but the root cause does seem to be somewhere inside wdi5 (probably a corner case based on the custom command line options required in the tutorial).

I'll keep you posted, but it might be worth a look by one of y'all.

wdi5 ts init adds wrong ui5 type devDependency

Moved ui5-community/wdi5#610 from wdi5 repo to wdi5-create

Describe the bug
The easy ui5 generator includes a sub-generator that handles the wdi5 integration into the generated app. This mostly consists of npm init wdi5 -- --ts. Init wdi5 seems to hard coded introduce a devDependency to the latest version of @openui5/types. But in the context of the easy ui5 generator the user can select between sapui5 and openui5 and also which specific version to be used.

See also my initial issue for the ui5 ts app generator: ui5-community/generator-ui5-ts-app#33

I think this is caused here: https://github.com/ui5-community/create-wdi5/blob/main/src%2Findex.ts#L20

UPDATA: and the tsconfig also contains the @openui5/types type: https://github.com/ui5-community/create-wdi5/blob/main/templates/test/tsconfig.json#L4

To Reproduce
yo easy-ui5 -> select generator ts-app and follow the instructions. select sapui5 (e.g. 1.120.11) and have a look at the package.json afterwards.

Expected behavior
Depending on the selection in the easy ui5 generator either @openui5/types or @sapui5/types should be included as devDependency in the version entered in the respective generator step.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.