The fit results file only outputs single-digit errors on the transit midtimes, which is leading to loss of precision when converting from days to seconds (0.0001 d is 8.6 sec), e.g.:

variable result uncertainty

T_mid_0 2451234.5678 -0.0005 +0.0007

Relatedly: is there a way to get access to the fit results in their full precision directly? (ie, without having to read back in the output file)

logging package is included in requirements.txt (in dev branch)
However, it is not supposed to be pip installed because already part of standard python library
This can cause issues at install such as: https://stackoverflow.com/questions/61470095/error-while-installing-logging-package-on-anaconda-prompt

This is probably a niche problem, but the database dropbox urls are blocked on (at least some) government networks. This prevents pylightcurve from being imported on these systems (at least while they are on those networks). Perhaps a different hosting solution can be found for these databases (GitHub itself?). This also could be something that EMAC could assist with if you are interested.

Hello!

I have been trying to run this nifty piece of code on my Mac. It installed without issues, but now I'm trying to run one of the examples and it breaks...

Here is the code I'm trying to run (copy&paste of one of the examples in your Readme):

import pylightcurve as plc
import matplotlib.pyplot as plt
import numpy as np

(planet, stellar_logg, stellar_temperature, stellar_metallicity, rp_over_rs, fp_over_fs,
period, sma_over_rs, eccentricity, inclination, periastron, mid_time) = plc.find_oec_parameters('hd209458b')

print (planet, stellar_logg, stellar_temperature, stellar_metallicity, rp_over_rs, fp_over_fs,
period, sma_over_rs, eccentricity, inclination, periastron, mid_time)

I checked that the package was installed correctly and I definitely have a good internet connection, however still this happens:

Downloading ephemeris database...
hjd_dict.pickle

Downloading ephemeris database failed. A download will be attempted next time.
Error: <class 'urllib.error.HTTPError'>
()
Traceback (most recent call last):
File "make_lightcurve.py", line 11, in
import pylightcurve as plc
File "/usr/local/lib/python3.7/site-packages/pylightcurve/init.py", line 11, in
from .catalogues_celestial_sphere import *
File "/usr/local/lib/python3.7/site-packages/pylightcurve/catalogues_celestial_sphere.py", line 81, in
hjd_dict = open_dict(glob.glob(os.path.join(databases.ephemeris, 'hjd_dict.pickle''*'))[0])
IndexError: list index out of range

Any insights?

Thanks a bunch,

Julia

I have 5 light curves that I am simultaneously fitting for a transiting planet system, two of which have the same epoch. However, I only get four T_mid values back in the fit file. I'm guessing they're getting tagged by epoch and only one value is reported... but which one? Please fix :)

Thanks!
Elisabeth

Installing the latest version of iraclis in a clean conda environment and attempting to run it throws an AttributeError that seems to originate with pylightcurve:

It seems that np.float was an alias for float that was deprecated in NumPy 1.20.

Replacing dtype=np.float with dtype=float in pylightcurve/analysis/gaussian.py fixes this issue. I will open a pull request with this patch.

python version: 3.7 and 3.10
pylightcurve branch: dev or master on 11 May 2023

Calling plc.exotethys raises a series of errors (UnpicklingError, UnicodeDecodeError, TypeError) where the last one is:

~/git-repos/pylightcurve/pylightcurve/processes/files.py in open_dict(path)
     44             return unpickler.load()
     45         except UnicodeDecodeError:
---> 46             return unpickler.load(encoding='latin-1')
     47 
     48 def save_dict(dictionary, path):

TypeError: load() got an unexpected keyword argument 'encoding'
```
Checking at the various versions (back to 3.7) of the _Unpickler object it does not seem that the load method accepts the encoding argument.