Giter Club home page Giter Club logo

hyku_addons's People

Contributors

ashikajith avatar bertzz avatar cjcolvar avatar danukah avatar fradeve avatar mankind avatar martincsimpson avatar okeen avatar prdanelli avatar thenapking avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

hyku_addons's Issues

Works always created 'private'

When a work is created, no matter the visibility set, it seems to alway be set to private. When editing the work and changing the visibility, it seems to revert back to private.

admin
frontend

Docker-compose up issue

I've not worked out the exact cause, but it seems to be after pulling down code, a rebuild is required, but the bundle install stage fails because of issues with the OAI Gem dependencies.

When you try and start the containers this error message is thrown:

web_1                  | bundler: failed to load command: rails (/usr/local/bundle/bin/rails)
web_1                  | /usr/local/bundle/gems/bundler-2.2.3/lib/bundler/source/git/git_proxy.rb:232:in `allowed_with_path': The git source https://github.com/ubiquitypress/blacklight_oai_provider.git is not yet checked out. Please run `bundle install` before trying to start your application (Bundler::GitError)

Then during the build we see this:

 ---> Using cache
 ---> 9e3f0ecfe1c5
Step 14/24 : RUN         bundle install
 ---> Running in 6783fe505cf7
[DEPRECATED] Your Gemfile contains multiple primary sources. Using `source` more than once without a block is a security risk, and may result in installing unexpected gems. To resolve this warning, use a block to indicate which gems should come from the secondary source. To upgrade this warning to an error, run `bundle config set --local disable_multisource true`.
Your Gemfile lists the gem pg (>= 0) more than once.
You should probably keep only one of them.
Remove any duplicate entries and specify the gem only once.
While it's not a problem now, it could cause errors if you change the version of one of them later.
Your Gemfile lists the gem capybara (>= 0) more than once.
You should probably keep only one of them.
Remove any duplicate entries and specify the gem only once.
While it's not a problem now, it could cause errors if you change the version of one of them later.
Your Gemfile lists the gem rspec_junit_formatter (>= 0) more than once.
You should probably keep only one of them.
Remove any duplicate entries and specify the gem only once.
While it's not a problem now, it could cause errors if you change the version of one of them later.
Your Gemfile lists the gem webdrivers (~> 4.0) more than once.
You should probably keep only one of them.
Remove any duplicate entries and specify the gem only once.
While it's not a problem now, it could cause errors if you change the version of one of them later.
Fetching https://github.com/ubiquitypress/blacklight_oai_provider.git
NOTE: Gem::Specification#rubyforge_project= is deprecated with no replacement. It will be removed on or after 2019-12-01.
Gem::Specification#rubyforge_project= called from /usr/local/bundle/bundler/gems/blacklight_oai_provider-94f309213df9/blacklight_oai_provider.gemspec:12.
Fetching https://github.com/tawan/active-elastic-job.git
Fetching https://github.com/notch8/willow_sword.git
Fetching https://github.com/samvera-labs/bulkrax.git
Fetching gem metadata from https://rubygems.org/........
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies..................
Bundler could not find compatible versions for gem "oai":
  In snapshot (Gemfile.lock):
    oai (= 0.4.0)

  In Gemfile:
    blacklight_oai_provider x86_64-linux was resolved to 6.0.0, which depends on
      oai (~> 1.0)

    bulkrax x86_64-linux was resolved to 0.1.0, which depends on
      oai (>= 0.4, < 2.x)

Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.
ERROR: Service 'app' failed to build: The command '/bin/sh -c bundle install' returned a non-zero code: 6```

Then the `bundle update` takes an extremely long time to resolve the dependencies (15 minutes or so), but does eventually finish, when the containers start normally. 

I wonder if this is caused by the location of the gems

Make per-tenant feature flipper for hyrax-doi integration

Currently hyrax-doi behaviors are either on or off for all tenants based on Hyrax.config.identifier_registrars being non-empty. The ability to enable/disable DOI features (either in bulk or per feature) needs to be clearly made available to the user in the UI. This may turn out to be entirely within hyrax-doi.

ActionController::UnknownFormat error when accessing private non-html/json response

When accessing a default Rails response type (JSON/HTML) for a non-visible work, the following error is received:

{"code":401,"message":"Authentication Required","description":"You must be logged in to do that!"}

And the default HTML response is to redirect the user to the login screen and return a CanCan error.

However, with non-default formats, like RIS (in the PR) or JSONLD, an ActionController::UnknownFormat error is returned.

I would have assumed that this is not the case because the format is registered outside of the request.

Screenshot from 2020-12-30 10-25-30
Screenshot from 2020-12-30 10-26-05

DOI minting background job always fails

With the updated GenericWork work type, doi minting always fails with:

WARN: ActiveTriples::Relation::ValueError: value must be an RDF URI, Node, Literal, or a valid datatype. See RDF::Literal.

undefined method `reject' for "":String in _license.html.erb

This comes up often when trying to create/edit a work. Restarting the docker containers generally clears it up. I suspect it is a code reloading issue where rails doesn't reload everything cleanly when the code has changed.

Showing /usr/local/bundle/gems/hyrax-2.9.0/app/views/records/edit_fields/_license.html.erb where line #2 raised:
undefined method `reject' for "":String
Extracted source (around line #80):              
                        val = object.send(attribute_name)
                        col = val.respond_to?(:to_ary) ? val.to_ary : val
                        col.reject { |value| value.to_s.strip.blank? } + ['']
                      end
    end
Trace of template inclusion: /usr/local/bundle/gems/hyrax-2.9.0/app/views/hyrax/base/_form_metadata.html.erb, /usr/local/bundle/gems/hyrax-2.9.0/app/views/hyrax/base/_guts4form.html.erb, /usr/local/bundle/gems/hyrax-2.9.0/app/views/hyrax/base/_form.html.erb, /usr/local/bundle/gems/hyrax-2.9.0/app/views/hyrax/base/new.html.erb

Fix intermittently failing tests

  • rspec ./spec/models/concerns/hyku_addons/account_behavior_spec.rb:56
  • rspec ./spec/models/concerns/hyku_addons/account_behavior_spec.rb:86 (is this the same as above)?
  • rspec ./spec/features/create_generic_work_spec.rb:74
  • rspec ./spec/features/create_generic_work_spec.rb:151
  • rspec ./spec/services/hyku_addons/i18n_multitenant_spec.rb:13 # HykuAddons::I18nMultitenant.set changes the locale
  • rspec ./spec/features/bulkrax_import_spec.rb:37 # Bulkrax import import works imports works
  • rspec ./spec/jobs/register_doi_job_spec.rb:37

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.