Giter Club home page Giter Club logo

Comments (5)

kenns29 avatar kenns29 commented on May 25, 2024

auto bump version in the main package.json (currently ocular-publish only bumps versions in modules package.json

lerna bump typically only bumps modules in the workspace. Since example/ and website/ are not in the workspace (and supposedly not), it is not necessary for "bump" to work for them.

from manifold.

Firenze11 avatar Firenze11 commented on May 25, 2024

lerna bump typically only bumps modules in the workspace. Since example/ and website/ are not in the workspace (and supposedly not), it is not necessary for "bump" to work for them.

But that will create confusion. Imagine someone new will have to go to modules subdirectories to find out what current version is.

from manifold.

ibgreen avatar ibgreen commented on May 25, 2024

Not sure if this is a relevant comment, but I prefer using synchronized versioning of submodules. I.e. all modules get published with the same version even if only some have changed. That version is then in lerna.json in the root.

from manifold.

Firenze11 avatar Firenze11 commented on May 25, 2024

Not sure if this is a relevant comment, but I prefer using synchronized versioning of submodules. I.e. all modules get published with the same version even if only some have changed. That version is then in lerna.json in the root.

We are already doing that

from manifold.

kenns29 avatar kenns29 commented on May 25, 2024

I changed my mind and I think aligning the versions on website/ and example/ is actually a good idea, because we will have a documentation website later on and the documentation version should align with the module versions, so should be the demo in or referenced by the documentation.

To do so you can make some scripts following the lerna bump to copy over the version number from the modules to the docs/websites.

from manifold.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.