Comments (5)
Thanks for the initiative. Regarding package size in Cons:
Per Ryan's comment, styletron-react-core
is supposed to be tree-shakeable. Styled-components should also come with tree-shaking support except for a few issues depending on how we write the component (e.g. with static props).
Shall we do around of benchmarking for the bundle size first, and seek help from BaseUI/Kepler.gl if the size is significantly large?
from manifold.
I'm not a big fan of styled-components. I prefer using UI tools such as baseui or antd and manage css customization through sass or less. You can maintain a namespace scheme to associate each sass file to a component, which basically negates the necessity of using styled components.
Namespace as such:
feature-list-drawing.sass
.feature-list-drawing{
...
}
feature-list-drawing.js
import feature-list-drawing.sass
from manifold.
Not good for package size -- Baseui is using styletron as engine; Kepler.gl is using styled-components, and if we switch, Manifold will be depending on both (it seems not hard for Baseui to support styled-components, but it's depriotized uber-web/baseui#114)
How significant is this consideration? If it's not a huge increase in package size in terms of proportion to the current package, then the middle-ground solution seems to be low-hanging to test.
from manifold.
Current bundle size for the demo website build:
Built at: 2019-09-12 23:19:06
Asset Size Chunks Chunk Names
bundle.js 28.1 MiB main [emitted] main
index.html 223 bytes [emitted]
from manifold.
Resolved by #50
from manifold.
Related Issues (20)
- Jupyter notebook - Export Segmentation not working HOT 2
- Module not found error HOT 1
- Segmentation by difference between models' performance
- Support multi-class classification HOT 1
- Allow users to change model names
- Allow users to monitor and change feature types
- Add on-screen tooltips
- Create practical examples using public datasets HOT 1
- Performance metric drop down not working and explanation of feature attribution is not clear HOT 1
- Export report
- Not obvious distributions for categorical features HOT 2
- How to prepare prediction dataset for manifold HOT 1
- Improve "Running demo app locally"
- CSV upload of large data does not work.
- Demo sample data is not working HOT 1
- Python manifold provide alias to model name
- Drill down to data points in clusters HOT 1
- are you planning to create python version ?
- URL does not load HOT 3
- your github.io domain seems to have been hijacked HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from manifold.