Giter Club home page Giter Club logo

Comments (5)

gnavvy avatar gnavvy commented on May 24, 2024

Thanks for the initiative. Regarding package size in Cons:

Per Ryan's comment, styletron-react-core is supposed to be tree-shakeable. Styled-components should also come with tree-shaking support except for a few issues depending on how we write the component (e.g. with static props).

Shall we do around of benchmarking for the bundle size first, and seek help from BaseUI/Kepler.gl if the size is significantly large?

from manifold.

kenns29 avatar kenns29 commented on May 24, 2024

I'm not a big fan of styled-components. I prefer using UI tools such as baseui or antd and manage css customization through sass or less. You can maintain a namespace scheme to associate each sass file to a component, which basically negates the necessity of using styled components.

Namespace as such:

feature-list-drawing.sass

.feature-list-drawing{
  ...
}

feature-list-drawing.js

import feature-list-drawing.sass

from manifold.

chrisirhc avatar chrisirhc commented on May 24, 2024

Not good for package size -- Baseui is using styletron as engine; Kepler.gl is using styled-components, and if we switch, Manifold will be depending on both (it seems not hard for Baseui to support styled-components, but it's depriotized uber-web/baseui#114)

How significant is this consideration? If it's not a huge increase in package size in terms of proportion to the current package, then the middle-ground solution seems to be low-hanging to test.

from manifold.

Firenze11 avatar Firenze11 commented on May 24, 2024

Current bundle size for the demo website build:

Built at: 2019-09-12 23:19:06
     Asset       Size  Chunks             Chunk Names
 bundle.js   28.1 MiB    main  [emitted]  main
index.html  223 bytes          [emitted]  

from manifold.

Firenze11 avatar Firenze11 commented on May 24, 2024

Resolved by #50

from manifold.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.