uber / bufrw Goto Github PK
View Code? Open in Web Editor NEWBuffer Reading and Writing
License: MIT License
bufrw's People
Contributors
Stargazers
Watchers
Forkers
chrisamoore raynos atul2512 rektide rooftopsparrow stepancar bridgear beckybeauchamp1 thanhlam2410 ajbogh shumih standardgalactic xyztlpbufrw's Issues
Consider different `valKey` and `dataKey` names for SwitchRW
The valKey and dataKey names are confusingly named.
It might be nicer to say caseKey and resultKey or something.
Module not found: Error: Can't resolve 'hexer'
We're seeing this error when we're npm installing https://github.com/jaegertracing/jaeger-client-node in our project through CI. It looks like this was fixed in f911865 but I don't think a new version was ever published to npm with those updates as when we npm install bufrw it does not have hexer in the dependencies list in package.json. Could you please publish the updates to npm so we can get this fixed?
I know that this project seems to be stale at 3 years old without any action, but I'm really surprised nobody has brought this up over that time span. Not sure why we'd be the only ones running into this, but would really appreciate a publish of a new version to get it fixed.
Server-side bundling fails due to octals in ansi-color
When trying to use bufrw (via thriftrw) in an environment where server side code is bundled with Babel and Webpack, the build process throws an error related to using Octal literals in strict mode:
error: ./node_modules/ansi-color/lib/ansi-color.js
Module build failed (from ./node_modules/fusion-cli/build/loaders/babel-loader.js):
SyntaxError: /var/tmp/project/node_modules/ansi-color/lib/ansi-color.js: Octal literal in strict mode (35:18)
33 | var ansi_str = "";
34 | for(var i=0, attr; attr = color_attrs[i]; i++) {
> 35 | ansi_str += "\033[" + ANSI_CODES[attr] + "m";
| ^
36 | }
37 | ansi_str += str + "\033[" + ANSI_CODES["off"] + "m";
38 | return ansi_str;
at Parser.raise (/var/tmp/project/node_modules/@babel/parser/lib/index.js:6322:17)
at Parser.readEscapedChar (/var/tmp/project/node_modules/@babel/parser/lib/index.js:7418:20)
at Parser.readString (/var/tmp/project/node_modules/@babel/parser/lib/index.js:7265:21)
at Parser.getTokenFromCode (/var/tmp/project/node_modules/@babel/parser/lib/index.js:6950:14)
at Parser.nextToken (/var/tmp/project/node_modules/@babel/parser/lib/index.js:6520:12)
at Parser.next (/var/tmp/project/node_modules/@babel/parser/lib/index.js:6460:10)
at Parser.parseMaybeAssign (/var/tmp/project/node_modules/@babel/parser/lib/index.js:8210:12)
at Parser.parseExpression (/var/tmp/project/node_modules/@babel/parser/lib/index.js:8120:23)
at Parser.parseStatementContent (/var/tmp/project/node_modules/@babel/parser/lib/index.js:9892:23)
at Parser.parseStatement (/var/tmp/project/node_modules/@babel/parser/lib/index.js:9763:17)
at Parser.parseBlockOrModuleBlockBody (/var/tmp/project/node_modules/@babel/parser/lib/index.js:10340:25)
at Parser.parseBlockBody (/var/tmp/project/node_modules/@babel/parser/lib/index.js:10327:10)
at Parser.parseBlock (/var/tmp/project/node_modules/@babel/parser/lib/index.js:10311:10)
at Parser.parseStatementContent (/var/tmp/project/node_modules/@babel/parser/lib/index.js:9839:21)
at Parser.parseStatement (/var/tmp/project/node_modules/@babel/parser/lib/index.js:9763:17)
at node.body.withTopicForbiddingContext (/var/tmp/project/node_modules/@babel/parser/lib/index.js:10374:60)
@ ./node_modules/bufrw/error_highlighter.js 22:12-33
@ ./node_modules/bufrw/interface.js
@ ./node_modules/bufrw/index.js
@ ./node_modules/thriftrw/index.js
@ ./src/server/lib/thrift-http.js
@ ./src/server/app.js
Are you open to a PR replacing the use of ansi-color with ansi-colors or chalk?
Write unit tests
Each module should be easily unit testable.
For now we've tested by integration through TChannel on its bufrw branch ( https://github.com/uber/tchannel/tree/bufrw ).
More atomics
Currently only covers UInt8, 16BE, 32BE, the rest should be easy to add by copy/paste boiler plate.
`bufrw.Struct` relies on key ordering
The interface to bufrw.Struct relies on undefined behavior of Object.keys in that it assumes the order is the same as the order in which the object literal is expressed.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.