uber / artist Goto Github PK

Here the generated parameter of setOnClickListener should have a @Nullable annotation to be consistent with android.view.View, see here (slow to load)

Codegen artifacts with androidx package names if androidx flag is enabled

When reading Artist's readme it is hard to answer the question "what kind of problems will this solve for me?" Maybe mention a concrete example use case? For example: "this can be used for adding automatic analytics to every view".

Close this issue if you disagree.

See what could be of use here

Change to avoid things to break after JCenter sunset

https://docs.github.com/en/actions

Are great!

Travis CI logs:

TROUBLESHOOTING: A FOSSA API key is needed to run this command.
Running `fossa analyze` performs a dependency analysis and uploads the result
to FOSSA. To run an analysis without uploading results, run:
    fossa analyze --output
You can provide your API key by setting the $FOSSA_API_KEY environment
variable. For example, try running:
    FOSSA_API_KEY=<YOUR_API_KEY_HERE> $command
You can create an API key for your FOSSA account at:
    
    app.fossa.com/account/settings/integrations/api_tokens

• When generating code in Artist from the KotlinApiHelper we get the following

public open override fun clicks(): Observable<Unit> {
    if (clicks == null) {
    	....
         rxview_longCl().map()
    		.doOnNext(UiChecks.checkClickableRequirementsAction(this))
    		.doOnNext(ViewAnalytics.logTapFor(this, getContext())).subscribe(clicks)
    	}
    }
   ....
  }

The Kotlin compiler assumes that the clicks in the subscribe method is null even though we set it a few lines prior. A possible fix for this is adding a let call before the rx chain. This way we will prevent the compiler from prompting

smart cast to 'PublishRelay<Unit>' is impossible, because 'clicks' is a mutable property that could have been changed by this time

How we're planning on solving it

public open override fun clicks(): Observable<Unit> {
    if (clicks == null) {
    	....
        clicks?.let {
         rxview_longCl().map()
    		.doOnNext(UiChecks.checkClickableRequirementsAction(this))
    		.doOnNext(ViewAnalytics.logTapFor(this, getContext())).subscribe(it)
    	 }
       }
    }
    ....
  }

A layer of indirection will be added to Artist such that the core logic remains the same, but JavaPoet/KotlinPoet usages will be generified. The built-in traits will be switched to KotlinTraits.

Add a Wiki page with a list of use cases such as:

• Adding support for automated tap & impression analytics
• Backport bugfixes for unsupported functionality
• Make theming fixes that everyone will inherit