tyuyang / pe Goto Github PK

The user is unable to find out what all the valid ingredients are, since it is not listed anywhere in the user guide and from what I can see, you cannot retrieve a list of valid ingredients in the app itself. This becomes an issue when minor spelling mistake come into play, since 'eggs' is not considered a valid ingredient, and so the user is unable to find out what is the valid syntax for that ingredient conveniently (ie. without having to trial and error).

Since a corrupted save file is considered an error, there should at least be a warning or error message shown when such defects are detected. Currently, the app simply fails to load the ingredient list without giving a reason.

In addition, since there is no self correcting measures in place for corrupted save files, the user is unable to tell why the program fails to save their information even after restarting the program. This means that they will not be able to fix the program, despite the method being on the user guide, precisely because they do not know the reason why the program is failing

From the image in the user guide above, if the user types in the command "ingredients search" or the command ""ingredients search ", the ingredients list should show up. However, errors were thrown every single time.

To reproduce
Type in :
add ground chicken /qty 10000000000000000000000000000000000000
Expected
Either this /qty is too large! or accept quantity with no issues. A huge number is still a number
Actual
Error thrown says argument entered is not a number.

To reproduce
Type in:
add /qty quantity

Expected
An error message that actually tells me what is not valid about the ingredient

Actual

If the feature for adding allergens is added, there should be a method for saving the information for allergens, since firstly people will assume that allergens are saved and then get the wrong information with the command "possible recipes" after exiting.

In the storage feature section of the developer guide, there is a sequence diagram shown. Picture below:

The return arrows are supposed to be dashed arrows, rather than solid arrows.

Recipe possible command section, sequence diagram:

How in the world did you actually manage to make it loop the other way??? Technically a bug since I don't think you are allowed to loop the return arrow anti clockwise, plus it intersects with parts of the diagram which is not desirable. But wow I actually did not know PlantUML can do this.

Hhihi

To reproduce
type in:
ingredients search eggs

Expected:
A message saying no ingredients are found or something along those lines

Actual:

There was no feedback message. This was especially startling since nearly every other command tested will have some form of feedback if nothing was found. User cannot be blamed if they thought the program actually hung.

(hihi was a command that I typed in to make sure that there was no infinite loop or something along those lines)

In the storage feature section of the developer guide, there is a sequence diagram shown.

As seen above, the loop encompasses only the return part of the function writeIngredientToFile(), which is probably an error since this implies that the function is invoked only once before the loop and returns multiple times during the loop.

To reproduce:
Type in:
add egg 20

Expected:
The flag /qty is missing! or something along those lines

Actual:

Even though the argument in question is a valid ingredient

To reproduce:
Type in:
add ground chicken /qty 10.1

Expected:
Either the flag /qty is not an integer! or program runs as per normal

Actual:
The error claims that a non-integer is not a number, which is technically not true.