tyrrrz / contextual Goto Github PK

Hey there,
I came across this yesterday, it looks quite useful. I am working on a small application (a Discord.Net bot) in which I was going to offer a few choices of database backend (LiteDB, SQLite, MySQL, etc). At the same moment I was trying to determine how I would like to go about being able pass around the database context of whichever one was chosen by the user, I came across this. From the looks of it, unless I am mistaken, this should be pretty ideal for something like that?

Thanks,
-MH

Hi @Tyrrrz , I've raised a few issues in this thread: https://twitter.com/alexyakunin/status/1335885438284832775

Use of Stack<T> is definitely a bug - you can verify this by adding a concurrent test; as for anything else, maybe it makes more sense to write about the pattern right on the first page of this repository - yes, lots of people don't know how to use this and when.

This is great Alexy!!
Not really an issue, just a discussion.

1. Your disposable utility does not guard against multiple disposings. With the current implementation, storing previous in the disposable function's closure, this will not introduce a bug... yet.

2. This code does not guard against out-of-order disposals ... this would be the biggest potential bug. You need to throw a suitable exception when user code disposes out of order.

3. It's recommended to use immutable types when storing in AsyncLocal. I like how you've just provided a base class and let the user roll their own ... do you have any thoughts about how to safeguard with immutables? https://blog.stephencleary.com/2013/04/implicit-async-context-asynclocal.html