Giter Club home page Giter Club logo

base16-eighties-dark's People

Contributors

keathley avatar trdarr avatar tyre avatar

Stargazers

 avatar

Watchers

 avatar  avatar

base16-eighties-dark's Issues

Use the `atom-text-editor` tag instead of the `editor-colors` class.

  • In index.less: Use the atom-text-editor tag instead of the editor-colors class.
  • Use the atom-text-editor tag instead of the editor class.
  • Use .bracket-matcher .region to select highlighted brackets.
  • Target the selector :host, atom-text-editor instead of .editor for shadow DOM support.
  • Target the selector :host, atom-text-editor instead of .editor-colors for shadow DOM support.

Cursor is very hard to see.

The theme looks awesome, but I can't see the cursor line and barely the cursor:

screen shot 2016-06-09 at 6 58 47 pm

The cursor is on the this, line 88.

ThemePackage.getStylesheetsPath is deprecated.

Store package style sheets in the styles/ directory instead of stylesheets/ in the base16-eighties-dark package

ThemePackage.getStylesheetsPath (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:460:9)
ThemePackage.getStylesheetPaths (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:471:32)
ThemePackage.loadStylesheets (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:453:38)
<unknown> (/Applications/Atom.app/Contents/Resources/app.asar/src/theme-package.js:47:19)
ThemePackage.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:163:15)
ThemePackage.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/theme-package.js:43:12)

The API call in use will be deprecated on June 1.

Deprecated selector in `base16-eighties-dark/index.less`

In base16-eighties-dark/index.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

  • atom-text-editor, atom-text-editor::shadow => atom-text-editor, atom-text-editor.editor

  • atom-text-editor .invisible-character, atom-text-editor::shadow .invisible-character, atom-text-editor .indent-guide, atom-text-editor::shadow .indent-guide => atom-text-editor .invisible-character, atom-text-editor.editor .invisible-character, atom-text-editor .indent-guide, atom-text-editor.editor .indent-guide

  • atom-text-editor .gutter, atom-text-editor::shadow .gutter => atom-text-editor .gutter, atom-text-editor.editor .gutter

  • atom-text-editor .gutter .line-number, atom-text-editor::shadow .gutter .line-number => atom-text-editor .gutter .line-number, atom-text-editor.editor .gutter .line-number

  • atom-text-editor .gutter .line-number.folded, atom-text-editor::shadow .gutter .line-number.folded, atom-text-editor .gutter .line-number:after, atom-text-editor::shadow .gutter .line-number:after, atom-text-editor .fold-marker:after, atom-text-editor::shadow .fold-marker:after => atom-text-editor .gutter .line-number.folded, atom-text-editor.editor .gutter .line-number.folded, atom-text-editor .gutter .line-number:after, atom-text-editor.editor .gutter .line-number:after, atom-text-editor .fold-marker:after, atom-text-editor.editor .fold-marker:after

  • atom-text-editor .cursor, atom-text-editor::shadow .cursor => atom-text-editor .cursor, atom-text-editor.editor .cursor

  • atom-text-editor .selection .region, atom-text-editor::shadow .selection .region => atom-text-editor .selection .region, atom-text-editor.editor .selection .region

  • atom-text-editor .line-number.cursor-line-no-selection, atom-text-editor::shadow .line-number.cursor-line-no-selection => atom-text-editor .line-number.cursor-line-no-selection, atom-text-editor.editor .line-number.cursor-line-no-selection

  • .comment => .syntax--comment

  • .entity => .syntax--entity

  • .keyword => .syntax--keyword

  • .storage.type => .syntax--storage.syntax--type

  • .constant => .syntax--constant

  • .constant.numeric, .constant.boolean => .syntax--constant.syntax--numeric, .syntax--constant.syntax--boolean

  • .variable, .storage.modifier => .syntax--variable, .syntax--storage.syntax--modifier

  • .delimiter, .brace => .syntax--delimiter, .syntax--brace

  • .delimiter.period => .syntax--delimiter.syntax--period

  • .invalid.deprecated => .syntax--invalid.syntax--deprecated

  • .invalid.illegal => .syntax--invalid.syntax--illegal

  • .class.support => .syntax--class.syntax--support

  • .string => .syntax--string

  • .string .constant.character.escape => .syntax--string .syntax--constant.syntax--character.syntax--escape

  • .string.regexp => .syntax--string.syntax--regexp

  • .string.regexp .source.ruby.embedded, .string.regexp .string.regexp.arbitrary-repitition => .syntax--string.syntax--regexp .syntax--source.syntax--ruby.syntax--embedded, .syntax--string.syntax--regexp .syntax--string.syntax--regexp.syntax--arbitrary-repitition

  • .constant => .syntax--constant

  • .constant.numeric => .syntax--constant.syntax--numeric

  • .constant.symbol, .constant.punctuation => .syntax--constant.syntax--symbol, .syntax--constant.syntax--punctuation

  • .constant.boolean => .syntax--constant.syntax--boolean

  • .keyword.control => .syntax--keyword.syntax--control

  • .punctuation => .syntax--punctuation

  • .punctuation.separator, .punctuation.definition => .syntax--punctuation.syntax--separator, .syntax--punctuation.syntax--definition

  • .punctuation.comment => .syntax--punctuation.syntax--comment

  • .variable.block => .syntax--variable.syntax--block

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

Deprecated selector in `base16-eighties-dark\index.less`

In base16-eighties-dark\index.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

  • .comment => .syntax--comment

  • .entity => .syntax--entity

  • .keyword => .syntax--keyword

  • .storage.type => .syntax--storage.syntax--type

  • .constant => .syntax--constant

  • .constant.numeric, .constant.boolean => .syntax--constant.syntax--numeric, .syntax--constant.syntax--boolean

  • .variable => .syntax--variable

  • .delimiter, .brace => .syntax--delimiter, .syntax--brace

  • .delimiter.period => .syntax--delimiter.syntax--period

  • .invalid.deprecated => .syntax--invalid.syntax--deprecated

  • .invalid.illegal => .syntax--invalid.syntax--illegal

  • .class.support => .syntax--class.syntax--support

  • .string => .syntax--string

  • .string .constant.character.escape => .syntax--string .syntax--constant.syntax--character.syntax--escape

  • .string.regexp => .syntax--string.syntax--regexp

  • .string.regexp .source.ruby.embedded, .string.regexp .string.regexp.arbitrary-repitition => .syntax--string.syntax--regexp .syntax--source.syntax--ruby.syntax--embedded, .syntax--string.syntax--regexp .syntax--string.syntax--regexp.syntax--arbitrary-repitition

  • .constant => .syntax--constant

  • .constant.numeric => .syntax--constant.syntax--numeric

  • .constant.symbol, .constant.punctuation => .syntax--constant.syntax--symbol, .syntax--constant.syntax--punctuation

  • .constant.boolean => .syntax--constant.syntax--boolean

  • .keyword.control => .syntax--keyword.syntax--control

  • .punctuation => .syntax--punctuation

  • .punctuation.separator, .punctuation.definition => .syntax--punctuation.syntax--separator, .syntax--punctuation.syntax--definition

  • .punctuation.comment => .syntax--punctuation.syntax--comment

  • .variable.block => .syntax--variable.syntax--block

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

couple errors

Hi, love this theme!. found a couple errors though
colors.less:16
@cyan: #66CCC;
should be
@cyan: #66CCCC;

selection is too light, also comments are the same color and get lost
so i've changed mine to
base.less:38
background-color: @base02;

and it's perfect =)

Looks very different from Sublime Text version

First off, thanks for working on porting this. ๐Ÿ‘ I love the Base16 Eighties color scheme.

The issue I'm having is that the Atom port of the color scheme doesn't seem to be a 1:1 translation for me. It doesn't seem to use as many colors, or the same colors. Here's what I'm seeing.

Markdown [ST]
image

Markdown [Atom]
image

HTML with Embedded Ruby [ST]
image

HTML with Embedded Ruby [Atom]
image

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.