Must be at least cherry picked in master, 9 and 8

Feature Request: Insert comments as markers for the TCA reference

Is your feature request related to a problem? Please describe.
Working on the TCA I noted the following: Most our examples come from the extension styleguide. Whenever we change Major versions we would have to update all images and all code snippets in which there have been changes. Now I have the following idea: using the literalinclude directive it is possible to display part of an external php file. So we could use the TCA configuration files from the styleguide extension automatically. The only problem is: Where does our code snippet start and end? Linenumbers are prone to change. It is possible to use markers however. For this we would have to insert marker comments at the start end end of each example. These markers shouldn't be touched as long as the example is still there. If an example gets removed the markers can be removed and we will be alerted with a warning on building. See TYPO3-Documentation/TYPO3CMS-Reference-TCA#344

Describe the solution you'd like
Add markers before an after each field definition that is to be used in the TCA reference. Example:

        // tca reference marker [start input_1]
        'input_1' => [
            'l10n_mode' => 'prefixLangTitle',
            'exclude' => 1,
            'label' => 'input_1 description',
            'description' => 'field description',
            'config' => [
                'type' => 'input',
                'behaviour' => [
                    'allowLanguageSynchronization' => true,
                ]
            ],
        ],
        // tca reference marker [end input_1]

Describe alternatives you've considered
If we wanted to use the files as they are we would have to start at the line containing 'input_1' and end at the line containing input_2 however if input_2 got removed we would get an error even though input_1 is still there. We could also add all markers on copying the file from your repository to ours. This would involve lots of manual work each time

https://forge.typo3.org/issues/78327

I use TYPO3 8.7.10

https://github.com/TYPO3/styleguide/blob/master/Classes/Controller/StyleguideController.php#L189

• https://github.com/TYPO3/styleguide/blob/master/Classes/TcaDataGenerator/FieldGenerator/TypePassthrough.php
• https://docs.typo3.org/typo3cms/TCAReference/ColumnsConfig/Type/Passthrough.html

Using string values (currently) is just guessing something. The type of default property should be considered here. In case default is not defined, no value should be generated.

Table btn-group icons broke

Add accordion

See https://review.typo3.org/#/c/50460/9

The latest "styleguide" version available on TER is 7.6, which I cannot use on TYPO3 v8.

https://extensions.typo3.org/extension/styleguide/

recent change from 88b28fc

is causing install tool compare databases to throw errrors no mysql.
Also acceptance tests are failing now.

Not Found

The requested URL /typo3/alt_doc.php was not found on this server.
there is a hardcoded path to alt_doc in styleguide/Resources/Private/Templates/Styleguide/Tca.html

Once https://review.typo3.org/#/c/56689/ is merged the following change should be changed

'select_checkbox_3' => [
            'exclude' => 1,
            'label' => 'select_checkbox_3 icons, description',
            'config' => [
                'type' => 'select',
                'renderType' => 'selectCheckBox',
                'items' => [
                    ['foo 1', 1, '', 'optional description'],
                    ['foo 2', 2, 'EXT:styleguide/Resources/Public/Icons/tx_styleguide.svg', 'description'],
                    ['foo 3', 3, 'EXT:styleguide/Resources/Public/Icons/tx_styleguide.svg'],
                    ['foo 4', 4],
                ],
            ],
        ],

to

'select_checkbox_3' => [
            'exclude' => 1,
            'label' => 'select_checkbox_3 icons, description',
            'config' => [
                'type' => 'select',
                'renderType' => 'selectCheckBox',
                'items' => [
                    ['foo 1', 1, '', 'optional description'],
                    ['foo 2', 2, 'EXT:styleguide/Resources/Public/Icons/tx_styleguide.svg', 'LLL:EXT:styleguide/somelabel'],
                    ['foo 3', 3, 'EXT:styleguide/Resources/Public/Icons/tx_styleguide.svg'],
                    ['foo 4', 4],
                ],
            ],
        ],

Should be "disabled" not "disable"

https://github.com/TYPO3/styleguide/blob/4225f009bcc51cf29b7f7cc9d1369f5622fdb542/Configuration/TCA/tx_styleguide_elements_group.php#L154

exec_UPDATEquery
array(4 items)
caller => 'TYPO3\CMS\Core\Database\DatabaseConnection::exec_UPDATEquery' (60 chars)
ERROR => 'Incorrect integer value: '' for column 'l18n_parent' at row 1' (61 chars)
lastBuiltQuery => 'UPDATE tx_styleguide_elements_rsainput_inline_1_child SET pid='86',parentid=
'4',parenttable='tx_styleguide_elements_rsainput',uid='4',sys_language_uid='
0',l18n_parent='',l18n_diffsource='lipsum',hidden='0',rsainput_1='lipsum' WH
ERE uid = 4' (239 chars)
debug_backtrace => 'require(typo3/sysext/backend/Resources/Private/Php/backend.php),typo3/index.
php#3 // {closure}#25 // TYPO3\CMS\Backend\Http\Application->run#24 // TYPO3
\CMS\Core\Core\Bootstrap->handleRequest#93 // TYPO3\CMS\Backend\Http\Backend
ModuleRequestHandler->handleRequest#310 // TYPO3\CMS\Backend\Http\BackendMod
uleRequestHandler->dispatchModule#88 // TYPO3\CMS\Extbase\Core\Bootstrap->ru
n#182 // TYPO3\CMS\Extbase\Core\Bootstrap->handleRequest#193 // TYPO3\CMS\Ex
tbase\Mvc\Web\BackendRequestHandler->handleRequest#206 // TYPO3\CMS\Extbase
Mvc\Dispatcher->dispatch#32 // TYPO3\CMS\Extbase\Mvc\Controller\ActionContro
ller->processRequest#86 // TYPO3\CMS\Extbase\Mvc\Controller\ActionController
->callActionMethod#175 // call_user_func_array#282 // TYPO3\CMS\Styleguide\C
ontroller\StyleguideController->tcaCreateAction# // TYPO3\CMS\Styleguide\Tca
DataGenerator\Generator->create#139 // TYPO3\CMS\Styleguide\TcaDataGenerator
\TableHandler\General->handle#122 // TYPO3\CMS\Styleguide\TcaDataGenerator\R
ecordData->generate#61 // TYPO3\CMS\Styleguide\TcaDataGenerator\FieldGenerat
or\TypeInline1n->generate#52 // TYPO3\CMS\Core\Database\DatabaseConnection->
exec_UPDATEquery#81 // TYPO3\CMS\Core\Database\DatabaseConnection->debug#267' (1216 chars)

I guess it uses the deprecated flashMessageApi which recently has been removed.

( ! ) Fatal error: Call to a member function add() on a non-object in /var/www/sites/sprint/typo3conf/ext/styleguide/Classes/Controller/StyleguideController.php on line 76
Call Stack
#   Time    Memory  Function    Location
1   0.0004  239328  {main}( )   ../mod.php:0
2   0.0462  4644888 TYPO3\CMS\Extbase\Core\ModuleRunner->callModule( )  ../mod.php:38
3   0.0476  4658112 TYPO3\CMS\Extbase\Core\Bootstrap->run( )    ../ModuleRunner.php:67
4   0.1244  5964776 TYPO3\CMS\Extbase\Core\Bootstrap->handleRequest( )  ../Bootstrap.php:184
5   0.1377  6081136 TYPO3\CMS\Extbase\Mvc\Web\BackendRequestHandler->handleRequest( )   ../Bootstrap.php:195
6   0.1412  6166960 TYPO3\CMS\Extbase\Mvc\Dispatcher->dispatch( )   ../BackendRequestHandler.php:30
7   0.1449  6262520 TYPO3\CMS\Extbase\Mvc\Controller\ActionController->processRequest( )    ../Dispatcher.php:69
8   0.1538  6483872 TYPO3\CMS\Extbase\Mvc\Controller\ActionController->callActionMethod( )  ../ActionController.php:160
9   0.1539  6499968 call_user_func_array:{/home/steffen/Projects/TYPO3/CMS/typo3_src-master/typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php:265} ( )   ../ActionController.php:265
10  0.1539  6500512 TYPO3\CMS\Styleguide\Controller\StyleguideController->flashMessagesAction( )    ../ActionController.php:265

add a group of nested example categories in generator, add a category tree example. this is to verify that stuff like pageTsConfig addItems does not work on trees configured with foreign_tables / mm relations (and can't ever work)

tca docs may need a hint about that, too.

Support

I would understand the "Primary button" to be the most likely used. How is the "Success button" to be used? For example, in Redirects module, the "Filter" is marked in green as the "Success button" here. But that is already the case before an action was performed.

My intention is to better understand how to mark the available buttons.

This issue is a question but also a request to add the clarifications into the styleguide - if possible.

Hello,

if I open styleguide and click on Icons I get following error:

Oops, an error occurred!
Icon with identifier "status-reference-hard" is not registered"

I have searched a little bit in core and found out, that this icon is part of impext. After enabling this extension Icon-View works as expected.

Stefan

irre -> flexform -> section

I already raised the issue in Slack.

1. Page in TER https://extensions.typo3.org/extension/styleguide/ lists extension as outdated.

2. The current installation instructions in Readme.md do not work for non-composer installations:

Head to TYPO3 backend > Extension Manager > Get Extensions. Search for and install extension key „styleguide“. Activate Styleguide extension within TYPO3 backend in Extension Manager.

3. Not possible to install via extension manager on non Composer based installations

4. Additionally, the Composer command is usually listed in the TYPO3 Extension Repository. For
   styleguide, it is not.

Since this extension is recommended in the documentation and might be used by beginners, I find current situation a little unfortunate and not new-user-friendly:

Why is extension listed as outdated? No clarification on Readme.md here or in TER. No installation instructions in TER. No possibility to install via extension manager on non Composer installations. Misleading information in this Readme.md.

I would create a PR myself to help, but not sure about what would be correct.

Many tables have a label field text_1 configured, but do not have such a field in the database. This triggers SQL errors, e.g. in recycler.

Either change to label to an existing field or use uid.

Feature Request

For https://forge.typo3.org/issues/91966 it would be good if at least one of the
styleguide example images could have default sys_file_metadata.

The generator should add something.

Show modals with all variants, e.g. confirm buttons

see patch https://review.typo3.org/#/c/49201/

section "Buttons" of styleguide does not work (tested with latest master 8.6-dev); it reports the error:

Oops, an error occurred!
Fluid parse error in template Styleguide_action_Buttons_b92f2390204c906f25c94a759aa1895181fc2331, line 1 at character 1. Error: Unkown Namespace: <core:icon identifier="apps-filetree-folder-default" /> (error code 0). Template source chunk:

Gives the same output each call.

Hi all

I just set up Typo3 release 8.7.16 as new and then styleguide release 'master' with 'TCA / Records'.
In 'ext_emconf.php' master depends on typo3 8.0.0-9.99.99.
I am not sure if this is still correct.

When I install styleguide release 'master' on typo3 8.7.16 I receive following messages:

Core: Exception handler (WEB): Uncaught TYPO3 Exception: An exception occurred while executing 'INSERT INTO tx_styleguide_staticdata (pid, value_1) VALUES (?, ?), (?, ?), (?, ?), (?, ?)' with params [5, "foo", 5, "bar", 5, "foofoo", 5, "foobar"]: Unknown column 'pid' in 'field list' | Doctrine\DBAL\Exception\InvalidFieldNameException thrown in file C:\xampp\htdocs\typo3_src-8.7.16\vendor\doctrine\dbal\lib\Doctrine\DBAL\Driver\AbstractMySQLDriver.php in line 71. Requested URL: http://localhost/typo3_src-8.7.16/typo3/index.php?M=help_StyleguideStyleguide&moduleToken=--AnonymizedToken--&tx_styleguide_help_styleguidestyleguide%5Baction%5D=tcaCreate&tx_styleguide_help_styleguidestyleguide%5Bcontroller%5D=Styleguide

Core: Exception handler (WEB): Uncaught TYPO3 Exception: An exception occurred while executing 'SELECT uidFROMtx_styleguide_elements_basic WHERE (tx_styleguide_elements_basic.pid = 13) AND ((tx_styleguide_elements_basic.deleted = 0) AND ((tx_styleguide_elements_basic.t3ver_wsid = 0) OR (tx_styleguide_elements_basic.t3ver_state<= 0)))': Unknown column 'uid' in 'field list' | Doctrine\DBAL\Exception\InvalidFieldNameException thrown in file C:\xampp\htdocs\typo3_src-8.7.16\vendor\doctrine\dbal\lib\Doctrine\DBAL\Driver\AbstractMySQLDriver.php in line 71. Requested URL: http://localhost/typo3_src-8.7.16/typo3/index.php?M=web_list&moduleToken=--AnonymizedToken--&id=13

I deleted styleguide release 'master' and installed styleguide release '8.0.7' with typo3 8.7.16.

Now extesion works fine.

• uses old TYPO3_DB DatabaseConnection
• references to deprecated code, fails for TYPO3 v10

Feature Request

Is your feature request related to a problem? Please describe.
It would be great if we had examples to be used in the TCA reference. Current examples are Hand-written:
https://docs.typo3.org/m/typo3/reference-tca/master/en-us/ColumnsConfig/Type/ImageManipulation/Properties/CropVariants.html

https://forge.typo3.org/issues/77668

Feature Request

Is your feature request related to a problem? Please describe.
In the TCA reference the examples currently used for colums > displayCond are still taken from templavoila. As templavoila's latest version is for LTS 7 there is currently no working example for display conditions in TCA.

Describe the solution you'd like
It would be marvelous to have examples for using the different rules like FIELD, REC and USER, combinations using and and or as well es examples in flexforms.

See also TYPO3-Documentation/TYPO3CMS-Reference-TCA#337

Just installed the latest typo3 v8 and styleguide via composer, did an db-compare with the result:

Oops, an error occurred! An exception occurred while executing 'SELECT uidFROMtx_styleguide_elements_basic WHERE (tx_styleguide_elements_basic.pid = 5) AND ((tx_styleguide_elements_basic.deleted = 0) AND ((tx_styleguide_elements_basic.t3ver_wsid = 0) OR (tx_styleguide_elements_basic.t3ver_state <= 0)))': Unknown column 'uid' in 'field list'

What I'm missing?

Applying commit 3e037a2 breaks "RTE 1" with the following JavaScript errors:

Uncaught TypeError: Cannot read property 'editElement' of undefined
Uncaught TypeError: Cannot read property 'ShowMicrodata-Tooltip' of undefined
Uncaught TypeError: Cannot read property 'Technische Universitat Ilmenau' of undefined
Uncaught TypeError: Cannot read property 'Insert custom element' of undefined
Uncaught TypeError: Cannot read property 'fontsize' of undefined
Uncaught TypeError: Cannot read property 'mozilla_smile' of undefined
Uncaught TypeError: Cannot read property 'Technische Universitat Ilmenau' of undefined
Uncaught TypeError: Cannot read property 'PasteToggleTooltip' of undefined
Uncaught TypeError: Cannot read property 'Quick Tag Editor' of undefined

Bug Report

Prerequisites

• Can you reproduce the problem on TYPO3 v10.4 LTS?
• Can you reproduce the problem on TYPO3 v9.5 LTS?

Description

Within the styleguide backend module beneath TCA / Records it is the possible to generate a page tree with default records and demo data, which seems not to work as intended.

Steps to Reproduce

1. Checkout latest TYPO3 branch for v9 or v10 from git://git.typo3.org/Packages/TYPO3.CMS.git
2. Run TYPO3 with current DDEV version.
3. Install styleguide extension from the extension manager.
4. Open up the Styleguide backend module and go to TCA / Records and click Create styleguide page tree with data and wait.
5. Open up the Pages backend module and expand the page tree styleguide TCA demo and inspect the pages.

Expected behavior:
The pages within styleguide TCA demo are filled with default content element records.

Actual behavior:
All pages within styleguide TCA demo are empty.

Versions

typo3/cms-styleguide 9.2.4

Feature Request

Is your feature request related to a problem? Please describe.

Not a problem yet but it will become one in the future.

Describe the solution you'd like

A Services.yaml should be in place, especially for the core DI to properly detect extbase controllers which at some point in the near future will no longer be instantiated by the object manager of Extbase. Then, all controllers need to be public services, which currently is not the case without a Services.yaml.

Hi,

Could this be interesting for styleguide

http://www.cs.tut.fi/~jkorpela/www/testel.html

Bug Report

Description

I ran into a RuntimeException following the tutorial on https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/Testing/ExtensionTesting.html

My goal is to create tests for an extension in a TYPO3 v9. Thus the git checkout 9 in the steps to reproduce.

Steps to Reproduce

1. git clone https://github.com/TYPO3/styleguide.git
2. cd styleguide/
3. git checkout 9
4. sudo Build/Scripts/runTests.sh -s composerInstall

Expected behavior: [What you expected to happen]

All tests to run.

Actual behavior: [What actually happened]

I got this output including the error:

Creating network "local_default" with the default driver

                                                                                                                      
  [RuntimeException]                                                                                                  
  replace.styleguide is invalid, it should have a vendor name, a forward slash, and a package name. The vendor and p  
  ackage name can be words separated by -, . or _. The complete name should match "^[a-z0-9]([_.-]?[a-z0-9]+)*/[a-z0  
  -9](([_.]?|-{0,2})[a-z0-9]+)*$".                                                                                    
                                                                                                                      

Removing local_composer_install_run_1 ... done
Removing network local_default

Versions

styleguide: 8.0.7
docker: 19.03.6
docker-compose: 1.17.1

Feature Request

Is your feature request related to a problem? Please describe.

My problem is that the extension icons (e.g. in the new content element wizard) are inconsistent. The TYPO3 backend is - in most parts - styled very nicely and this negatively influences the user experience and makes it look like it's in an unfinished state.

Describe the solution you'd like

Style guidelines for extension icons:

• border or not. Which color. Most of the core icons use a grey border, but not all. felogin does not. Also bootstrap_package does not.

Describe alternatives you've considered

I am currently not sure if and how this can be included in the styleguide extension. Or if this is something that could be documented elsewhere. It might also be sufficient to make the icons in the core consistent.

Additional context

New content element wizard with core plugin, calendarize, news, ods_osm, tt_address, powermail:

form + felogin:

I hope this is the right place for this. If not, please let me know and I'll take it elsewhere.

I am not sure if this is the extension to just show the backend functionality. Or if this is also the place to define backend style guidelines.

add as exmple

As the functional GeneratorTest shows, the operation fails if DBMS is mssql - the test is currently disabled on this platform.

Feature Request

Is your feature request related to a problem? Please describe.
We would need them for the TCA reference

Describe alternatives you've considered
We are currently using examples from the core and non-tested pseudo-code

section "Avatar" of styleguide does not work (tested with latest master 8.6-dev); it reports the error:

Oops, an error occurred!
Fluid parse error in template Styleguide_action_Avatar_f67162bd947c64ec6ac7b7b03dff844d84d51be2, line 1 at character 1. Error: Unkown Namespace: <be:avatar /> (error code 0). Template source chunk:

Maybe we should have elements in different contexts. Example:

• Form elements in TCEforms context
• Form elements in flexform context

and maybe others

What I understand so far while upgrading a TYPO3 project where I had a column with a db type date field it's necessary (especially with actual versions of mariadb/mysql/...) to have a NULL default value for a date field. This must also be reflected in the TCA. The previously known "feature" that 0000-00-00 as default value fails at least for me after upgrading TYPO3 from 8.7 to 10.4. https://github.com/TYPO3/styleguide/blob/e4b305b29576e3b214de498e202b165c3e35d659/Classes/TcaDataGenerator/FieldGenerator/TypeInputEvalDateDbTypeDate.php#L34

What do you folks think about? Should I prepare a PR for this scenario? The documentation does already mention the "correct way" I think: https://docs.typo3.org/m/typo3/reference-tca/10.4/en-us/ColumnsConfig/Type/inputDateTime.html#columns-input-rendertype-inputdatetime

Bug Report

Prerequisites

• Can you reproduce the problem on TYPO3 v10.4 LTS?
• Can you reproduce the problem on TYPO3 v9.5 LTS?

Description

Exception thrown when selecting "Icons" section:

Core: Exception handler (WEB): Uncaught TYPO3 Exception: #1437425804: Icon with identifier "warning-lock" is not registered"

Steps to Reproduce

1. From the styleguide backend index page, click on "Icons" in the table on the left-hand side.

Expected behavior: [What you expected to happen]

"Icon" section opens.

Actual behavior: [What actually happened]

Exception is thrown

Versions

Styleguide 10.0.0
TYPO3 10.4.10

You can get this information from executing composer show at the command line if your TYPO3 installation is composer based, otherwise the version number will be shown in the extension manager.

The StyleguideController currently uses the outdated flashmessage API by accessing the deprecated flashMessageContainer instead of invoking AbstractController::addFlashMessage().

This breaks with TYPO3 CMS 7.0 and it is safe to use the newer API which has been available since 6.2.0.