Giter Club home page Giter Club logo

portfolio's People

Stargazers

Valentin Commenge avatar coundia avatar

Watchers

James Cloos avatar

portfolio's Issues

[Insight] Commented code should not be committed - in web/app.php, line 16

in web/app.php, line 16

Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.

$kernel = new AppKernel('prod', false);
$kernel->loadClassCache();
//$kernel = new AppCache($kernel);

// When using the HttpCache, you need to call the method in your front controller instead of relying on the configuration parameter
//Request::enableHttpMethodParameterOverride();
$request = Request::createFromGlobals();
$response = $kernel->handle($request);
$response->send();
$kernel->terminate($request, $response);

Posted from SensioLabsInsight

[Insight] Commented code should not be committed - in src/…/Controller/FrontController.php, line 16

in src/AppBundle/Controller/FrontController.php, line 16

Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.

{

//    protected $keys;
//
//    public function __construct() {
//        $this->keys = ['name', 'city', 'job_title', 'description'];
//    }

    /**
     * @Route("/", name="homepage")
     */

Posted from SensioLabsInsight

[Insight] Unused use statement should be avoided - in src/AppBundle/Admin/ContentAdmin.php, line 6

in src/AppBundle/Admin/ContentAdmin.php, line 6

The class Sonata\AdminBundle\Datagrid\DatagridMapper is declared but never used. You should remove the use statement.

<?php

namespace AppBundle\Admin;

use Sonata\AdminBundle\Admin\AbstractAdmin;
use Sonata\AdminBundle\Datagrid\DatagridMapper;
use Sonata\AdminBundle\Datagrid\ListMapper;
use Sonata\AdminBundle\Form\FormMapper;
use Sonata\AdminBundle\Show\ShowMapper;

class ContentAdmin extends AbstractAdmin

Posted from SensioLabsInsight

[Insight] Commented code should not be committed - in web/app.php, line 13

in web/app.php, line 13

Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.

$loader = require __DIR__.'/../app/autoload.php';
include_once __DIR__.'/../var/bootstrap.php.cache';

$kernel = new AppKernel('prod', false);
$kernel->loadClassCache();
//$kernel = new AppCache($kernel);

// When using the HttpCache, you need to call the method in your front controller instead of relying on the configuration parameter
//Request::enableHttpMethodParameterOverride();
$request = Request::createFromGlobals();
$response = $kernel->handle($request);

Posted from SensioLabsInsight

[Insight] Symfony applications should not contain a config.php file - in web, line 0

in web

This config.php file should only be used to bootstrap a Symfony application. Before releasing to production, you should remove it, otherwise attackers could get valuable insight about your application.


web/
├── css/
├── images/
├── app.php
├── app_dev.php
├── apple-touch-icon.png
├── config.php
├── favicon.ico
├── ngrok
└── robots.txt

Posted from SensioLabsInsight

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.