twolfson / json2fontcss Goto Github PK

The current version of doubleshot for testing does not use the proper exit code. As a result, Travis CI will not receive the proper test status.

The URL for SVG version of a font in src property of @font-face is appended with #icomoon suffix, but what if I have my own SVG font, not affiliated with Icomoon?

src: {{#fonts.eot}}url("{{{fonts.eot}}}?#iefix") format("embedded-opentype"),
     {{/fonts.eot}}{{#fonts.woff}}url("{{{fonts.woff}}}") format("woff"),
     {{/fonts.woff}}{{#fonts.ttf}}url("{{{fonts.ttf}}}") format("truetype"),
     {{/fonts.ttf}}{{#fonts.svg}}url("{{{fonts.svg}}}#icomoon") format("svg"){{/fonts.svg}};

IMO the module should not depend on any vendor extensions. If the filename is foo.svg#icomoon, then it should be assigned to fonts.svg as it is. (And what a strange name btw.)

The same holds true for ?#iefix.

This module can certainly be more useful be it a bit more generic.