twofas / 2fas-server Goto Github PK

Issue 1:

In the contributing section of the README it says that to contribute, you should "Create a new pull request from your fork to the master branch of the main repository."

No branch is named master, so it should be changed to main. (However, as you will see in issue 3 below, it says in the CONTRIBUTING.md to create pull requests to the develop branch.)

Issue 2:

In the bug reporting section of the README it gives an outdated link to check for existing issues.

"We use GitHub for bug reports. Please visit the 2FAS Server API issues page to search for and report any bugs..."

The correct link is https://github.com/twofas/2fas-server/issues or https://github.com/twofas/2fas-server/labels/bug

Issue 3:

In the CONTRIBUTING.md, it also gives an outdated link for searching existing issues.

It also says to "Open a pull request from your branch to the develop branch of this repository".

No branch is named develop (only develop/pass and a few other similarly named branches), and this information conflicts the instructions in the README.

I'd like to know which branch contributors should PR to so I can correct these mistakes. Thanks

The GPLv3 license does not count network use as distribution.

You may want to re-license 2fas-server to AGPLv3 while keeping the mobile app repositories as GPLv3. This is similar to the approach taken by Bitwarden.

LastPass just made me reset my 2FA. I did the following:

1. Scanned new QR code in 2FAS Android.
2. Entered TOTP CODE by hand into LastPass to confirm the new TOTP seed.
3. Trashed the old LastPass entry in 2FAS Android.
4. Tried to log into LastPass again to confirm everything was working.
5. When prompted for my 2FAS code, sent a request to 2FAS.
6. 2FAS said there was an error sending the code.

2FAS refused to start sending the code to LastPass until I removed the old LastPass item from my trash in the 2FAS app.

I tried to submit this through the contact us popup form from the website, but clicking "Send Message" did not work. Hope this is ok here.

Hello, I am a game developer who is considering using 2fas as an authenticator for a web based admin page accessible for a running game server.

The server is written in C#, so would presumably need to hit a back-end API endpoints for 2fas to direct users to a QR code, and then later to validate keys.

I started implementing this functionality with Google Authenticator, as there is a really easy C# package on nuget for it https://github.com/NickyBall/GoogleAuthenticatorService.Core

But I like what 2fas offers as far as the browser extension and stuff that will make it easier on server operators.

I was wondering if yall have API support(endpoints, etc) that might facilitate hooking up a 'custom service' like this?

Thanks
Jeremy

Is there a way that I can change the docker-compose to use an already existing mysql and redis services? They are running on different hardware so the system would have to address IPs and not just internal docker naming. Thanks!

Hey, first of all: 2FAS is an awesome app and I really like using it!

Do you plan to support self hosting the server software? Well, technically this is already possible using this repo but I do not see any way to change the server URL in the apps and browser extension. Is this a planned feature?

api/openapi/rest.yaml shows that request_2fa_token has a "domain" parameter and gives "facebook.com" as an example of what to put in this parameter.

However, the code in internal/api/browser_extension/app/command/request_2fa_token.go makes it clear that what is expected in this parameter is a URL, not a domain, since it tries to parse the domain parameter as a URL and sets the requested site to an empty string if the parse fails.

There are thus two problems here. The first, which may be too hard to fix at this point, is that you called the parameter domain instead of url. The second, which is easier to fix, is that your openapi definition documents incorrectly what goes into the parameter. You could keep the bad parameter name if it's too hard to fix but at least update the documentation to accurately reflect what is expected.