Update to Stylelint 14 and the latest plugin versions about stylelint-config-twbs-bootstrap HOT 8 CLOSED

Sounds good, I'll see what I can accomplish this week

from stylelint-config-twbs-bootstrap.

You can now combine your configs into a single file using the new overrides configuration property, like so:

{
  "extends": ["stylelint-config-standard"],
  "overrides": [
    {
      "files": "**/*.scss",
      "extends": ["stylelint-config-standard-scss"]
    }
  ]
}

This will get you most of the way there.

I suggest extending stylelint-config-standard-scss, rather than the recommended one.

The latest version of standard config includes a dozen or so new rules. So does the standard SCSS config and its parent config. I suspect most of the rules in your configs are no longer needed. I suggest layering the rules you do need back onto the foundation above (you may not need any for the SCSS override!):

{
  "extends": ["stylelint-config-standard"],
  "plugins": ["stylelint-order"],
  "rules": {
    "color-named": "never",
    "font-weight-notation": [
      "numeric",
      {
        "ignore": ["relative"]
      }
    ],
    "order/properties-order": ["position" ..]
    ..
  },
  "overrides": [
    {
      "files": "**/*.scss",
      "extends": ["stylelint-config-standard-scss"],
      "rules": {
        ..
      }
    }
  ]
}

Then bump stylelint-order to the latest version.

Lastly, remove Node.js 10 from your workflow.

I'm away and offline for the next few days, but I'm happy to review a pull request when I'm back if someone rustles one up while I'm away.

from stylelint-config-twbs-bootstrap.

Thanks for the reply! I'll try to take a stab at it, but it'd really help us if you could have a look too. It's a hard period for me so any help would be much appreciated ❤

from stylelint-config-twbs-bootstrap.

@XhmikosR I looked into this but ran into an issue upstream which I think we'll need to resolve first.

from stylelint-config-twbs-bootstrap.

Do you guys need help here? Shouldn't updating the versions be a very simple/quick task? The overrides stuff should happen in a separate issue/PR to keep things moving imo.

from stylelint-config-twbs-bootstrap.

Yeah, we could definitely use help here! I have a branch which just updates the deps https://github.com/twbs/stylelint-config-twbs-bootstrap/compare/dev

But we need to update the packages to the new versions and it seems @Jeddy has pinpointed another issue upstream.

Ideally we should make v3.0.0 with @jeddy3's suggestions since it looks like we could get many of our overrides.

from stylelint-config-twbs-bootstrap.

Shouldn't updating the versions be a very simple/quick task?

There are a number of breaking changes in Stylelint 14 and I think more may be needed than bumping the deps.

and it seems @Jeddy has pinpointed another issue upstream.

The issue has been fixed in main and we hope to put out a release this weekend.

@fgblomqvist It'd be amazing if you could do the legwork of discovering which of the existing rules are still needed (considering that the major releases of the extended configs turn on a dozen new rules each). You can either use main of Stylelint as a temp dep or wait until 14.1.0 is out before opening a pull request, which I'm happy to look over. Just at-mention me as I don't watch this repo.

from stylelint-config-twbs-bootstrap.

Thanks. 14.1.0 was released, so the following should work now:

{
  "extends": ["stylelint-config-standard"],
  "plugins": ["stylelint-order"],
  "rules": {
    "color-named": "never",
    "font-weight-notation": [
      "numeric",
      {
        "ignore": ["relative"]
      }
    ],
    "order/properties-order": ["position" ..]
    ..
  },
  "overrides": [
    {
      "files": "**/*.scss",
      "extends": ["stylelint-config-standard-scss"],
      "rules": {
        ..
      }
    }
  ]
}

from stylelint-config-twbs-bootstrap.