Giter Club home page Giter Club logo

Comments (8)

XhmikosR avatar XhmikosR commented on May 8, 2024 1

We don't have the bandwidth to work on cleaning the configs, but you are welcome to provide a PR assuming all the current rules are still included.

I'll make a new release for this.

from stylelint-config-twbs-bootstrap.

XhmikosR avatar XhmikosR commented on May 8, 2024

Hmm, perhaps we should disable the rule in the Scss config indeed. Right now the scss config inherits from the CSS config where the rule is enabled.

from stylelint-config-twbs-bootstrap.

fgblomqvist avatar fgblomqvist commented on May 8, 2024

Out of curiosity, why does the scss config inherit from css? Doesn't that defeat a part of the purpose of keeping them separate?

from stylelint-config-twbs-bootstrap.

XhmikosR avatar XhmikosR commented on May 8, 2024

Because many rules are common and it's been working for us for all these years.

from stylelint-config-twbs-bootstrap.

XhmikosR avatar XhmikosR commented on May 8, 2024

Please try this branch https://github.com/twbs/stylelint-config-twbs-bootstrap/tree/XhmikosR-patch-1

from stylelint-config-twbs-bootstrap.

fgblomqvist avatar fgblomqvist commented on May 8, 2024

The issue rn is that by inheriting from css in scss, you also inherit stylelint-config-standard. That one in turn inherits stylelint-config-recommended. That doesn't feel right.

With your current setup, your SCSS extends chain look like this:

  1. stylelint-config-recommended - OK
  2. stylelint-config-recommended-scss - Disables some CSS-specific stuff from the -recommended one
  3. stylelint-config-recommended - This undoes step 2
  4. stylelint-config-standard - OK
  5. ../css - OK

I've bolded the ones you directly reference from your scss config. As you can see, step 2 is redundant. It would make sense to therefore drop the dep on that one (it does so little and is barely even maintained anymore) which would reduce confusion and "clean up" your chain so that you're extending from various CSS configs, then finally (in your SCSS one) do SCSS stuff.

from stylelint-config-twbs-bootstrap.

fgblomqvist avatar fgblomqvist commented on May 8, 2024

Will try the patch (but I'm 99% sure it'll work).

from stylelint-config-twbs-bootstrap.

fgblomqvist avatar fgblomqvist commented on May 8, 2024

It worked.

from stylelint-config-twbs-bootstrap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.