Comments (8)
We don't have the bandwidth to work on cleaning the configs, but you are welcome to provide a PR assuming all the current rules are still included.
I'll make a new release for this.
from stylelint-config-twbs-bootstrap.
Hmm, perhaps we should disable the rule in the Scss config indeed. Right now the scss config inherits from the CSS config where the rule is enabled.
from stylelint-config-twbs-bootstrap.
Out of curiosity, why does the scss config inherit from css? Doesn't that defeat a part of the purpose of keeping them separate?
from stylelint-config-twbs-bootstrap.
Because many rules are common and it's been working for us for all these years.
from stylelint-config-twbs-bootstrap.
Please try this branch https://github.com/twbs/stylelint-config-twbs-bootstrap/tree/XhmikosR-patch-1
from stylelint-config-twbs-bootstrap.
The issue rn is that by inheriting from css
in scss
, you also inherit stylelint-config-standard
. That one in turn inherits stylelint-config-recommended
. That doesn't feel right.
With your current setup, your SCSS extends chain look like this:
- stylelint-config-recommended - OK
- stylelint-config-recommended-scss - Disables some CSS-specific stuff from the
-recommended
one - stylelint-config-recommended - This undoes step 2
- stylelint-config-standard - OK
- ../css - OK
I've bolded the ones you directly reference from your scss config. As you can see, step 2 is redundant. It would make sense to therefore drop the dep on that one (it does so little and is barely even maintained anymore) which would reduce confusion and "clean up" your chain so that you're extending from various CSS configs, then finally (in your SCSS one) do SCSS stuff.
from stylelint-config-twbs-bootstrap.
Will try the patch (but I'm 99% sure it'll work).
from stylelint-config-twbs-bootstrap.
It worked.
from stylelint-config-twbs-bootstrap.
Related Issues (20)
- Enable `ignoreDefault` for `no-duplicate-dollar-variables`
- [ANOTHER] for eslint
- Split common rules to a new shared file
- new property like ...-inline or ...-block HOT 6
- Update to Stylelint 14 and the latest plugin versions HOT 8
- Add CSS Grid properties support HOT 5
- `selector-class-pattern` change in >= v3.0.0-alpha1 HOT 6
- Consider disabling function-no-unknown for SCSS files HOT 3
- Is it necessary to have stylelint-scss as direct dependency? HOT 1
- Update to Stylelint 15 HOT 2
- Fix deprecation warnings/find replacements for these rules HOT 5
- Remove stylelint-stylistic HOT 1
- Why font-weight should go before font-family?
- Deprecation warnings: HOT 1
- Allow usage of stylelint 16.0
- Remove `scss/dollar-variable-default`?
- Enable `scss/map-keys-quotes` HOT 2
- Drop IE properties HOT 4
- Consider adding more rules HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stylelint-config-twbs-bootstrap.