twaldear / flask-secure-headers Goto Github PK

This extension is good for adding secure headers to 200 status code by using @sh.wrapper() decorator. How to integrate this to all 400 and 500 errors?

It would be great to see this made python3 compatible. Any plans for that?

Hey, I was just comparing this library against flask-csp and finally realized that they're by the same person!

Out of curiosity, is flask-secure-headers meant to supersede flask-csp?

Can you please remove the ',' in line no 70 where you put the except.

SimpleHeader.check_valid seems to only end up checking 1 param before returning True, and so not all the validation happens I think.

https://github.com/twaldear/flask-secure-headers/blob/master/flask_secure_headers/headers.py#L11

Also, I am getting a validation exception for the default values, in cases where it does end up hitting the validate for report-uri.

https://github.com/twaldear/flask-secure-headers/blob/master/flask_secure_headers/core.py#L37

Defaults to /hpkp_report but

https://github.com/twaldear/flask-secure-headers/blob/master/flask_secure_headers/headers.py#L101

Says only * is valid, unless I am reading it wrong.