Hi, I'm Tim

🌍 German developer 🇩🇪
📖 Studying Data Science
🤖 Sometimes teaching Computers how to do things.

memphis-rust-community's People

Contributors

Stargazers

Watchers

memphis-rust-community's Issues

Update Readme with more examples

ping_consumer does not properly check for canceled token.

This should use the tokio::select! macro to speed up cancelation, and prevent raceconditions

memphis-rust-community/memphis/src/consumer/memphis_consumer.rs

Lines 359 to 427 in 1744638

 fn ping_consumer(&self) { 

 let cloned_token = self.cancellation_token.clone(); 

 let cloned_client = self.station.memphis_client.clone(); 

 let cloned_partitions_data = self.partitions_list.clone(); 

 let cloned_station = self.station.clone(); 

 let consumer_name = self.get_name(); 

 let durable_name = self.get_internal_name(); 

 tokio::spawn(async move { 

 async fn ping_stream_consumer( 

 stream_name: &str, 

 consumer_name: &str, 

 client: &MemphisClient, 

 ) -> Result<(), async_nats::Error> { 

 let stream = client 

 .get_jetstream_context() 

 .get_stream(stream_name) 

 .await?; 

 let _consumer = stream.consumer_info(consumer_name).await?; 

 Ok(()) 

 } 

 while !cloned_token.is_cancelled() { 

 tokio::time::sleep(Duration::from_secs(30)).await; 

 match &cloned_partitions_data { 

 None => { 

 let res = ping_stream_consumer( 

 &cloned_station.get_internal_name(None), 

 &durable_name, 

 &cloned_client, 

 ) 

 .await; 

 if let Err(e) = res { 

 error!("Error pinging consumer. {}", e); 

 continue; 

 } else { 

 trace!( 

 "Consumer '{}' on station '{}' is still alive.", 

 &consumer_name, 

 &cloned_station.options.station_name 

 ) 

 } 

 } 

 Some(data) => { 

 for x in data { 

 let res = ping_stream_consumer( 

 &cloned_station.get_internal_name(Some(*x)), 

 &durable_name, 

 &cloned_client, 

 ) 

 .await; 

 if let Err(e) = res { 

 error!("Error pinging consumer. {}", e); 

 continue; 

 } else { 

 trace!( 

 "Consumer '{}' on station '{}' is still alive.", 

 &consumer_name, 

 &cloned_station.options.station_name 

 ) 

 } 

 } 

 } 

 }; 

 } 

 }); 

 }

Example of how it should be implemented:

memphis-rust-community/memphis/src/consumer/memphis_consumer.rs

Lines 179 to 235 in 1744638

 let handle = tokio::spawn(async move { 

 while !cancellation_token.is_cancelled() { 

 let msg_handler = consumer 

 .batch() 

 .max_messages(options.batch_size) 

 .expires(Duration::from_millis(options.batch_max_time_to_wait_ms)) 

 .messages() 

 .await; 

 let mut batch = match msg_handler { 

 Ok(batch) => batch, 

 Err(e) => { 

 error!("Error while receiving messages from Memphis. {}", e); 

 continue; 

 } 

 }; 

 while let Some(Ok(msg)) = batch.next().await { 

 trace!( 

 "Message received from Memphis. (Subject: {}, Sequence: {})", 

 msg.subject, 

 match msg.info() { 

 Ok(info) => info.stream_sequence, 

 Err(_e) => 0, 

 } 

 ); 

 let memphis_message = MemphisMessage::new( 

 msg, 

 client.clone(), 

 options.consumer_group.clone(), 

 options.max_ack_time_ms, 

 ); 

 let res = sender.send(MemphisEvent::MessageReceived(memphis_message)); 

 if res.is_err() { 

 error!( 

 "Error while sending message to the receiver. {:?}", 

 res.err() 

 ); 

 } 

 } 

 } 

 }); 

 tokio::spawn(async move { 

 tokio::select! { 

 _ = handle => { 

 warn!("Consumer '{}' on group '{}' stopped consuming.", &cloned_options.consumer_name, &cloned_options.consumer_group); 

 }, 

 _ = cancel_token.cancelled() => { 

 debug!("Consumer '{}' on group '{}' was cancelled.", &cloned_options.consumer_name, &cloned_options.consumer_group); 

 } 

 } 

 }); 

 Ok(())

Station Implementation

Reference: https://github.com/memphisdev/memphis.py/blob/master/memphis/station.py

Get Name of Consumer / Producer

Make send_notifaction private

Client not Reconnecting Properly?

Implementation to destroy Consumer

Implement the ability to properly destroy a consumer.
Reference: https://github.com/memphisdev/memphis.py/blob/4424d4219e91090293903afb6e53c5efafefede4/memphis/consumer.py#L208-L236

Maybe also add an option to automatically destroy the consumer once the value is dropped using the Drop Trait.

Ability to Manually disconnect from Broker.

Implement stop consumer function

This function will stop the consumer, but not delete it from memphis

Producer Implementation

Reference: https://github.com/memphisdev/memphis.py/blob/master/memphis/producer.py

Fix shutdown behaiviour being weird at times.

Schemaverse Implementation

Consumer DLS Implementation

Ability to listen to DLS Messages.
Reference: https://github.com/memphisdev/memphis.py/blob/bb2640359b7b2a02068745d1d2fca0edd4eecb43/memphis/consumer.py#L90-L116

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.

Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

TensorFlow

An Open Source Machine Learning Framework for Everyone

Django

The Web framework for perfectionists with deadlines.

Laravel

A PHP framework for web artisans

D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

web

Some thing interesting about web. New door for the world.

server

A server is a program made to process requests and deliver data to clients.

Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

Visualization

Some thing interesting about visualization, use data art

Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.

Microsoft

Open source projects and samples from Microsoft.

Google

Google ❤️ Open Source for everyone.

Alibaba

Alibaba Open Source for everyone

D3

Data-Driven Documents codes.

Tencent

China tencent open source team.

	fn ping_consumer(&self) {
	let cloned_token = self.cancellation_token.clone();
	let cloned_client = self.station.memphis_client.clone();
	let cloned_partitions_data = self.partitions_list.clone();
	let cloned_station = self.station.clone();

	let consumer_name = self.get_name();
	let durable_name = self.get_internal_name();

	tokio::spawn(async move {
	async fn ping_stream_consumer(
	stream_name: &str,
	consumer_name: &str,
	client: &MemphisClient,
	) -> Result<(), async_nats::Error> {
	let stream = client
	.get_jetstream_context()
	.get_stream(stream_name)
	.await?;

	let _consumer = stream.consumer_info(consumer_name).await?;

	Ok(())
	}
	while !cloned_token.is_cancelled() {
	tokio::time::sleep(Duration::from_secs(30)).await;
	match &cloned_partitions_data {
	None => {
	let res = ping_stream_consumer(
	&cloned_station.get_internal_name(None),
	&durable_name,
	&cloned_client,
	)
	.await;
	if let Err(e) = res {
	error!("Error pinging consumer. {}", e);
	continue;
	} else {
	trace!(
	"Consumer '{}' on station '{}' is still alive.",
	&consumer_name,
	&cloned_station.options.station_name
	)
	}
	}
	Some(data) => {
	for x in data {
	let res = ping_stream_consumer(
	&cloned_station.get_internal_name(Some(*x)),
	&durable_name,
	&cloned_client,
	)
	.await;
	if let Err(e) = res {
	error!("Error pinging consumer. {}", e);
	continue;
	} else {
	trace!(
	"Consumer '{}' on station '{}' is still alive.",
	&consumer_name,
	&cloned_station.options.station_name
	)
	}
	}
	}
	};
	}
	});
	}

	let handle = tokio::spawn(async move {
	while !cancellation_token.is_cancelled() {
	let msg_handler = consumer
	.batch()
	.max_messages(options.batch_size)
	.expires(Duration::from_millis(options.batch_max_time_to_wait_ms))
	.messages()
	.await;

	let mut batch = match msg_handler {
	Ok(batch) => batch,
	Err(e) => {
	error!("Error while receiving messages from Memphis. {}", e);
	continue;
	}
	};

	while let Some(Ok(msg)) = batch.next().await {
	trace!(
	"Message received from Memphis. (Subject: {}, Sequence: {})",
	msg.subject,
	match msg.info() {
	Ok(info) => info.stream_sequence,
	Err(_e) => 0,
	}
	);

	let memphis_message = MemphisMessage::new(
	msg,
	client.clone(),
	options.consumer_group.clone(),
	options.max_ack_time_ms,
	);

	let res = sender.send(MemphisEvent::MessageReceived(memphis_message));
	if res.is_err() {
	error!(
	"Error while sending message to the receiver. {:?}",
	res.err()
	);
	}
	}
	}
	});

	tokio::spawn(async move {
	tokio::select! {
	_ = handle => {
	warn!("Consumer '{}' on group '{}' stopped consuming.", &cloned_options.consumer_name, &cloned_options.consumer_group);
	},
	_ = cancel_token.cancelled() => {
	debug!("Consumer '{}' on group '{}' was cancelled.", &cloned_options.consumer_name, &cloned_options.consumer_group);
	}
	}
	});

	Ok(())

turulix / memphis-rust-community Goto Github PK

memphis-rust-community's Introduction