Why not over the client? To utilize the knownJoinedRooms caching!

https://github.com/turt2live/matrix-js-bot-sdk/blob/fd950f606e76867d2bf3e8e10913755269ebea4d/package.json#L50

Similar to https://github.com/turt2live/matrix-bot-sdk-bot-template but for appservices, specifically bridges. Not really sure how this should be handled - possibly an opinionated abstraction layer to plug in whatever remote network?

Not everyone should have to have a copy of express - it should be made optional.

Currently Appservice Intent.ensureJoined() returns undefined if the ghost was already in the room, elsewise it returns the rooms mxid

This is really helpful to detect if a join actually happened, for if you needed to do some additional stuff based on that.

Perhaps consider this a feature, document it and set the return type that function correctly to Promise<string | undefined>

If an AS is missconfigured this lib throws an unhandled promise rejection as it can't decode JSON:

(node:3853) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected token < in JSON at position 0
    at JSON.parse (<anonymous>)
    at Intent.<anonymous> (/home/sorunome/repos/mx-puppet-bridge/node_modules/matrix-bot-sdk/lib/appservice/Intent.js:135:41)
    at Generator.throw (<anonymous>)
    at rejected (/home/sorunome/repos/mx-puppet-bridge/node_modules/matrix-bot-sdk/lib/appservice/Intent.js:5:65)
    at processTicksAndRejections (internal/process/task_queues.js:86:5)

perhaps handle this?

Nothing is going to drastically change anytime soon, however we should still have event.getContent() style classes to be future-proof.

For clients and appservices

Stuff like requests being made, their duration, API call counters(?), etc

• MatrixClient
• Appservice
• Intent

Maybe with a flag? Maybe without? It's a common thing for bot authors to write the exact same code to filter the sync

Because each MatrixClient has it's own metrics counter, which makes them hard to bind to. Can appservices bind all intents to the same metrics counter, or alternatively expose a way for a bridge to bind to every MatrixClient in some way.

matrix-org/matrix-js-sdk#1001 (the js-sdk code is largely inspired from this SDK).

https://t2l.io/_matrix/media/v1/download/maunium.net/krWimCMDEpOOSeAvPBVjmtPe

The client holds a vast number of useful things that we are using in the bridge, but it's a little ugly to have to access the client indirectly. I realise it might slightly uglyify the shape of your API, but would be useful nontheless.

https://github.blog/2019-06-06-generate-new-repositories-with-repository-templates/

• Simple bot with commands
• Simple 2-way bridge
• Handling room upgrades
• Handling rich replies

Something where the bridge can dump a list of remote user objects into a function and have the SDK automatically figure out which ones need to get configured in the room.

Hi!
I have an usecase where a new room alias can lead to an already existing room.
Unfortunatly I can not query possible room aliases and set them up before the homeserver queries the room.
So at least for my usecase it would be benifitial if I could skip the part where the appservice creates a room and just add an alias to the existing room.

My proposal would add a shortcut to the callback handling true (same as the sdk already handles false and sends a 404).
So an example would look like that:

appservice.on("query.room", async (alias, fn) => {
    /* some userspace code handling setup of the required alias */
    fn(true);
});

This would be fairly easy to implement as it's basicly just adding:

else if (result === true) {
   res.status(200).json({});
}

here: https://github.com/turt2live/matrix-js-bot-sdk/blob/fd950f606e76867d2bf3e8e10913755269ebea4d/src/appservice/Appservice.ts#L655

What Do you think and thanks for your time.

Mostly for pills and bridges

Stop syncing at the very least

So that we can avoid using console.log everywhere

Need to define return types, function parameter types, etc as verbosely as possible.

See https://github.com/turt2live/matrix-js-bot-sdk/blob/develop/src/models/events/_MissingEvents.md for the missing ones. Pick the closest example of an event that already exists and copy/paste it - not all the fields need to be exposed, just the common ones.

In matrix-appservice-bridge, there is a callback for "onAliasQueried" which returns the alias and roomId. This is useful for sending normal events into the room once it's been created.

Something like getOrCreateManagementChat(userId) and setManagementChat(userId, roomId) for bridges to use.

A "management chat" is basically a 1:1 with a user where we don't expect other users.

We use it for one thing. We should rip it out of that one place to avoid having to include it.

When an event is raised by the SDK it should have the /sync request/response info, member profile, event itself, room ID, etc all easily accessible to the receiver. This makes it easier to form replies, mentions, etc without the extra API hits.

This should also be opt-in.

Supplying the membership/not_membership filter to getRoomMembers(), results in a malformed request being sent like below:
/members?membership%5B0%5D=ban -> /members?membership[0]=ban
Since the server doesn't recognize any of the supplied filters, it just returns all members of the room.

if AppserviceJoinRoomStrategy fails due to e.g. the appservice bot not being in that room it doesn't propagate to the next underlyingStrategy

Because it's rather essential to be able to make asynchronous requests to databases.

as much fun as it is to see logs scream by while it desperately tries to sync

eg: the invite list on the createRoom endpoint becomes an object keyed by index

The appservice user events (room.join, room.invite, room.leave) only easily present the roomId, the userId needs to be fetched via the event.

As the userId is commonly needed for handling those events, perhaps consider making that a parameter

The matrix-appservice-bridge library adds additional endpoints specific to itself, so it would be nice to add our own routes to it.

Similarly to how the matrix-appservice-bridge sdk does it.

I want to do run syncing with the param set_presence=offline as specced here

UseCase: Run the bot as silent client as myself while people still see if I am online or not

they are missing the room ID in the event handler

This can be useful e.g. when somebody invites a ghost to initiate 1:1 conversation to figure out which ghost that is, as usually the suffix is some kind of ID

I'm surprised this isn't an issue (perhaps we all rely on intellisense :p).

Why didn't the tests catch this? It's splitting up strings now when in arrays