tullamods / omnicc Goto Github PK

View Code? Open in Web Editor NEW

93.0 10.0 20.0 888 KB

Cooldown count for everything

Home Page: https://tullamods.com/omnicc

License: MIT License

Lua 100.00%

combat world-of-warcraft-addon world-of-warcraft lua

omnicc's Introduction

OmniCC 🕐

OmniCC is an World of Wacraft addon that adds text to items, spell and abilities that are on cooldown to indicate when they will be ready to use. In other words: it turns all the standard analogue cooldowns into digital ones.

Anything should work with OmniCC, from the action bars to the inventory, from the standard interface to your favorite add-on.

omnicc's People

Stargazers

Watchers

Forkers

sayclub nobgul resike teile caelivs meribold lmzyk martinjlowm 1ps3 rainrider wolfcon pgmbru bluenightsky kitekingw wowinterfaces owlietm crispgm suannailiumang anon1231823 hollicsh

omnicc's Issues

Cooldown Alpha

Would it be possible to add something like this http://www.wowinterface.com/downloads/info18991-CooldownAlpha.html to OmniCC? It alters the alpha on the whole button while the ability is on cooldown, it worked fine on its own till 4.3... in tandem with Dominoes and OmniCC...

OmniCC doesn't show timer on Certain Bartender Bars

OmniCC doesn't show cooldowns on Bartender bars 5 and 6, to my knowledge...

I have a macro and the abilities for Pillar of Frost on my DK... the macro hits Pillar of Frost, and then Blood Fury because I'm a orc, and it doesn't show a CD in any bar... just the standard Blizzard cooldown.

http://i51.tinypic.com/2d1k6th.jpg

There's a example, on the left bar, top right ability is my macro, on the bottom right of it is my actual abilities.

Cooldown timer not showing

PTR 4.3.0 (14899)

Only tested on rogue and DK, but whenever you activate a CD, you must switch your "presence" (to frost, blood, etc) to get the cooldown timer to show up. Similar situation with rogues, you must go stealth or unstealth for a timer to show up. Renamed "WTF" folder to ensure its clear, using version 4.2.3.

Internal Cooldown

I'm not sure if this was asked before, I have checked here, and haven't found anything related, so apologies if it was previously mentioned.

Would it be possible to add an internal CD display for trinkets?
I'm totally clueless when it comes to programming of course, so I'm really not sure what it takes to make that work, but basically once a trinket like, lets say, [Heart of Rage] - http://www.wowhead.com/item=65072/heart-of-rage procs, it takes 90 seconds until it is available again. It would be nice to see that on the bar itself like the other OmniCC CDs.

Since (as far as I know) each trinket has a different ICD, it might require some work to maintain a database of trinkets and their ICD. In that case it might be a good idea to create this feature and let the user add his own CD.

Error on login

2x OmniCC-5.0.5\effects\effects.lua:15: attempt to index a nil value
OmniCC-5.0.5\effects\effects.lua:15: in function "SetupEffect"
OmniCC-5.0.5\core\cooldown.lua:20: in function "Setup"
OmniCC-5.0.5\core\actions.lua:24: in function "Add"
OmniCC-5.0.5\core\actions.lua:14: in function "AddDefaults"
OmniCC-5.0.5\main.lua:24: in function "?"
OmniCC-5.0.5\main.lua:15: in function <OmniCC\main.lua:14>

Locals:
self = ActionButton1Cooldown {
0 =
omniccAction = 1
omnicc = true
}
Cooldown = {
CanShow = @Omnicc\core\cooldown.lua:41
OnShow = @Omnicc\core\cooldown.lua:55
OnHide = @Omnicc\core\cooldown.lua:67
Setup = @Omnicc\core\cooldown.lua:12
Stop = @Omnicc\core\cooldown.lua:34
OnSizeChanged = @Omnicc\core\cooldown.lua:75
Start = @Omnicc\core\cooldown.lua:23
0 =
Bind = @Omnicc\libs..\Classy-1.0.lua:21
mt =

{}
}

Fix Text Autoscaling

Text auto scaling is not working in the 3.0 betas

New Method Signature for CooldownFrame_SetTimer and Cooldown:SetCooldown

From looking at Cooldown.lua, Cooldown:SetCooldown now has charges and maxCharges as additional arguments.

function CooldownFrame_SetTimer(self, start, duration, enable, charges, maxCharges)
    self:SetCooldown(start, duration, charges, maxCharges)
end

Side note:
Your branch of OmniCC appears to be out of date vs the latest release on Curse. Otherwise, I'd have created a pull request myself :)

Hide 0 second cooldowns

http://wow.curseforge.com/addons/omni-cc/tickets/12-if-tenths-of-seconds-add-1-to-cooldown/

What is the enhancement in mind? How should it look and feel?

imho 1 has to be the last number shown instead of 0 (if tenths of seconds is on, 0.1 has to be the last - as it is)

why do i think that?
"0 seconds remaining" sounds like "your shit is ready" but as it is not ready, it is fail
and wow is a game where this 1 second can cost a lot of dps and even decide bosskill or wipe ;)

so far... accept or not, i'm using the tenths as i found the setting to reenable after update from beta4 to 5 but i think there are other player who care for that change - and maybe not know that they can post a ticket here :D

kind regards

Error while attempting to run classic OnUpdate Engine

Hi,

I suspect that Omnicc might be causing crashes (sometimes hard locks even) problems. Running Omnicc with Blizzard's default UI hasn't crashed me yet; however, running Shadow unit frames or Pitbull 4 has crashed me in the past. I'm trying to follow the suggestion to run the old ondate engine and received this error in game while using the run command. I get the same error with the both the latest released version on curse and the beta version. Any help would be appreciated.

1x :"OmniCC:SetUpdateEngine('ClassicUpdater’)":1: unfinished string near ''
Interface\FrameXML\ChatFrame.lua:2043: in function ?': Interface\FrameXML\ChatFrame.lua:4214: in functionChatEdit_ParseText':
Interface\FrameXML\ChatFrame.lua:3825: in function ChatEdit_SendText': Interface\FrameXML\ChatFrame.lua:3863: in functionChatEdit_OnEnterPressed':
:":OnEnterPressed":1: in function <[string ":OnEnterPressed"]:1>

Glow finish effect

Per a user request, I should implement a glow effect that mimics the Blizzard effect for buttons you should press.

bug report

Errors generated in HUP during combat

1x OmniCC-4.0.beta6\timer.lua:129: attempt to perform arithmetic on field 'start' (a nil value)
OmniCC-4.0.beta6\timer.lua:88: in function Start' OmniCC-4.0.beta6\timer.lua:414: in function <OmniCC\timer.lua:395> <in C code>: in functionSetCooldown'
Interface\FrameXML\Cooldown.lua:4: in function CooldownFrame_SetTimer': Interface\FrameXML\ActionButton.lua:363: in functionActionButton_UpdateCooldown':
Interface\FrameXML\ActionButton.lua:475: in function ActionButton_OnEvent': <string>:"*:OnEvent":1: in function <[string "*:OnEvent"]:1> <in C code>: in functionCastSpellByName'
Interface\FrameXML\ChatFrame.lua:1029: in function ?': Interface\FrameXML\ChatFrame.lua:4088: in function <Interface\FrameXML\ChatFrame.lua:4054>: <in C code>: in functionChatEdit_ParseText'
Interface\FrameXML\ChatFrame.lua:3717: in function ChatEdit_SendText': Interface\FrameXML\ChatFrame.lua:2524: in function <Interface\FrameXML\ChatFrame.lua:2517>: <in C code>: in functionUseAction'
Interface\FrameXML\SecureTemplates.lua:274: in function handler': Interface\FrameXML\SecureTemplates.lua:540: in functionSecureActionButton_OnClick':
Interface\FrameXML\MultiActionBars.lua:19: in function `MultiActionButtonUp':
:"MULTIACTIONBAR1BUTTON4":4: in function <[string "MULTIACTIONBAR1BUTTON4"]:1>

Locals:
self = {
abRatio = 1
text = {}
0 =
updater = {}
cooldown = ActionButton2Cooldown {}
}
start = 1692908.42
duration = 3

Locals:
self = {
abRatio = 1
text = {}
0 =
updater = {}
cooldown = ActionButton2Cooldown {}
}
start = 1694057.946
duration = 3

Locals:
self = {
abRatio = 1
text = {}
0 =
updater = {}
cooldown = MultiBarBottomRightButton1Cooldown {}
}
start = 1693360.104
duration = 3

Wierd behavior when parent frame is shown after cooldown is set.

Sometimes when parent frame is shown after the cooldown is modified, OmniCC doesn't display the text.

Considering the following code:
local f = CreateFrame("Frame", nil, UIParent)
f:Hide()
f:SetSize(100, 100)
f:SetPoint("CENTER", 0, 0)
local t = f:CreateTexture()
t:SetAllPoints()
t:SetTexture(GetSpellTexture("Thunderstorm"))
t = CreateFrame("Cooldown", "clctesttimer", f)
t:SetSize(100, 100)
t:SetPoint("CENTER")
f:Show()
CooldownFrame_SetTimer(t, GetSpellCooldown("Thunderstorm"))
If f:Show() is after CooldownFrame_SetTimer, on reloadui while the cooldown is active, sometimes the cooldown text isn't displayed.

The wierd part is that the only difference I noticed between the two situations seems to be due to multithreading issues in Timer:UpdateText(forceStyleUpdate).
The "timeline" when the text isn't displayed would like this:

1 UpdateText is called from UpdateShown
1 ScheduleUpdate is called from UpdateText
1 enter ScheduleUpdate
2 UpdateText is called from cooldown_OnSizeChanged
2 ScheduleUpdate is called from UpdateText
2 enter ScheduleUpdate
2 exit ScheduleUpdate
2 exit UpdateText
1 exit ScheduleUpdate
1 exit UpdateText

Various Errors on fresh installation

Sorry for the long post, I also removed all the "addons" from the error messages, but I posted them at the bottom because they're all the same ones for each error message.

Date: 2012-07-25 00:43:09
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\OmniCC\timer.lua line 35:
attempt to index local 'OmniCC' (a boolean value)
Debug:

OmniCC\timer.lua:35: in main chunk

Date: 2012-07-25 00:43:09
ID: 2
Error occured in: Global
Count: 1
Message: ..\AddOns\OmniCC\aniUpdater.lua line 7:
attempt to index local 'OmniCC' (a boolean value)
Debug:

OmniCC\aniUpdater.lua:7: in main chunk

Date: 2012-07-25 00:43:09
ID: 3
Error occured in: Global
Count: 1
Message: ..\AddOns\OmniCC\classicUpdater.lua line 7:
attempt to index local 'OmniCC' (a boolean value)
Debug:

OmniCC\classicUpdater.lua:7: in main chunk

Date: 2012-07-25 00:43:09
ID: 4
Error occured in: Global
Count: 1
Message: ..\AddOns\OmniCC\effects\alert.lua line 40:
attempt to index global 'OmniCC' (a boolean value)
Debug:

OmniCC\effects\alert.lua:40: in main chunk

Date: 2012-07-25 00:43:09
ID: 5
Error occured in: Global
Count: 1
Message: ..\AddOns\OmniCC\effects\activate.lua line 21:
attempt to index global 'OmniCC' (a boolean value)
Debug:

OmniCC\effects\activate.lua:21: in main chunk

Date: 2012-07-25 00:43:09
ID: 6
Error occured in: Global
Count: 1
Message: ..\AddOns\OmniCC\effects\pulse.lua line 98:
attempt to index global 'OmniCC' (a boolean value)
Debug:

OmniCC\effects\pulse.lua:98: in main chunk

Date: 2012-07-25 00:43:09
ID: 7
Error occured in: Global
Count: 1
Message: ..\AddOns\OmniCC\effects\shine.lua line 106:
attempt to index global 'OmniCC' (a boolean value)
Debug:

OmniCC\effects\shine.lua:106: in main chunk

And the Config panel errors

Date: 2012-07-25 00:45:25
ID: 8
Error occured in: Global
Count: 1
Message: ..\AddOns\OmniCC_Config\mainPanel.lua line 112:
attempt to index global 'OmniCC' (a boolean value)
Debug:

OmniCC_Config\mainPanel.lua:112:
OmniCC_Config\mainPanel.lua:111
OmniCC_Config\mainPanel.lua:146: initFunction()
..\FrameXML\UIDropDownMenu.lua:69: UIDropDownMenu_Initialize()
OmniCC_Config\mainPanel.lua:143:
OmniCC_Config\mainPanel.lua:89
OmniCC_Config\mainPanel.lua:303: optionsPanel_Create()
OmniCC_Config\mainPanel.lua:363: in main chunk