ttgc / ttgcbot Goto Github PK

Describe the bug
Finalize command is using old deprecated time.clock() function wich has been removed since python 3.8, so it's should be replace with time.process_time()

To Reproduce
Steps to reproduce the behavior:

1. Use /vocal on to make the bot join vocal channel
2. Use /finalize on a RP channel
3. Confirm the finalize
4. Observe the error message

Error message

Command raised an exception: AttributeError: module 'time' has no attribute 'clock'

bug on /setMJrole command, doesn't affect new role when used

discord.Forbidden error for missing permissions is raised when the bot try to assign role to a new member for the keeprole system. The bot has the manage role permissions and its highest role is above the role wich is tried to be assigned to the new member. Normally, this shouldn't happened because of the conditions listed above.
Here is the event code :

@client.event
@asyncio.coroutine
def on_member_join(member):
    srv = DBServer(str(member.server.id))
    if srv.keepingrole:
        yield from srv.restorerolemember(client,member.server,member)

and here the code of the method restorerolemember wich try to assign role :

@asyncio.coroutine
    def restorerolemember(self,client,srv,member):
        db = Database()
        cur = db.execute("SELECT id_role FROM keeprole WHERE id_server = %(idserv)s AND id_member = %(idmemb)s;",idserv=self.ID,idmemb=member.id)
        if cur is None:
            db.close(True)
            raise DatabaseException("unable to restore roles of the member")
        ls = []
        for i in cur:
            rl = discord.utils.get(srv.roles,id=i[0])
            ls.append(rl)
            yield from client.add_roles(member,rl)
        for i in ls:
            db.call("restorerolemember",idmemb=member.id,idserv=self.ID,idrole=i.id)
        db.close()

After investigating on this bug, the role stored and got from the database is the good one and the member who will receive the role is the good one too.
PS : full code on the branch ttgc-v1.0-dev

YTDL players have been removed from discord.py rewrite (v1.0 and above). Need to implement a new functionnal youtube player to fit the requirement of playing youtube songs.

Won't be fixed before at least v2.1. Until this issue is closed and player is implemented, youtube play command /play will be disabled