Comments (11)
I guess that I could change mypy_flags
to the empty string and it should work. I am not sure if invoking the tool with arguments by default is the wisest option, since as we have already seen it creates differences between local and repo errors.
from action-mypy.
Thanks report.
I inv. it.
from action-mypy.
Mr @vnmabus ,
Create test branchs.
- with setup.cfg tsuyoshicho/action-test-repo#11
- without setup.cfg tsuyoshicho/action-test-repo#12
Test code as same.
setup.cfg see below:
[mypy]
warn_no_return = False
with setup.cfg test do no report Missing return statement
.
That's fine.
As far as the results are concerned, it reads setup.cfg and works correctly.
Please your action-mypy setting (filter-mode
, mypy_flags
...) to check in workflow what you needed.
from action-mypy.
I still do not get what I am doing wrong.
I have this PR: GAA-UAM/scikit-fda#296
In the setup.cfg I have set the option implicit_reexport
for mypy, and it works locally.
However action-mypy is still reporting Module '...' has no attribute '...'
errors.
The code for the workflow is
name: Mypy
on:
pull_request:
jobs:
build:
runs-on: ubuntu-latest
name: Mypy
steps:
- uses: actions/checkout@v2
- uses: tsuyoshicho/action-mypy@v1
with:
github_token: ${{ secrets.github_token }}
# Change reviewdog reporter if you need [github-pr-check,github-check,github-pr-review].
reporter: github-pr-review
# Change reporter level if you need.
# GitHub Status Check won't become failure with warning.
level: warning
from action-mypy.
Note:
https://mypy.readthedocs.io/en/stable/config_file.html#confval-implicit_reexport
implicit_reexport = True
from action-mypy.
But it IS written like that... The mypy section is
[mypy]
strict = True
strict_equality = True
implicit_reexport = True
from action-mypy.
Thanks, I tried your repo in local... now
from action-mypy.
Tried local, get below:
skfda\representation\_functional_data.py:25:1: error: Module 'skfda._utils' has no attribute '_evaluate_grid'
same as https://github.com/GAA-UAM/scikit-fda/pull/296/files#r546687283
run as mypy --show-column-numbers --strict --strict-equality skfda\_utils\_utils.py
mypy installed global, no-plugin / standalone.
This result seem to be correct.
munnn...
from action-mypy.
I think that I know what is happening here... Your action is calling mypy with flags by default, and the -strict flag takes precedence over the implicit_reexport
in the config.
from action-mypy.
Changing mypy_flags to the empty string seems to work, you can close this if you want.
from action-mypy.
Okay, I understand everything.
- This issue was closed
- Rethink the default arguments.
Regards.
from action-mypy.
Related Issues (20)
- Bug: invalidate setting with arguments
- Action Required: Fix Renovate Configuration
- Type checking with third party packages HOT 9
- local test need pip install
- Dependency Dashboard
- Multiple reviews generated for multiline mypy error HOT 13
- Allow specifying a mypy version HOT 4
- Some mypy errors are ignored HOT 2
- Custom MyPy binary HOT 4
- TODO: Ignore note refactor HOT 1
- Next major release HOT 1
- Running via Poetry doesn't seem to work HOT 10
- Feature request: Multiple targets for mypy HOT 3
- Suggestion: Allow user to choose mypy version manually HOT 3
- Running mypy with reviewdog has no output HOT 5
- Deps are not installed HOT 5
- Bug: something fails during setup, no error occurs.
- "Running mypy with reviewdog 🐶 ..." does not comment and shows no error, despite errors. HOT 4
- one >53 errrors to report, reviewdog aborts GitHubActionLogWriter: "reported too many annotation" HOT 1
- feat: JSON Output support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from action-mypy.