Giter Club home page Giter Club logo

Comments (13)

tsuyoshicho avatar tsuyoshicho commented on July 19, 2024 1

Work in progress...

from action-mypy.

abelcheung avatar abelcheung commented on July 19, 2024 1

Hi,

I have added tsuyoshicho/test-action-mypy#2, but needs your approval to run CI.

For the initial sample error above, mypy can probably hide the note: lines without --show-error-context, therefore this time I created another kind of error that mypy cannot suppress.

from action-mypy.

tsuyoshicho avatar tsuyoshicho commented on July 19, 2024 1

Thanks a lot. (report and PR)

from action-mypy.

abelcheung avatar abelcheung commented on July 19, 2024 1

@tsuyoshicho OK it's done.

from action-mypy.

tsuyoshicho avatar tsuyoshicho commented on July 19, 2024 1

@abelcheung san

With no progress on JSON support, I've introduced a workaround.

You can ignore the notice of note.
Please try setting according to your needs.

Release 3.10.0 https://github.com/tsuyoshicho/action-mypy/releases/tag/v3.10.0
test result for ignore note: tsuyoshicho/action-test-repo#27

This issue remains open.

from action-mypy.

tsuyoshicho avatar tsuyoshicho commented on July 19, 2024

Hi @abelcheung san,

github.com/tsuyoshicho/test-action-mypy/pull/1
Simply reproduction PR

Basically, mypy report only error and work fine it.
If your project mypy.ini report note:, option mypy_flags use to suppress it.

If you have a problem that you haven't set up that way,
I want you to make a minimum reproduction PR and report it here. (like above PR)

from action-mypy.

abelcheung avatar abelcheung commented on July 19, 2024

As an example, following image shows the behavior I want to see -- multiple lines which are related to the same error can be grouped together.

圖片

from action-mypy.

tsuyoshicho avatar tsuyoshicho commented on July 19, 2024

FYI
https://github.com/jordemort/action-pyright
use rdjson format (rich error report support),
mypy json report python/mypy#10816

I will think about it.

from action-mypy.

abelcheung avatar abelcheung commented on July 19, 2024

Ouch, you're right, it is not easy to handle mypy error in its current state. It is fine to put the idea on hold until mypy has done something to improve the situation.

from action-mypy.

tsuyoshicho avatar tsuyoshicho commented on July 19, 2024

tsuyoshicho/action-test-repo#21

Reproduce PR create in my test repo.
This code is same as abel's test code.

@abelcheung san
Your PR are closed
Please remove forked test-action-mypy repository.
This original test-action-mypy repository are other user test repo...Sorry.
I remove my forked repository too.

from action-mypy.

tsuyoshicho avatar tsuyoshicho commented on July 19, 2024

Note:
python/mypy#10816 (comment)

FYI:
Relation File Format information.
reviewdog are diagnostics parsing tool, and that support json file.
https://github.com/reviewdog/reviewdog/tree/master/proto/rdf#rdjson

action-pyright using converted rdjson from original json.

When mypy implements Pyright's format json, converting the json using already existing action-pyright's method will be solved this issue.

from action-mypy.

abelcheung avatar abelcheung commented on July 19, 2024

@tsuyoshicho I have tried the ignore_note setting and it works fine here. It seems mypy developers don't have interest in implementing JSON support, so your workaround is probably the best approach right now.

from action-mypy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.