Comments (1)
Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Unable to edit student ID
The "edit student" command of the app does not provide a functionality to edit student ID. Thus if the user made a typo in student ID and later discovered it, the user must delete the student entirely, and add a new student with the correct ID. This forces the user to re-type all student information including name, email and tele handle, even if they are all correct in the original student.
Suggestion: I understand that ID is used to identify a student, but the problem is this implementation does not allow the editing of ID itself. Perhaps you can identify students by their index number listed in the mod. In this way, identification is not dependent on any editable data.
"edit student" command does not provide functionality to edit student ID, according to UG
[original: nus-cs2103-AY2122S1/pe-interim#5185] [original labels: type.FeatureFlaw severity.Medium]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Student ID is being used as an identifier hence it is crucial in keeping the identity of the student separate. Student ID is meant to be uneditable.
Items for the Tester to Verify
❓ Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- I disagree
Reason for disagreement: My bug is not a duplicate of the other bug as these 2 bugs must be fixed independently. In my case, the issue is about the edit student command accepting unnecessarily long and complicated parameters (student ID) when just a simple list index would suffice. The student ID being uneditable has no relation to my reported bug.
❓ Issue response
Team chose [response.Rejected
]
- I disagree
Reason for disagreement: Unlogical that student ID is a parameter when a list index would suffice. The student ID is numerical and long, thus prone to typos So, in this case, the team should instead use the list index for their commands.
And also, the team mentioned that "students with the same IDs but are in different classes are different identities", there's a very huge contradiction here since the students with the same IDs are treated as different when the team mentioned in the UG that "Student ID is being used as an identifier hence it is crucial in keeping the identity of the student separate"?
I feel that this is quite a huge design flaw and since most of their commands use the student ID as a parameter, it would affect the user-friendliness of the app if not corrected.
❓ Issue severity
Team chose [severity.Medium
]
Originally [severity.Low
]
- I disagree
Reason for disagreement: [replace this with your explanation]
from pe.
Related Issues (15)
- [TEST] UI bug
- Task ID not clear on UI HOT 1
- Mismatch between format of commands in app and UG HOT 1
- Mark task command marks all task under student as done HOT 1
- Unmark task not working as expected HOT 1
- mark undone marks all task as undone HOT 1
- Screenshots in delete module not self explanatory HOT 1
- Messy formatting under Features HOT 1
- Image does not match example in mark undone HOT 1
- Screenshots under edit task not sufficient to show edits HOT 1
- Unclear which example command is being executed in the images HOT 1
- No purpose of DG and intro to app in DG HOT 1
- No end of lifeline for several sequence diagrams in DG HOT 1
- No explanation of what the markdown, bold, and italics mean in DG and UG HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pe.