tsche / repr Goto Github PK

it's heavily templated anyway

Tracking this here so it doesn't get lost

@TheNitesWhoSay noted

aggregate counter was disabling intellisense (at least in vs2019), my two fixes - if they interest you - were to take the default param off of minus (which killed intellisense regardless of whether the code was used at all), and return a 0-count if in intellisense (which helps avoid killing it if the code is used)
https://github.com/Tsche/repr/blob/master/include/librepr/reflection/detail/arity.h

  static consteval auto arity(std::size_t minus = 0, auto... parameters) {
  // regular content
  }

  static consteval auto arity(std::size_t minus, auto... parameters) {
    #ifdef __INTELLISENSE__
    return minus;
    #else
    // regular content
    #endif
  }

magic_enum does too much for our use case. This dependency should be gotten rid of - implementing the required parts of it should not be very difficult.

this project is licensed under MIT - there should be a LICENSE.md in this project's root folder containing a copy of the MIT license

simple binary serialization for benchmarking and json comes to mind

We should provide some usage examples. Currently the only examples are the unit tests and benchmarks - we cannot expect people to be able to know GTest or dig through code written for benchmarking.

This project is lacking documentation. We need to decide which tool to use for this - possibly Doxygen and/or sphinx.

The resulting html render can be published through GH pages. My domains palliate.dev and palliate.io are reusable for this (possibly with a subdomain?) but I can also just register a new domain if you can think of a good available one

It should be possible to disable specific library features using preprocessor defines.

ie if you want to provide your own variant-like reflection or simply don't want that feature you should be able to get rid of the builtin librepr::Reflect specialization by setting #define REPR_REFLECT_VARIANT OFF.

librepr is now a header only. The conan install instructions should be updated accordingly, also magic_enum needs to be made an optional dependency in the conanfile.

Once amalgamation is automated in CI there should also be instructions on how to use the amalgamated header instead.
We meed to decide how and where to distribute it though. I'd suggest using this repository's wiki (can be cloned using git clone [email protected]:Tsche/repr.wiki.git) and additionally the normal documentation deployment route once that's set up.