Giter Club home page Giter Club logo

Comments (5)

tsattler avatar tsattler commented on August 28, 2024

We used different implementations for different methods. For Active Search, we used the P3P implementation from the examples of the RansacLib library.

from visloc_pseudo_gt_limitations.

ebrach avatar ebrach commented on August 28, 2024

DSAC* uses OpenCVs P3P as a minimal solver, and OpenCVs "iterative" (that is Levenberg-Marquardt) for refinement on all inliers. Despite using OpenCVs solvers, DSAC* does not use OpenCVs RANSAC implementation, but a custom one. Not sure what solvePNPRansac does exactly. Worth checking what solvers it uses in your case, and whether it refines the estimate on all inliers. The OpenCV docs seem to say that EPNP is used by default as a minimal solver, and "iterative" as refinement. I had mixed experiences with EPNP - I found P3P to work much better in my experiments. (But not clear what solvePNPRansac does if you specify P3P as a solver flag - whether it still refines using "iterative" or not. Better check.)

from visloc_pseudo_gt_limitations.

sontung avatar sontung commented on August 28, 2024

I was using opencv's SQ-PNP to be exact. With this I was able to get around 96% on RedKitchen from 7scenes, however, in many bad cases, my matches are good enough. I just tried with lambda-twist pnp. With proper parameters, I was able to get 98.5%, however, the curve is not as good as the ones from other High performance algorithms. It seems to me that different PnP algorithms or implementations provide slightly different results. Is it possible that we make one default PnP solver for all the algorithms or take into account the accuracy of the matches? To analyze the accuracy of the matches, we can project 3d points using GT poses and then compute the difference between matched 2d points and projected 2d points.

from visloc_pseudo_gt_limitations.

tsattler avatar tsattler commented on August 28, 2024

In my experience, doing proper local optimization can make quite a difference (including whether or not to use a robust cost function). I recommend using the pose estimation implementation in PoseLib (https://github.com/vlarsson/PoseLib).

from visloc_pseudo_gt_limitations.

sontung avatar sontung commented on August 28, 2024

I just tried PoseLib and it seemed to solve my problem. Thanks!

from visloc_pseudo_gt_limitations.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.