trwnh / mastomods Goto Github PK

Using the tutorial in this link https://github.com/trwnh/mastomods/blob/main/tutorials/limits.md, I updated the following files.

• /public_html/live/app/validators/status_length_validator.rb
• app/javascript/mastodon/features/compose/components/compose_form.js

I then ran docker-compose restart.

Output:

Restarting live_streaming_1 ... done
Restarting live_web_1       ... done
Restarting live_sidekiq_1   ... done
Restarting live_redis_1     ... done
Restarting live_db_1        ... done

However, the changes are are not being reflected on my site. What else do I need to do? Anything I'm missing?
I'm on the latest version.

• follows and followers
• simple mode
• .reply-indicator__content a.unhandled-link, .status__content a.unhandled-link needs color: accent
• .drawer__inner, .drawer__inner__mastodon need background: bgPage
• .getting-started__footer p need color: textPageMuted
• .getting-started__footer a needs color: accent

need to find what was added/changed in 3.0 as well

• new profile directory
• new mute dialog
• regression in settings page background
• account migration / alias?
• new dm conversation component
• maybe refactor search sidebar a bit? it looks a bit dated and inconsistent...
• unhandled links from non-mastodon users don't have correct accent color .reply-indicator__content a.unhandled-link, .status__content a.unhandled-link
• modal menu that sometimes appears instead of popout (idk how to trigger it though?)

Upstream has changed their boost icon. If you are planning to match upstream updates the following information might be helpful:

1. Boost icon for private toots that cannot be boosted
   tootsuite#14373
2. Boost icon for private toots that can be boosted (which means you are the author and you can boost to your audiences)
   tootsuite#14380
   tootsuite#14386

If the themes were created as tagged feature branches of a mastodon fork this would:

• allow people to add them to their installs
• allow people to collaborate with you on them

thanks

I am trying to fix the code so that it can keep up with changes from Mastodon upstream.
However, there are some difficult problems that I don't know how to resolve.
This is one of the weird bugs.

Steps to reproduce

Click the star button to favourite. Then click it again to deactive. It will remain as "active", until the user click anywhere in the column area.

Reproducible on Firefox and Chrome

Hello, I didn't see this issue raised before, and thought I'd throw it out there as I wasn't able to find a fix for it just yet. We love your mods, but this small issue was brought up and verified on our instance (as well as a friend's instance also using his own theme, which is just a modded linernotes_dark).

Any idea why this might be occurring or if there is a workaround or solution?

TIA for any assistance. It's greatly appreciated.

Some of features still missing themes:

List adder

(You can ignore the subscribe button. It's not in vanilla version of mastodon.)
DId you intentionally leave the color unchanged? Well I think it's fine.

Log entries

In the admin section.

Dashboard counters

In the admin section.

Accouncement

In the admin section.

Screenshot

Steps to reproduce

This bug exists not only on midnight-blue, but also in many other themes, such as Linernotes Dark.

1. Open Firefox/Chrome, switch to mobile view
2. Force refresh the page, click the "..." button next to any status
3. You will see the screenshot

Note that on desktop mode, clicking the "..." button will not trigger status action modal. A normal actions menu will be shown instead.

The .tab_bar is hidden on a mobile device. (For example, on a linernotes_dark theme).
Users can no longer see the tab bar.
Did you intentionally hide them, or it's because of conflict with upstream changes?

I followed the instructions in the readme.

/home/mastodon/live$ grep linernotes config/locales/en.yml 
    linernotes_dark: Liner Notes (Dark)

/home/mastodon/live$ cat config/themes.yml 
default: styles/application.scss
contrast: styles/contrast.scss
mastodon-light: styles/mastodon-light.scss
linernotes_dark: styles/linernotes_dark.scss

/home/mastodon/live$ ls -R app/javascript/styles/
app/javascript/styles/:
application.scss  fonts                 mailer.scss     mastodon-light.scss
contrast          linernotes_dark       mastodon        mfc
contrast.scss     linernotes_dark.scss  mastodon-light  mods

app/javascript/styles/contrast:
diff.scss  variables.scss

app/javascript/styles/fonts:
montserrat.scss  roboto-mono.scss  roboto.scss

app/javascript/styles/linernotes_dark:
overrides.scss  palette.scss

app/javascript/styles/mastodon:
_mixins.scss        boost.scss           footer.scss        reset.scss
about.scss          compact_header.scss  forms.scss         rtl.scss
accessibility.scss  components.scss      introduction.scss  stream_entries.scss
accounts.scss       containers.scss      lists.scss         tables.scss
admin.scss          dashboard.scss       modal.scss         variables.scss
basics.scss         emoji_picker.scss    polls.scss         widgets.scss

app/javascript/styles/mastodon-light:
diff.scss  variables.scss

app/javascript/styles/mfc:
0-palette.css     2-background.css  4-fixes.css     6-actions.css      variables.scss
1-foreground.css  3-highlights.css  5-material.css  mastodonFlat.scss

app/javascript/styles/mods:
deprecated                         display_transparentmedia.css
display_breakname.css              layout_1600px.css
display_browserfont.css            layout_elefriend.css
display_circleavatar.css           layout_gettingstartedheight.css
display_collapsedinteractions.css  layout_hidedisabled.css
display_emojizoom.css              layout_hidefiltered.css
display_fadedinteractions.css      layout_mobile_bottombar.css
display_fullmedia.css              layout_singlecolumn.css
display_fullname.css               layout_widercolumns.css
display_hidereplycounts.css        test_colorizedlogo.css
display_starstohearts.css

app/javascript/styles/mods/deprecated:
display_bettersearch.css

/home/mastodon/live$ RAILS_ENV=production bundle exec rails assets:precompile --verbose
yarn install v1.19.0
[1/6] Validating package.json...
[2/6] Resolving packages...
success Already up-to-date.
Done in 3.65s.
Compiling…
^C# terminated with exception (report_on_exception is true):
Traceback (most recent call last):
        1: from /home/mastodon/.rbenv/versions/2.6.1/lib/ruby/2.6.0/open3.rb:287:in `block (2 levels) in capture3'
/home/mastodon/.rbenv/versions/2.6.1/lib/ruby/2.6.0/open3.rb:287:in `read': stream closed in another thread (IOError)
# terminated with exception (report_on_exception is true):
Traceback (most recent call last):
        1: from /home/mastodon/.rbenv/versions/2.6.1/lib/ruby/2.6.0/open3.rb:288:in `block (2 levels) in capture3'
/home/mastodon/.rbenv/versions/2.6.1/lib/ruby/2.6.0/open3.rb:288:in `read': stream closed in another thread (IOError)
rails aborted!
Interrupt: 
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/webpacker-4.0.7/lib/webpacker/compiler.rb:61:in `run_webpack'
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/webpacker-4.0.7/lib/webpacker/compiler.rb:21:in `compile'
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/webpacker-4.0.7/lib/webpacker/commands.rb:18:in `compile'
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/webpacker-4.0.7/lib/webpacker.rb:27:in `compile'
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/webpacker-4.0.7/lib/tasks/webpacker/compile.rake:31:in `block (4 levels) in '
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/webpacker-4.0.7/lib/tasks/webpacker/compile.rake:6:in `ensure_log_goes_to_stdout'
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/webpacker-4.0.7/lib/tasks/webpacker/compile.rake:30:in `block (3 levels) in '
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/webpacker-4.0.7/lib/webpacker.rb:20:in `with_node_env'
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/webpacker-4.0.7/lib/tasks/webpacker/compile.rake:29:in `block (2 levels) in '
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/webpacker-4.0.7/lib/tasks/webpacker/compile.rake:22:in `block in enhance_assets_precompile'
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/commands/rake/rake_command.rb:23:in `block in perform'
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/commands/rake/rake_command.rb:20:in `perform'
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/command.rb:48:in `invoke'
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/commands.rb:18:in `'
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `require'
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `block in require_with_bootsnap_lfi'
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/loaded_features_index.rb:92:in `register'
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:21:in `require_with_bootsnap_lfi'
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `block in require'
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:257:in `load_dependency'
/home/mastodon/live/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `require'
bin/rails:4:in `'
Tasks: TOP => webpacker:compile
(See full trace by running task with --trace)