trustwallet / go-libs Goto Github PK

cl := InitClient("someapi.com", ...)

func someHttpHandler(params) {
   // currently you can do the following but it will affect other processes that use the same client
   cl.SetHeader("some-key", params["some-value"])
   cl.Get(...)

   // we could do something like this
   cl.NewRequest("GET").WithHeader("some-key", params["some-value"]).Do(...)
}

https://github.com/trustwallet/go-libs/tree/master/client

https://developer.trustwallet.com/add_new_asset/universal_asset_id

Existing mq health check can be improved, so it checks more then connection state.

Possible approach:

func checkChannelHealth(channel *amqp.Channel) {
	_, err := channel.ExchangeDeclarePassive(
		"healthcheck", // name
		"direct",      // type
		true,          // durable
		false,         // auto-deleted
		false,         // internal
		false,         // no-wait
		nil,           // arguments
	)
	if err != nil {
		fmt.Println("Channel is not healthy:", err)
	} else {
		fmt.Println("Channel is healthy")
	}
}

For mq producer implement next logic:

1. publish attempt returns error.
2. check if the error is connection-related.
3. try to reconnect for 5 times with increasing of the timeout

Types to support:

• Coin transfers
• Token transfers
• Swaps (from to asset)
• Staking (delegations / undelegations), claim rewards, vote ... redelegating
• Smart contract calls (deposit, claim) - function name + values, raw data
• Pre build actions. Approve asset 1.
• Collectibles Transfers
• Governance Vote #1 Yes/No.
• DEX (New, Cancel, Execute, Fill)

Small use cases:

• Lending (Borrow n AAVE, Lend 20 COMP, MINT 102 SPX)
• Provide liquidity pool ETH<>DAI
• Deposit funds to L2 network (could live in smart contract)

Discussion points

• How to support any action format?
• How to localize?
• How to add new events and stay compatible?

Additional support for:

• transactions types
• offset and limit - (pagination)
• timestamp
• versioning

/transactions?types=transfer|token_transfer&from_timestamp=123&version=3&page=1&limit=10

Old Coin Transfer:

{
   "id":"0x05a9c7b75f57d7489dc143eb51600315439a324cdc2f749a27b99d7d395a7fe5",
   "coin":10000714,
   "from":"0x4982085C9e2F89F2eCb8131Eca71aFAD896e89CB",
   "to":"0x377E196Acd9215A881fc101A64AAa6CA0b0a75D6",
   "fee":"441000000000000",
   "date":1611012545,
   "block":4110960,
   "status":"completed",
   "sequence":12604,
   "type":"transfer",
   "direction":"outgoing",
   "memo":"",
   "metadata":{
      "value":"2000000000000000",
      "symbol":"BNB",
      "decimals":18
   }
}

New Coin Transfer Format:

{
   "id":"0x05a9c7b75f57d7489dc143eb51600315439a324cdc2f749a27b99d7d395a7fe5",
   "asset_id":"c714",
   "from":"0x4982085C9e2F89F2eCb8131Eca71aFAD896e89CB",
   "to":"0x377E196Acd9215A881fc101A64AAa6CA0b0a75D6",
   "fee": {
        "asset": "c714_cTWT",
        "value": "441000000000000"
    },
   "date":1611012545,
   "block":4110960,
   "status":"completed",
   "sequence":12604,
   "direction":"outgoing",
   "memo":"",
}

   "transfers": [{
       "from":"0x4982085C9e2F89F2eCb8131Eca71aFAD896e89CB",
       "to":"0x377E196Acd9215A881fc101A64AAa6CA0b0a75D6",
       "asset": "c714",
       "value":"2000000000000000",
   }]
  "swaps": [{
          "from": {
              "address": "0x4982085C9e2F89F2eCb8131Eca71aFAD896e89CB"
               "asset": "c714"
              "value":"2000000000000000",
          },
          "to": {
               "address": "0x377E196Acd9215A881fc101A64AAa6CA0b0a75D6"
               "asset": "c714"
              "value":"2000000000000000",
          }
   }],
   "smart_contract_call": {

   }

status: pending, completed, error

https://github.com/trustwallet/blockatlas/blob/c8cfdc251c291fa59719a907a7391c99b6d94e20/pubsub/mqclient/mq_client.go#L106-L111

This issue was generated by todo based on a TODO comment in c8cfdc251c291fa59719a907a7391c99b6d94e20. It's been assigned to @madcake because they committed the code.

Re-use this code

There are a lot of lines with hardcoded URLs like

func (c Client) FetchMarketPairs(limit int) (pairs []MarketPair, err error) {
params := url.Values{"limit": {strconv.Itoa(limit)}}
err = c.req.Get(&pairs, "/api/v1/markets", params)
return pairs, err
}

What if we move it out from these methods and place in config file, so it would be easier to track and change it in future

https://github.com/trustwallet/golibs/blob/master/network/middleware/sentry.go#L12 - it would be great to have ability to pass specific options, like sample rate and so on

https://github.com/trustwallet/blockatlas/blob/c8cfdc251c291fa59719a907a7391c99b6d94e20/pubsub/mqclient/mq_client.go#L110-L115

This issue was generated by todo based on a todo comment in c8cfdc251c291fa59719a907a7391c99b6d94e20. It's been assigned to @madcake because they committed the code.

Currently we has a preferredSymbol to work around it

The library we are using for rabbitmq is not maintained any longer streadway/amqp#500 (comment) We should consider switching to https://github.com/rabbitmq/amqp091-go It has some useful features, like PublishWithContext()

Make labels var optional so it doesn't require passing nil.
https://github.com/trustwallet/go-libs/blob/master/metrics/metrics.go#L32

Add AssetID() func to coin

https://github.com/trustwallet/golibs/blob/master/coin/coins.go

Ideally we should include all coins from here: https://github.com/trustwallet/wallet-core/blob/master/coins.json

When a consumer has MaxRetries set and this was the final retry, also log the message on error.