trulabs / puppet-asterisk Goto Github PK

Modulefile is deprecated, and metadata.json needs to be reviewed, in particular for OS dependencies.

At the moment the configuration files used are "borrowed" from the 1.8 files available on debian wheezy. There are several changes on Asterisk 11 that should be taken into account.

The parameter for concat::fragment should reference $target, not $title, just in case someone passes in target => 'somepath'. Patch coming.

It would be nice if the module would be able to manage voicemail boxes too.
Is there interest? I'd look into it, provide a patch.

I'd keep it simple but enhanceable, initially only supporting my use-case,
i.e. being able to configure voicemail boxes, and sending out
mails informing the owner of the boxes. Storing them in imap, etc.
I'd leave that for others ;)
I'd take a similar route like the other parts of the module are
managed. Just using easy template to configure the stuff.

The use of Concat { ensure => present } is broken in Puppet
3.2.4. Essentially, it was included to be pedantic. Removing.

It would be nice, if the module could handle/configure IAX devices, similar to sip devices.

I use an IAX softphone client, and it would be nice, if I could manage it with the puppet module.
Should the manifests/config/device.pp just enhanced, to support iax devices too? Just add the missing
parameters. And then in manifests/config.pp take care of managing the iax.conf file too?

Or create a standalone manifests/config/iaxdevice.pp file in order do do that?

Either way, let me know and I can go on implementing it.

cheers,
Sebastian

This is the overview from the quality score:

Optional parameter listed before required parameter - 2 occurrences.
Double quoted string containing no variables - 4 occurrences.
Indentation of => is not properly aligned - 2 occurrences.
Line has more than 80 characters - 37 occurrences.

Time to nail 'em (before 0.0.6, I'd say).