tripviss / image-resizer Goto Github PK

My NODE_ENV was set to "dev" and thus produced a not-so-obvious error in heroku

Error: Cannot find module './src/config/dev'

^ that did not mean too much to me initially.

The stack trace was even less informative then that. I suggest a try catch with a message about what valid values the NODE_ENV can be set to... and perhaps it could default to using the development.js file with a warning if no matching file can be found.

Thanks!

I've edit the environment to include

EXTERNAL_SOURCE_VF='http://www.cfmedia.vfmleonardo.com/'

However, whenever I try loading an image, i got 500 error, The specified key does not exist. (looks like the original is on cloudfront/s3).

mydomain.com/evf/imageRepo/4/0/55/359/440/ROY.44A_H.jpg

Example of said image url: http://www.cfmedia.vfmleonardo.com/imageRepo/4/0/55/359/440/ROY.44A_H.jpg

I do not have control over this image / url.

Sharp returns a "Bad extract area" when extracting "out of bounds" portions of images. This means that requesting a bad cut makes the server return a 500 code. This is not really ideal for a production environment.

Wouldn't it be better to simply return a sensible default (like ignoring the crop or switching to a different crop mode) while issuing a 400 (as in a "Bad request" was made)?

e.g. https://lh4.googleusercontent.com/-P4oxiHniRcc/V1Q0kGaDVMI/AAAAAAAAS44/JV4M46DxtWc54Rjb1pv2i29CACoUmS_6QCLIB/w4000-h3000-k/

There is no way to specify the output format since the current parsing requires the input format extension before it (e.g. .jpg.webp).

A path like http://my.cdn.com/h-w/path/to/image.png will crash the app. It should send the original image size, or an error but no crash the app.

Thanks for this fork! It's great!

Is there an easy way to set an external source (public read only access to an Azure blob storage location in my case) as the DEFAULT_SOURCE?

I currently have have an environment EXTERNAL_SOURCE_FOO = "https://mylocation.blob.core.windows.net" and this works great but that means I would need to append efoo at the front of every url like http://localhost/efoo/path/to/my/photo.png

I tried modify DEFAULT_SOURCE = S3 to DEFAULT_SOURCE = FOO but visiting http://localhost/path/to/my/photo.png doesn't work

Is it possible to disable logging?

Hey @teohhanhui,

Good job on this fork ! It looks like https://github.com/jimmynicol/image-resizer isn't maintained anymore..
I just wanted to get some feedback from you about this library, are you using it in production ?
Any issue known about using it ?
I'm still wondering if I should use on the fly resize with image-resizer or use AWS lambda to automatically convert my images.

Would appreciate some of your wisdom :)

Thanks

When i'm trying to deploy on heroku i'm getting like

Application error

what is problem please help me

Trying to convert the following image to JPG will send back a completely black image.

I'm tempted to add something like the following in image.js. Any advice?

if (image.outputFormat === 'jpeg') {
      r.background('#FFFFFF').flatten();
    }

The bug:
A call to http://<url>/some/path/cistf72.jpg works fine.
A call to http://<url>/cistf72.jpg does not.

Some investigating revealed that the parse method in modifiers.js calls parseModifiers even when no path is provided. Since the first letter of the filename above is a modifier, it will set the hasModStr variable to true, which in turn cases trouble in image.js.

The end result is that images that (1) are in the root path and (2) start with a filename w/modifier string can never be retrieved by original.

Just wondering if this should be working or not but I've added a 404 picture that I'd like to return in the requested size.

Should that technically be working as I only receive my original size.

Would be great if that would work!

Because we're stripping all meta data, it would be a good idea to rotate the image to correct orientation before stripping it, wouldn't it?

It would be very useful to be able to set the user-agent for external sources. Since image-resizer doesn't forward the query parameters and it's best used on Heroku (where there is no fix IP), it's not easy to know on the origin "who" called and make the difference between legitimate and non legitimate calls for example.

SOMETHING.png.webp ends up fetching something.png from the source.

Fixed by this preliminary patch: beijaflor-io@73c489f

I have an image which is jpg but somehow when i use external source to resize it, I got Unsupported output format "gif"

The image url is

http://pix3.agoda.net/hotelimages/694/69405/69405_14040308360018949836.jpg?s=312x

env EXTERNAL_SOURCE_TEST='http://pix3.agoda.net and access it via

example.com/etest/hotelimages/694/69405/69405_14040308360018949836.jpg?s=312x

e.g. https://avatars2.githubusercontent.com/u/548843?v=3&s=96

The query string is not passed on to the source, as the source url is not properly URL-encoded.

Fixing this would introduce a BC break. (We cannot just blindly perform URL decode, as we risk double decoding...) Should the requirement to URL encode be applied to all sources, or should it be configurable per source?