Giter Club home page Giter Club logo

gtc-expansion's Introduction

NOTICE : THIS MOD IS DEAD, AND I HAVE NO PLANS TO FIX ANY ISSUES. USE AT YOUR OWN RISK.

UPDATE: THERE IS NEW PROJECT KEEPING THIS MOD ALIVE NOW, CHECK IT OUT HERE

GTC Expansion

About

GTC Expansion is an addon to GT Classic adding various machines and such. currently it aims to make gtclassic more like gt4, but I will add other things.

Current State

I am currently creating the mod. I would say it's 70% - 80% finished. You can find betas on curseforge.

Issues

Please report any issues you find to the issue tracker on this repository. Include as much information as possible including as version and steps to reproduce. Also pleaseuse the included formats.

Contribution

Please do! Fork away and PR all you like. I just ask that you attempt you integrate your code properly into the existing codebase.

gtc-expansion's People

Contributors

dbpgaming avatar trinsdar avatar yurannnzzz avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

gtc-expansion's Issues

Double Ram usage in large modpack with Version 0.1.2

Description of the Bug
I have a rather large Modpack that I have put together, and when running version 0.1.2 of GTC-E it causes both the server and client instance to use almost the entire 8gb of ram allocated to the instance. When I roll back to 0.1.1 it is reduced to half the memory usage. I'm not sure this is a bug or if this is just due to the larger amount of items included in 0.1.2

To Reproduce

Load the Modpack I have with 0.1.2 enabled. Run the instance and watch ram usage stay very high.

Expected behavior
I expect it to not us as much ram.

Screenshots & Video
With version 0.1.1 loaded:
https://i.imgur.com/hHteLMW.png
With version 0.1.2 loaded:
https://i.imgur.com/sLsiD6v.png
Modpack List(Best way I could think to do it):
https://puu.sh/Gmmn6/66c55b6efe.png

Logs & Environment
I only have the latest.log files. I have added these below. Since they are over 512kb both Github and pastebin didn't like them. So I have uploaded them as text documents to my website.

Additional context
If these are the wrong log files, please let me know. I will get the correct ones.

Chromite never spawn due to missing worldgen entry

I legit excavated two 256x256 areas using quarry to only find this

if (world.provider.getDimensionType().equals(DimensionType.THE_END)){
GTOreGenerator.generateBasicVein(GTCXBlocks.oreTungstate, GTCXConfiguration.generation.tungstateGenerate, GTCXConfiguration.generation.tungstateSize, GTCXConfiguration.generation.tungstateWeight, 0, 80, Blocks.END_STONE, world, random, chunkX, chunkZ);
GTOreGenerator.generateBasicVein(GTCXBlocks.oreSheldonite, GTCXConfiguration.generation.sheldoniteGenerate, GTCXConfiguration.generation.sheldoniteSize, GTCXConfiguration.generation.sheldoniteWeight, 0, 80, Blocks.END_STONE, world, random, chunkX, chunkZ);
GTOreGenerator.generateBasicVein(GTCXBlocks.oreOlivine, GTCXConfiguration.generation.olivineGenerate, GTCXConfiguration.generation.olivineSize, GTCXConfiguration.generation.olivineWeight, 0, 80, Blocks.END_STONE, world, random, chunkX, chunkZ);
GTOreGenerator.generateBasicVein(GTCXBlocks.oreSodalite, GTCXConfiguration.generation.sodaliteGenerate, GTCXConfiguration.generation.sodaliteSize, GTCXConfiguration.generation.sodaliteWeight, 0, 80, Blocks.END_STONE, world, random, chunkX, chunkZ);
}

Now chromite search will haunt me in my dreams

Axes' attack speed is too high

6.5 for Flint Axe and up to 14 with Tungstensteel Axe, isn't that a bit too OP?

Here's the vanilla diamond axe for comparison:

Strange behavior of Chemical Reactor with empty Fluid Tubes

Description of the Bug
Sulfuric Acid recipe lists two tubes of water and one empty tube in it's NEI recipe. But reactor only checks for the first two tubes and third one can be with any fluid in it.

To Reproduce

  1. Open chemical reactor
  2. Place 1 sulfur dust, two tubes with water and third tube with any liquid in it
  3. Watch as chemical reactor processes the recipe as usual

Expected behavior
Empty cells should be checked if they're actually empty?

Screenshots & Video
javaw_2020-06-03_01-57-25
javaw_2020-06-03_01-57-39
javaw_2020-06-03_01-57-47
javaw_2020-06-03_01-57-55

Logs & Environment
GTC: 1.1.4, GTCX: 0.1.1

NullPointerException with Hwyla and some machines

Description of the Bug
After I install Hwyla game will crash when I look at Distillation Tower and Fluid castor

To Reproduce

  1. run this mod with hwyla
  2. looking at Distillation Tower or some block from GTCX have fluid container that placed in the world
  3. game crashed

Expected behavior

Screenshots & Video

Logs & Environment

  • Full log: I think we don't need this..?

Additional context

I found a similar issue here it maybe helpful

mekanism compat

Is your feature request related to a problem? Please describe.
in gt4 there was mekanism compat for ore processing, it's just kinda annoying that it's not here

Describe the solution you'd like

Additional context
you can use theis oredict to not have to hard dep mekanism, but still have the centrifuge compat, there isn't a enriched iron oredict, so that would probably have to hard dep

  • dustDirtyMaterial (material being whatever material say iron) for the dirty dust centrifuging

Diamond dust recipe from diamonds is not registered in the macerator.

Description of the Bug
Diamonds do not have their recipes registered in the macerator.

To Reproduce

  1. Place Macerator and power it
  2. Try to put diamonds in it
  3. Observe the inability to do so

Expected behavior
Ability to make diamond dust from diamonds directly rather than diamond blocks, just like in GT2 and GT3.

Screenshots & Video
The only available recipes for diamond dust:
изображение
Diamond dust recipes available in GT2:
изображение
Same diamond dust recipes in GT3:
изображение

Logs & Environment

Additional context
Forge: 14.23.5.2847
IC2Classic: 1.12-1.5.4.5
GT Classic: 1.1.4
GTC Expansion: 0.1.1

Recipes that have become dust in the wind

Missing Recipes

  • Charcoal Pile Igniter, same recipe as GTC just plateRefinedIron, dont use steel mode because i dont want this gated by steel

  • Remove the TForest stuff for the disassembler, just make it the regular recipe all the time

  • Tesseract Generator is wrong, the generator should use the energy circuits while the terminal uses the data circuits, everything else is right.

  • Battery block should use plates not ingots, ive disabled my recipe in the next version so just add yours

  • Digital Chest no longer needs shulker stuff just more of the data storage circuits

  • New Type Filter Block, same as GTC but just with plates instead of ingots

  • Energy Flow Circuit crafting recipe missing, should be GT4 not like GTC using 2 Tungsten plates and 2 lapotrons instead of 4 lapotrons

  • Superconductor Item recipe missing, should be same as mine/GT4 but Tungsten plate instead of ingot

  • Magnifying Glass recipe missing, should be anyIronRod + glass pane in diagonal like GTC

  • Spring boots should take stickRefinedIron() or rodRefinedIron() (one that checks for steel mode) and use some sort of tool to craft like a hammer? Removed my recipe in the next update if GTCX is loaded

  • Destructo Pack should use plates instead of ingots, removed my recipe if your mod is loaded next updated

  • Electromagnet is missing recipe, should be same recipe as GTC but stickRefinedIron() or rodRefinedIron() (one that checks for steel mode) instead of ingots

  • Cloaking device recipe missing, should be same as GTC but all plates

  • Tesla Staff recipe Missing, same recipe as GTC but use rodIridium/stickIridium instead of plates

  • Sensor Stick recipe missing, should be an ic2c memory stick + frequency transmitter and like 3000Eu in an assembler to make.

  • Solid Super Fuel recipes missing, you can do the regular one in the chem reactor, and then just make the magic one require the regular one to fit the recipe.

Recipe Issues

  • Basic circuits overly populated for materials, and overlaps exists, my suggestion is for crafting only allow refinediron/steelmode plates and silver plates (because you can use galena and pbf etc),
  • plateElectric as an input in the assembler is causing recipe overlaps i suggest just making it plateRefinedIron vs plateSteel ,plateAluminium,plateSilver and thats it
  • I also suggest making any multi input recipe object having a limit of 2-3 maximum to make progression clearer

[Bug] GUI Bug

Found a small bug with Assembling Machine.
When you put some upgrades in the first upper slot, it appears also in "battery slot" as if they copy each other. The second slot below works as intended.

GTC_E: 0.0.3.

GUI

Fluid drops as an itemstack from Gas Turbine ()

Description of the Bug
Hello, we have found an issue which is fully demonstrated in video

To Reproduce

  1. Place gas turbine
  2. Fill it with hydrogen
  3. Destroy turbine

Expected behavior
I think removing the liquid is ok, because it is a gas

Screenshots & Video
We have created a video for you link

Logs & Environment
There are no errors in logs, but if you need to check mods in modpack feel free to ask me in comment (I just dont have much time right now)
Environment: Both windows 10 singleplayer and spongeforge server debian 10

  • Crash report (If available):
    no crash

Connected textures for machine casings?

Is your feature request related to a problem? Please describe.
GT2 to GT4 had these neat connected textures for machine casings and (iridium reinforced) tungstensteel blocks. Upcoming boiler's face textures will look way better with them.

Describe the solution you'd like
Connected texture for machine casings and iridium reinforced tungstensteel block just like in GT2-GT4 (as well as texture override for tungstensteel block if possible)
2020-04-23_08 20 08

Additional context
CTM doesn't work with IC2C's sprite replacement system so i don't think it's possible to replicate them with resource packs or in any other way outside the mod's code.

[1.12.2] Fluid dupe via fluid caster

Description of the Bug
Hello, it seems that import upgrade ignores NBT of input items in your machine (fluid caster) or something. We have created the video for you to see it clearly.

To Reproduce
In video

Expected behavior
Do not import tubes

Video
https://www.youtube.com/watch?v=uqYz4tcIqck

Logs & Environment
Feel free to ask me if necessary

  • Full log:
    no errors in log on server side

  • Crash report (If available):
    no crash

IC2C Extras recipes compat issues

Description of the Bug
Only LV machines from IC2CE (except 1 which doesn't!) has recipe overrides with oredicted machine blocks.

Expected behavior
All machines from IC2CE having recipe overrides with oredicted machine blocks.

Screenshots & Video
javaw_2020-05-30_19-53-35
javaw_2020-05-30_20-02-02
javaw_2020-05-30_20-02-07

Logs & Environment
IC2C 1.12-1.5.4.5
IC2CExtras 1.4.4.12
GTClassic 1.1.4
GTCExpansion 0.1.1

Additional context
This actually could be handled in IC2CE itself, by checking the existence of machine blocks OD values.

Some recipe requests to be less dependant on IC2CE, and some random requests

Is your feature request related to a problem? Please describe.
part of these requests are to deal with playing without IC2CE, mainly because currently the compat between the mods aren't great, and in actuality, there's little actual reason to play with IC2CE

Describe the solution you'd like
to less be dependent on ic2ce

  • add a automatic ore washer in a GT4 style, as the replacement for the ic2ce one for when it's not loaded, would allow crushed ores and everything to work standalone, just have it use a config for people who don't like the ore processing
  • add a automatic thermal centrifuge, extension of the ore washer feature request
  • add a option to use the IC2E cable recipe with the GTCX insulation cutters, so you can have the IC2E cables without IC2CE
  • add uranium and thorium processing to the thermal centrifuge, if ic2ce isnt loaded

random requests

  • remove osmium, in GT4 osmium was a compat material, and had no GT uses or recipes, in GTCX it has no uses, only a crafting recipe and that crafting recipe is IC2CE dependent
  • add plate and hammer bucket recipe, and add 3 plates to a bucket in the plate bending machine
  • add wrought iron oredicts to all refined iron materials, refined iron is wrought iron, and GTC does this, GTCX lacks this on its plates, gears, and rods

Describe alternatives you've considered

  • for the thermal centrifuge, you could instead just add the recipes to the GTC centrifuge, same for any mention of the thermal centrifuge in the other requests
  • for osmium, you could instead add uses for it, and add a non IC2CE dependent recipe (probably using the other requests), which id be happy with, if its in just for modpack usage, it could be an addon, or better yet just a ct script if the material system gets that soon

Additional context
in general IC2CE is a great mod, but because of the structure of GTCX, and how GT4 it self is, i don't think it should be required to get the same experience, which are what these suggestions are about, hold the osmium, wrought iron, and bucket one

Large steam turbine can not be assembled?

Description of the Bug

I tried various configurations and none of them worked
2020-06-11_12 03 57
2020-06-11_12 03 59
2020-06-11_12 04 10
2020-06-11_12 04 12

However, after seeing this

if (world.getBlockState(dir.left(1).asBlockPos()) != Blocks.AIR.getDefaultState()){

And this

I started to question myself if it is ever possible to construct such turbine

checkStructure() { return lorem ipsum; }

Machine Hull resource duplication

To Reproduce

javaw_dQtak1dicT
javaw_lQFgcpmtO5
Same thing goes to all machine hulls

Expected behavior

I get 6 plates (or ingots, if you prefer) back instead of 8

Environment

  • Mod version: 0.1.1
  • Forge: Build 2854

Crash on start MC.

Description of the Bug
Crash on start MC.

To Reproduce

  1. Place block '...'
  2. Click on '....'
  3. See '...'

Expected behavior

Screenshots & Video

Logs & Environment

  • Full log:

Additional context

gregtech classic for 1.7.10

Greetings, I would like to know if there is a possibility that this gregtech 4 mod is for version 1.7.10. for IC2 Classic, because there is none for this version and it is only for the experimental version that I personally don't like, there is a possibility, I know there is a gregtech 6 but I like 4 more.

Distillation Tower unable to accept fluids.

I'm running GTC Expansion 0.1.1, and I am unable to insert fluids into the distillery. I have tried inserting fluids into every side, and have configured the sides to import to no avail. The slots inside the GUI are greyed out as well. Am I doing something wrong, or is it bugged?

U233 tiny dust to full dusts

Description of the Bug

To Reproduce

  1. Place block '...'
  2. Click on '....'
  3. See '...'

Expected behavior

Screenshots & Video

Logs & Environment

  • Full log:
  • Crash report (If available):

Additional context

e9 things

Trins leave this issue here so i can to it as find things you can fix,remove them

  • clay dust in the electrolyzer should be 7 in not 8, and the eu cost should be double
  • you need to iterate your material one flag at a time cause jei is a clusterf**k - conflict between jei and nei, not my fault
  • i would skip all the steps for the fire bricks and just have 1 dust smelts to 1 brick, no mold etc.. but thats up to you, - Will probably add a config

Large Steam Turbine bugs

Description of the Bug

The large steam turbine doesn't output water to the output hatch. Another small thing that might be considered a bug is that the large steam turbine stops working when the energy buffer is full, voiding the excess electricity would be a better idea imo, to prevent reactor meltdowns because of energy storage running full.

To Reproduce

  1. Build large steam turbine with output hatch
  2. Pump steam into it
  3. Look into output hatch

Expected behavior

Water should appear in the output hatch.

Screenshots & Video

None.

Logs & Environment

  • Crash report (If available): None

Additional context

None.

Extend upgrade slot amount to 4 to match GTC

Is your feature request related to a problem? Please describe.

javaw_2f0J9wV8E8
javaw_4x5Ee8CPQw
javaw_TTwhpVpIDG

Describe the solution you'd like

I get 4 upgrade slots in each GTCX machine, like in IC2C and GTC (maybe except blast furnace, since 2 upgrade slots there seems to be fair to me)


Keep in mind that while regular machines in IC2C have 4 upgrade slots, overclocked ones do have only 2 slots for upgrades, so i might be missing point in only 2 upgrade slots in GTCX machines

javaw_ibh8CF00Rj
javaw_lMmGJMKFk6

Feature Request From CrossVas

Is your feature request related to a problem? Please describe.
I love GTCX and all the stuff it contains, but playing with this mod makes me feel a bit bored because of some aspects.

  1. All GTCX Tools (Wrench, Hammer, File) are "infinite". What do I mean? Well let's say you have a fresh world, you have done some mining and you want to get started with GTC and GTCX. The first thing you will craft is Iron Hammer in order to make plates, then Iron Wrench and File. After a while you will find out that there are no reasons to upgrade to Bronze, and then to steel, tungstensteel, because iron tools you made have enough durability and they are cheaper (just do some mining, find iron and that's it!)
    Shortly: The player doesn't have stimuli to upgrade to Bronze, Steel, Tungsten Steel tools.
  2. Some items have two recipes (one of which is useless). I.e. Drill, Saw and all IC2C' tools, Empty Cells.

Describe the solution you'd like
1.

  • In order to make the player use advanced tools (>Iron Tools), it would be great to decrease the durability to be: 128, 256, 512, 5120.
  • Make Wrenches and Hammers take damage more than 1 when crafting Machine Hull, etc..
  • Have a config option to enable/disable "hard recipes".

If there's something that I'm missing, let me know.

EDIT: If GTCX is meant not to be hard, sorry and skip this.

Thanks,
CrossVas.

Crafting table single use batteries recipe.

Batteries crafted in the crafting table contain no charge. When the batteries are crafted they contain no tags, which also causes them to not be usable in the extractor. Using craftweakers hand command, I noticed that they had no energy tag.

Battery that was spawned in with creative and depleted:
<gtc_expansion:acid_battery>.withTag({charge: 0.0 as float})

Battery that was crafted in the crafting table:
<gtc_expansion:acid_battery>.withTag({})

GTCX can not be compiled locally

Description of the Bug

GTCX can not be compiled locally because curseforge has weird/broken cloudflare firewall setup (for several months already) where I'm Under Attack! cover even API endpoints for maven (in fact, curseforge even blocked most of search bots by utilizing cloudflare firewall rules wrong)

To Reproduce

  1. Clear gradle build cache from required libraries to build GTCX
  2. Try to build it
15:36:26.471 [INFO] [org.gradle.internal.resource.transport.http.HttpClientHelper] Failed to get resource: GET. [HTTP HTTP/1.1 503 Service Temporarily Unavailable: https://minecraft.curseforge.com/api/maven/CraftTweaker2/ZenScript/maven-metadata.xml]
15:36:26.472 [DEBUG] [org.gradle.internal.operations.DefaultBuildOperationExecutor] Completing Build operation 'Download https://minecraft.curseforge.com/api/maven/CraftTweaker2/ZenScript/maven-metadata.xml'
15:36:26.472 [DEBUG] [org.gradle.internal.operations.DefaultBuildOperationExecutor] Build operation 'Download https://minecraft.curseforge.com/api/maven/CraftTweaker2/ZenScript/maven-metadata.xml' completed

overpowered weapons

Description of the Bug
all GTCX tools are extremely overpowered in terms of damage values

To Reproduce

  1. use gtcx
  2. use any sword, or look at their tooltip

Expected behavior

sapphire/ruby are 8.5 damage, diamond is 7, the steel sword is the same as diamond, way less durability sure but way cheaper to, and tungstensteel, is 2x of diamond, and is encroaching on the nanosaber, the axes, pickaxes, and shovels have the same issue, in GT4, steel was the same damage as iron, tungstensteel was the same damage as diamond, i don't see why all of these are way more powerful, i can only name 4 swords more powerful than this tungstensteel, in all of 1.12 modded

Screenshots & Video
N/A

Logs & Environment
N/A

Additional context
i'd prefer tungstensteel to do like 8 or 9 i never understood what the point when it was the same as diamond, but this is just to much, i think 8 or 9 would really be the sweet spot, for steel probably 6.5, ruby/sapphire probably 7 so the same as diamond, for the swords, for the axes i would say do something similar, but i haven't thought about what they should all be yet

list of to many recipe issues

Description of the Bug
recipe bugs, and in general weirdness, some of these probably aren't bugs, but im putting them here anyway just in case

To Reproduce
look at JEI

Expected behavior

every screenshot has the GT4 recipe below it, i don't expect them all to be identical to GT4 but they should be within reason of the GT4 recipes i would assume

Screenshots & Video

im gonna list everything here with screenshots, this will be the easiest way to format this

Logs & Environment

  • Full log:
  • Crash report (If available):

anything with crash reports or logs is N/A because this is recipe issues

Additional context

i know increasing the duration of some of these recipes will increase the EU needed, but the duration being more, is way less important than the EU required being less, GT4 is about long processes, and automating them, so in a sense without them this kinda kills a lot of what makes GT4 unique

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.