[NPC/Boss] Scourgelord Tyrannus is not selectable about trinitycore HOT 11 CLOSED

Author: nay
I see flag changes but no bitwise math. (Never use = for flags)
It's the core script that should add/remove the attackable/targeteable flags.

from trinitycore.

Author: androx
Replying to [comment:2 nay]:

I see flag changes but no bitwise math. (Never use = for flags)
It's the core script that should add/remove the attackable/targeteable flags.

Yup, I agree with you... I´ll check the core script...

from trinitycore.

Author: fuchs
pls fix this ;P

from trinitycore.

Author: androx
Replying to [comment:4 fuchs]:

pls fix this ;P

I'll try, I´m not a trinity dev, but I'm a C/C++ Dev and I can help =), currently I'm learning all project structure, mechanism, logic, etc, and later, I can contribute with fixes =),this is a large project in SLOC (1.9M lines of code aprox), currently I'm finding where the core set and unset the flags of bosses, I have some tips, for example:

src/server/scripts/EasternKingdoms/ScarletMonastery/boss_mograine_and_whitemane.cpp:88: me->RemoveFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_NON_ATTACKABLE);

src/server/scripts/Northrend/FrozenHalls/HallsOfReflection/halls_of_reflection.h:114: me->RemoveFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_NON_ATTACKABLE|UNIT_FLAG_NOT_SELECTABLE);

src/server/scripts/Northrend/FrozenHalls/HallsOfReflection/halls_of_reflection.cpp:169: pCreature->RemoveFlag(UNIT_NPC_FLAGS, UNIT_NPC_FLAG_GOSSIP);

src/server/scripts/Northrend/FrozenHalls/HallsOfReflection/halls_of_reflection.cpp:175: pCreature->RemoveFlag(UNIT_NPC_FLAGS, UNIT_NPC_FLAG_GOSSIP);

I see in other script this methods (RemoveFlags and SetFlags) and of course, this flags are in Unit.h, I'll get the last revision from Git, and set unitflag of Tyrranus to the original value from TDB_335.11.36_10818, I see some commits related with Scourge Tyrannus boss, I´ ll test this git commit...

from trinitycore.

Author: androx
With TrinityCore Rev: 10935+ Release Hash: 77af7ba+ , TDB : 335.11.36 and TDBAI 335.0.3 , the boss is an invalid target, if you update the unit_flags from 33554496 to 64 is the same result...

But, now the scene of Ick is much better =), Scourgelord Tyrannus now appear and kill Ick Boss (nice job =) )....

from trinitycore.

Author: androx
Ok I see the script of Scougelord Tyrannus at line number 482 the reasson why the script dont start, I'll set my gm account to normal and check the boss again... details :

{{{
bool OnTrigger(Player* player, const AreaTriggerEntry* /at/)
{
InstanceScript* instance = player->GetInstanceScript();
if (player->isGameMaster() || !instance)
return false;

        if (instance->GetBossState(DATA_TYRANNUS) != IN_PROGRESS || instance->GetBossState(DATA_TYRANNUS) != DONE)
            if (Creature* tyrannus = ObjectAccessor::GetCreature(*player, instance->GetData64(DATA_TYRANNUS)))
            {
                tyrannus->AI()->DoAction(ACTION_START_INTRO);
                return true;
            }

        return false;

}}}

...

from trinitycore.

Author: stryker
have you applied

http://www.trinitycore.org/t/trinitycore/ticket/3 < ?

from trinitycore.

Author: androx
Replying to [comment:8 stryker]:

have you applied

http://www.trinitycore.org/t/trinitycore/ticket/3 < ?

Yup I applied this :

{{{
UPDATE creature_template SET speed_run=1.857143,speed_walk=3.2,unit_flags=0x00000040,faction_A=14,faction_H=14,baseattacktime=2000,equipment_id=1872 WHERE entry IN (36658,36938); -- Scourgelord Tyrannus
}}}

The same result the boss Scourge Tyrannus is an invalid target, I killed Forgemaster and Ick too (Heroic and no heroic mode)...

TrinityCore Rev: 10941+ Release Hash: eac259f+
TDB 335.11.36
TDBAI 335.0.3

from trinitycore.

Author: androx
Now I applied the entire db fixed from : http://www.trinitycore.org/t/trinitycore/ticket/3 plus

{{{
UPDATE creature_template SET speed_run=1.857143,speed_walk=3.2,unit_flags=0x00000040,faction_A=14,faction_H=14,baseattacktime=2000,equipment_id=1872 WHERE entry IN (36658,36938); -- Scourgelord Tyrannus
}}}

And only the Rimefang spawn, not the Scourgelord Tyrannus... , the same in Heroic o Normal...

Now is necesary the Quest Deliverance from pit to enter the Hall of Reflexion (nice job =) ) but is necesary complete the quest The path of citadel (only Forgemastes is killable, but free the slave is not possible, ticket : http://www.trinitycore.org/t/trinitycore/ticket/29

Complete quest set:

http://www.wowhead.com/quest=24712/deliverance-from-the-pit

TrinityCore Rev: 10941+ Release Hash: eac259f+
TDB 335.11.36
TDBAI 335.0.3

from trinitycore.

Author: zxbiohazardzx
if you wish to fix the unit then fix the script, and submit a new patch, this update is wrong

from trinitycore.

Author: androx
If this ticket is invalid and I applied only the suggest from this ticket: http://www.trinitycore.org/t/trinitycore/ticket/3 both ticket should be invalid, not only this.....

from trinitycore.