treywood / babel-plugin-bluebird-async-functions Goto Github PK

This plugin requires a global Promise (or a polyfill) to exist which is messy (IMO).

We could also import bluebird into the module with a simple change:

let asyncWrap = t.memberExpression(bluebird, t.identifier(methodName));
// to
let asyncWrap = t.memberExpression(state.addImport('bluebird', 'default', node.name), t.identifier(methodName));

adopted from https://github.com/babel/babel/blob/72c091b63a1f443fdae34e89c821eb0e35eef3ed/packages/babel-plugin-transform-runtime/src/index.js#L41-L45

edit: the current code makes this plugin unusable for libs

Another purpose of this transformer is to create a sandboxed environment for your code. If you use babel-polyfill and the built-ins it provides such as Promise, Set and Map, those will pollute the global scope. While this might be ok for an app or a command line tool, it becomes a problem if your code is a library which you intend to publish for others to use or if you can’t exactly control the environment in which your code will run.

https://babeljs.io/docs/plugins/transform-runtime/

doing it that way makes it work on JSPM, which doesn't run postinstall scripts
also allows you to make all dependencies devDependencies (i.e. unneeded)

I've looked around and not found a good way to replace the native es6 promise with bluebird. I tried below in my entry file

global.Promise = require('bluebird');

Promise.config({
  warnings: false,
  longStackTraces: true,
  cancellation: true
});

require('./entry');

but still get this error in a subsequently imported file

exports.default = Promise.coroutine(regeneratorRuntime.mark(function _callee(_ref) {