Add better support for git views about nova-vim HOT 10 CLOSED

@alexlafroscia Great idea! I agree. Along with using background colors, it would be good to update to use the nova-colors versionControlGroups; right now git related highlight groups are incorrectly not using versionControlGroups. Would you mind taking this one? If not, I'll get to it :)

from nova-vim.

Sure, I'll add it to my list and see if I can get to it tonight.

from nova-vim.

Thanks @alexlafroscia you rock. If you don't have time no worries I'll take care of it at some point :)

from nova-vim.

@trevordmiller Add/removed is pretty easy, but changed lines vs. the actual part of the line that changes (blue background vs. yellow background in the Gruvbox screenshot) are two different color groups. How do you want me to handle that?

from nova-vim.

@alexlafroscia Would it make sense to use novaColors.versionControlGroups.modified (orange) for the line that changes and novaColors.versionControlGroups.renamed (blue) for the actual part of the line that changed? Or we could extend nova-colors with versionControlGroups.exactModified (and set it equal to one of the unused colorValues for versionControlGroups) or something? I'll defer to whatever you think is best as I don't use vim diffs (I use terminal git outside of vim for git stuff).

from nova-vim.

Would it make sense to use novaColors.versionControlGroups.modified (orange) for the line that changes and novaColors.versionControlGroups.renamed (blue) for the actual part of the line that changed?

I like this idea. It looks something like this:

The blue text on orange background is too light IMO. We could always change the background color behind that text through.

from nova-vim.

A darker orange color for the changed text might look nice

from nova-vim.

@alexlafroscia Thanks for looking at that. Yeah if you can use the background color with the blue (versionControlGroups.renamed) that would be best as I would prefer not to extend nova-colors unless absolutely necessary. You could also experiment with passing in underline so that the inline change is the same color as the line but is underlined or something; that would require re-working how the highlight helper works to allow passing in style modifiers. Without actually trying it out, I would imagine just doing what you did with the blue but making it the background instead of the foreground would probably work best.

from nova-vim.

alright, so I'll try

• Blue background
• Orange text
• Underline (maybe)

Right?

from nova-vim.

@alexlafroscia Sure, whatever you think makes the most sense :)

from nova-vim.