Comments (4)
This is a known limitation of using native Dialog element because Dialog element renders on top-layer, which you can not override it via z-index values. Technically Popover API is on the way which will fix this issue, but until that time, I think we may check for a workaround for this.
Currently our dialog supports older browsers that don't support dialog element. We make that check automatically and use a polyfilled version instead with that small decision point:
private get hasHtmlDialogSupport() {
return !!window.HTMLDialogElement;
}
Maybe we can consider making this a property that you can manually set outside like:
@property({ type: Boolean })
levelled = !window.HTMLDialogElement;
So, whenever a popover opens within a browser that doesn't support Popover API, dialog that is already visible can be switched to levelled
variant which will convert dialog to a version that respects z-index rules. But:
- We need to be careful about UX effects of this. If this switch causes a rerender on dialog content, that would be awful for use-cases like filling a form inside dialog, or reading a long text, since a new notification will interrupt these badly.
- If we set this true by default in a project, then we'll miss the opportunities that native dialog element provides us and we can not easily implement in a custom dialog element, like avoiding cropped dialog because of parent style rules and keyboard navigation trap.
Please feel free to share your opinions. @Enes5519
PS: levelled
name could be switched with a better option.
from baklava.
It is healthiest to do it this way, different ways are not ready yet, so we can pass prop in this way.
from baklava.
🎉 This issue has been resolved in version 2.2.0-beta.9 🎉
The release is available on:
Your semantic-release bot 📦🚀
from baklava.
🎉 This issue has been resolved in version 2.2.0 🎉
The release is available on:
Your semantic-release bot 📦🚀
from baklava.
Related Issues (20)
- [BUG]: Baklava select input popover close event trigger problem HOT 2
- trendyol.design Website HOT 1
- [BUG]: border-top is not coming correctly in BlInput label animation HOT 3
- Enhancing SSR Compatibility HOT 1
- npm install @trendyol/baklava
- Add Custom CSS Properties for Border Radius, Style, and Color to bl-button HOT 4
- Change table row hover color
- [BUG]: <Border of single select clear button is missing> HOT 1
- [Feature Request]: <Textarea Custom Validation>
- [BUG]: Empty bl-select causes floating-ui to throw an error HOT 2
- [BUG]: False positives for notification UI tests on PRs
- [BUG]: Searchable select hides label HOT 2
- [Feature Request]: Select search should support international character set
- [BUG]: Select search isn't cleared on option select
- [BUG]: Storybook select input triggers storybook shortcuts
- [Feature Request]: <Adding Critical Dialog Variant to Dialog Component>
- [Feature Request]: Create ADRs folder per component
- [Component]: <Spinner Component>
- [BUG]: <Split Button seperated events>
- [BUG]: Disabled select option can be selected with enter HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from baklava.