Comments (4)
We don't need these attributes because we already have four styles: Default, Neutral, Success, and Danger. We want to enforce strictness for now in order to maintain consistency within the design system.
from baklava.
-
Is it possible to change the border radius of buttons?
-
For border style, in the secondary type of split button, the primary button and dropdown button are adjacent and to avoid overlapping borders each other, I think that if I give the "none" left border style of the dropdown button It solves the issue.
-
for border color, in the disabled type of split button, there is a divider between the primary button and the dropdown button. I think that if I give the specific border color to the right border of the split button It solves the issue.
You are right, maybe I can add a divider for the last one, but for the other ones, we can talk if they are necessary or not.
from baklava.
- No, it isn't.
- The border style shouldn't be changed by the developer, so I believe your solution is appropriate.
- The button and the dropdown handler each have separate disabled attributes, so they should be considered as three different scenarios.
from baklava.
You could consider one of them as the new button inherited from our bl-button
, while the other is an already existing component of bl-dropdown
.
from baklava.
Related Issues (20)
- [BUG]: border-top is not coming correctly in BlInput label animation HOT 3
- Enhancing SSR Compatibility HOT 1
- npm install @trendyol/baklava
- Change table row hover color
- [BUG]: <Border of single select clear button is missing> HOT 1
- [Feature Request]: <Textarea Custom Validation>
- [BUG]: Empty bl-select causes floating-ui to throw an error HOT 2
- [BUG]: False positives for notification UI tests on PRs
- [BUG]: Searchable select hides label HOT 2
- [Feature Request]: Select search should support international character set HOT 1
- [BUG]: Select search isn't cleared on option select HOT 1
- [BUG]: Storybook select input triggers storybook shortcuts
- [Feature Request]: <Adding Critical Dialog Variant to Dialog Component> HOT 1
- [Feature Request]: Create ADRs folder per component
- [Component]: <Spinner Component>
- [BUG]: <Split Button seperated events> HOT 1
- [BUG]: Disabled select option can be selected with enter HOT 2
- [Feature Request]: Improve dependabot.yml for better automated package management HOT 1
- [BUG]: BlSplitButton triggering on dropdown click
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from baklava.