Giter Club home page Giter Club logo

Comments (7)

muratcorlu avatar muratcorlu commented on June 6, 2024

@stovein @buseselvi We considered to use radio group items with List item components in a design meeting that I couldn't join, right? Can you confirm that?

from baklava.

buseselvi avatar buseselvi commented on June 6, 2024

@muratcorlu Yes we did and here is the design documentation: https://www.figma.com/file/RrcLH0mWpIUy4vwuTlDeKN/Baklava-Design-Guide?type=design&node-id=4384%3A22880&t=WPWovqNJOOkYbdjH-1

from baklava.

stovein avatar stovein commented on June 6, 2024

Yeah, I am aware about list component subject, however I meant radio button having 16px(radio button icons' height) height, thus we cannot actually have any bigger label data than radio button size.

from baklava.

buseselvi avatar buseselvi commented on June 6, 2024

@stovein can you share an example from the design?

from baklava.

stovein avatar stovein commented on June 6, 2024

Here is an example that happens when we set height, but label's height overflow 16px.
image

I opened a pr that resolves height issue and flow layout issue mentioned in first comment, but there are still problems with flex layout. We cannot align radio icon to center(for example) and content with only styling bl-radio element and even though defining width implicitly, flex styled bl-radio does not fill fillable spaces with label.

from baklava.

github-actions avatar github-actions commented on June 6, 2024

🎉 This issue has been resolved in version 2.2.0-beta.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

from baklava.

github-actions avatar github-actions commented on June 6, 2024

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

from baklava.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.