trdischat / conditions5e Goto Github PK

View Code? Open in Web Editor NEW

3.0 3.0 18.0 41 KB

JavaScript 100.00%

conditions5e's People

Contributors

Stargazers

Watchers

Forkers

rmasoni turn-a amcvfx marduke182 grygon ddipaolo strongpauly matthewbcline gatesvp carnvanbeck magroader mattstock gryfin123 why-keith p4535992 brucetony restlessrabbits

conditions5e's Issues

Skull marker is shrunk and not overlayed properly

It seems with 0.7.5 the skull no longer stretches over the token properly but rather shows like a status effect.

Error in console anytime a condition is added/removed.

Uncaught (in promise) TypeError: effect is undefined
    toggleEffect foundry.js:44970
    toggleOverlay foundry.js:45525
    _updateHealthOverlay main.js:73
    <anonymous> main.js:82
    _call foundry.js:2496
    callAll foundry.js:2456
    _handleUpdateEmbeddedEntity foundry.js:30047
    _handleUpdateEmbeddedEntity foundry.js:34301
    updateEmbeddedEntity foundry.js:30015
    update foundry.js:11475
    toggleEffect foundry.js:44983
    _onToggleEffect foundry.js:23355
    jQuery 8
    activateListeners foundry.js:23232
    _render foundry.js:4537
    _render foundry.js:20787
    render foundry.js:4479
    bind foundry.js:20762
    bind foundry.js:23107
    _onClickRight foundry.js:11887
    callback foundry.js:36392
    _handleClickRight foundry.js:36646
    _handleRightDown foundry.js:36626
    emit index.js:181
    dispatchEvent InteractionManager.ts:1106
    processPointerDown InteractionManager.ts:1307
    recursiveFindHit TreeSearch.ts:173
    recursiveFindHit TreeSearch.ts:113
    recursiveFindHit TreeSearch.ts:113
    recursiveFindHit TreeSearch.ts:113
    findHit TreeSearch.ts:200
    processInteractive InteractionManager.ts:1177
    onPointerDown InteractionManager.ts:1252
    addEvents InteractionManager.ts:885
    setTargetElement InteractionManager.ts:815
    r InteractionManager.ts:733
    initPlugins AbstractRenderer.ts:229
    r Renderer.ts:268
    create Renderer.ts:85
    mn autoDetectRenderer.ts:39
    t Application.ts:87
    Canvas foundry.js:9967
    initializeCanvas foundry.js:6661
    setupGame foundry.js:6546
    _initializeGameView foundry.js:7319
    initialize foundry.js:6471
    async* foundry.js:7449
    async* foundry.js:7447

Movement Error

I am unsure what exactly is happening.

During a session two days ago, we were experiencing a massive lag issue. Checking the console I was shocked to see over 400 errors.

It has taken me two days to narrow down and find the badly behaving mod, and it turns out to be conditions5e.

Info:

Platform: Windows 10
Browser: Chrome
Foundry Version: 0.7.9

Error: When selecting a token then moving said token, we receive foundry.js:44970 Uncaught (in promise) TypeError:
https://prnt.sc/10m1b7y

All mods deactivated except for conditions5e

I have been able to repeat this error in four different game worlds. Strangely, it does not seem to affect all tokens.
I have tried replacing the actors, recreating the actors, all to the same error.

When setting an overlay condition the status image is removed

When you set a token condition with right click the large overlay is shown briefly and then disappears.
Left click behaviour works as expected.

Labels

I couldn't figure out what condition each icon represented until reviewing the icons directory and the README. I made a graphic with labels for each condition:

It would be excellent to see a label for the condition when hovering over it.

Feature Request: Add tooltips

Could you add tooltips on hover of the icons?? Thanks!

keep all conditions and restore "big" overlay

I used a lot of the old "odd" icons for conditions from spells or just to remember stuff, like which one of the goblins is the one with 250hp, elite, etc. Can we have those back ? The current ones are ok, but maybe have a setting to add the old ones as well ?
before, when you were trying to put a condition marker on a token, normal click would put a small icon upper left, RIGHT CLICK would put an overlay on the token, more easily marking which token is asleep/tied up/etc. With this module enabled, only small icon overlays seem to be allowed. I am just guessing that is because of the "bloodied" overlay that happens based on current HP. I love the bloodied overlay and I want to keep it, but I also want the option for the big overlay "other condition". Any ideas on that ?

thanks.

I Can't find it

I can't find it on the Add-ons Module.

I can only install it through the link.

Add german translation

Just a request to add the german translation

Targeting not being displayed

Noticed that when I have this enabled, the targeting is not being displayed. It sometimes shows and sometimes doesn't.

unable to right click a condition to have it full-size overlay on token icon.

With the default conditions, you can left click to have a small icon appear on the token, or right click to have a full size icon appear on the token.

With this mod, right clicking a condition causes it to briefly flicker as full size on the token then disappear.

Is this intentional since you automatically put full size conditions on the token at certain events? like taking damage, death?

Add customization option for additional conditions

Hey, I really like that module, but I would like to track more "conditions" like blessed, cursed etc.
Maybe you could add settings to add more conditions where the GM can define more stuff, with an icon and a label.