Generic views don't respond to get_success_url() since version 3.0.0 about django-bootstrap-modal-forms HOT 5 CLOSED

Sent another PR, sorry again for incomplete work...

from django-bootstrap-modal-forms.

Good catch. Definitely should be as you suggested. The same as it is in LoginAjaxMixin and DeleteMessageMixin. Tnx for the #219. Patch version coming right away.

from django-bootstrap-modal-forms.

Sorry for any inconvenience, seems that was not the whole story. I have problems in some situations when there is no get_success_url method provided but the class attribute success_message is set. I get the exception

File "/Users/christianwiegand/.virtualenvs/medic/lib/python3.10/site-packages/django_bootstrap_modal_forms-3.0.1-py3.10.egg/bootstrap_modal_forms/mixins.py", line 95, in form_valid return HttpResponseRedirect(self.get_success_url()) File "/Users/christianwiegand/.virtualenvs/medic/lib/python3.10/site-packages/django_bootstrap_modal_forms-3.0.1-py3.10.egg/bootstrap_modal_forms/mixins.py", line 82, in get_success_url return super().get_success_url() File "/Users/christianwiegand/.virtualenvs/medic/lib/python3.10/site-packages/django/views/generic/edit.py", line 123, in get_success_url url = self.success_url.format(**self.object.__dict__) AttributeError: 'NoneType' object has no attribute '__dict__'. Did you mean: '__dir__'?

I have to work out what the reason is. As long there's no solution the workaround would be to give the view class an appropriate get_success_url method and return the url value.

from django-bootstrap-modal-forms.

Btw, is there any doc on how to run the tests locally? Thanks

from django-bootstrap-modal-forms.

No need to apologise @christianwgd. You are doing amazing job with your contributions. I should be more careful when releasing such limited mixin in the first place.

I didn't manage to run tests within docker container yet, thus I'm creating virtualenv with pyenv and run tests within it. I'm using Chrome and chromedriver. Check this comments that were added recently by @aDramaQueen https://github.com/trco/django-bootstrap-modal-forms/blob/master/tests/base.py#L14.

I have to add this to the docs.

from django-bootstrap-modal-forms.