Rubyzip crash when freezing time about timecop HOT 12 CLOSED

Little update: The issue is that when calling the Zip::DOSTime.now method (from the inheritance of Time) it return a Time class object instead of DOSTime.

from timecop.

This nasty workaround works for me for now:

Given /^the date is "([^"]*)"$/ do |date_string|
  Zip::DOSTime.instance_eval do
    def now ; Zip::DOSTime.new(Time.now.to_s) ; end
  end

  Timecop.travel DateTime.parse(date_string + " 00:00:00 -0500")
end

from timecop.

@kpolitowicz Thanks for the patch. I also had the same issue.

from timecop.

@kpolitowicz's do you think there's something that should go in the project, or just throw something in the README about dealing with Zip::DOSTime?

from timecop.

potential fix: yaauie/7c6f531b

Not tested for this particular use-case, but it should allow subclasses of Time, Date, and DateTime to interface with Timecop properly, and works with 1.8.x and 1.9.3.

from timecop.

@yaauie just wrote a script using Rubyzip to try it and it seems good. Thanks! 👍

from timecop.

@travisjeffery @yaauie Thanks, I'll try this out in my project as soon as the updated gem is released.

from timecop.

@kpolitowicz I've already pushed the gem. I messed up the month, but 0.4.5 is the version that has this change.

from timecop.

@travisjeffery I confirm, works like charm without my hack.

from timecop.

I realized I neglected to commit my tests. They are here: yaauie/c87ffc3f8

from timecop.

@kpolitowicz awesome. Thanks again @yaauie

from timecop.

@kpolitowicz +1. Thanks for that, it worked for me as well. I was experiencing the same problem but I was using the delorean gem.

from timecop.