Date.strptime returns wrong month for %Y about timecop HOT 6 CLOSED

Thanks guys. The Timecop implementation of strptime is a work in progress. Our implementation is incomplete and we're slowly chipping away at it. It should behave like the ruby implementation.

checkout

from timecop.

@krzyzak and @augustoccesar i'd appreciate if you'd have a look at my PR #379 for this issue. I'm open to suggestions on ways to better implement this.

from timecop.

thanks for the bug report @krzyzak are you interested in sending a PR with tests that demonstrate the fix?

from timecop.

I was looking into opening a PR for this issue, but from the short investigation that I did it seems that this is a very explicit expected behaviour.

I guess to change to the expected behaviour described in this issue it would need to change to something like

d = Date._strptime(str, fmt) || Date.strptime_without_mock_date(str, fmt)
now = Time.now.to_date
year = d[:year] || now.year
mon = d[:mon] || 1

which feels like a large change from the perspective of expectation of how this method works (on timecop).

So I think that the main question is: Should the timecop Date.strptime behaves like the Ruby Date.strptime, or this an expected/desired behaviour to default to the current month?

from timecop.

@joshuacronemeyer yes, that indeed fixes my issue. Is there an option to release new gem version?

from timecop.

@krzyzak thanks for asking. I just released 0.9.5 that includes this change. Would appreciate you bumping your version and testing.

from timecop.