trasal / frbpoppy Goto Github PK

Hi David,

I've been using your code to estimate how many FRBs we could detect with a new survey -- thank you very much for making this available, it is fantastic! (I will be in touch about the science via email once it's a bit better fleshed out).

I had some ideas for speeding up the code, which are in this notebook.

The first is to speed up gen_dm() in CosmicPopulation by using healpy to do the coordinate lookup, instead of sqlite (there is a fair bit of overhead with making multiple sql queries). I just uploaded a precomputed NE2001 and YMW16 healpix maps to PyGEDM, which is essentially equivalent to the sqlite table frbpoppy populates.

The second is to speed up gen_dist() by using interp1d from scipy, to generate interpolation functions that can be used instead of the DistanceTable lookup.

Combined, these should significantly speed up the time taken for CosmicPopulation.generate().

As you'll see in the notebook, the NE2001 models have some disagreement. I'm not sure if this is due to rounding or something else?

Issue seems to lie with numbers larger than ~1e80. See for instance the bolometric luminosity.

See issue subject

At the moment the rate parameters are empty. Calculate them and add

The following in the complex function under cosmic_pop.py
https://github.com/davidgardenier/frbpoppy/blob/ccaf4869965cb752e78d55d1c02afa64e9467c0e/frbpoppy/cosmic_pop.py#L531 should be repeaters=repeaters, generate=generate) as otherwise, it won't use the inputs of the function for the population.

Add assertions statements into code

Check through documentation in both code, and the resulting website

Hi,
I am trying to install frbpoppy in ubuntu but I got the following error.
base) lenovo@lenovo-ThinkPad-E15:~/frbpoppy$ python3 setup.py develop
error in frbpoppy setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Expected end or semicolon (after version specifier)
requests >= 2.20.0.

Is there any solution to this. Please help me out with this.

If the bin limits of the initial population don't cover that of subsequent plotted populations, the later populations won't show up on the plot. It's easily spotted plotting the parameter against another one, rather than as a histogram. Going to be difficult to solve due to the nature in which histogram bins are determined (recursively)

Allow scripts to be run from command line

Implement all properties given in frbcat in order to compare properties

Hi! frbpoppy has been at the core of my work, thanks a lot for making it !
I found an issue in the pixel_scale for airy and gaussian beam patterns, which is taken as follows in the code:

But, if I go find the fwhm ( in pixels ) in the beam_array given for gaussian and airy beam patterns, I find it to be 94X2 and 30X2 pixels wide respectively. Looks like the pixel scales should have been fwhm/188, and fwhm/60 respectively. Could you please look into it?

On basis of geometry argument. Maximum scattering on basis of scattering screen directly in between source and observer. Gets less as screen moves away from that position.

See Emily's thesis for details

Simple interactive plotting capabilities (bohek or plotly)

I followed these steps, and got the following error:

>> conda create -n frbpoppy python=3.8
>> conda activate frbpoppy
>> git clone https://github.com/davidgardenier/frbpoppy.git 
>> cd frbpoppy
>> python3 setup.py develop
>> python3 examples/_starting_with_frbpoppy_.py 
cosmic_pop.py | Generating complex population
Traceback (most recent call last):
  File "examples/_starting_with_frbpoppy_.py", line 14, in <module>
    cosmic_pop.generate()
  File "/hyrule/data/users/kshitij/frbpoppy/frbpoppy/cosmic_pop.py", line 499, in generate
    self.gen_dist()
  File "/hyrule/data/users/kshitijfrbpoppy/frbpoppy/cosmic_pop.py", line 126, in gen_dist
    n_model = self.dist_func()
  File "/hyrule/data/users/kshitij/frbpoppy/frbpoppy/cosmic_pop.py", line 122, in <lambda>
    self.dist_func = lambda: NumberDensity(model=model, **kwargs)
  File "/hyrule/data/users/kshitij/frbpoppy/frbpoppy/number_density.py", line 31, in __init__
    m = self.dt(z=np.array([z_max]))
  File "/hyrule/data/users/kshitij/frbpoppy/frbpoppy/precalc.py", line 352, in lookup
    d = c.execute(query, [str(r)]).fetchone()
sqlite3.OperationalError: disk I/O error