Giter Club home page Giter Club logo

sharkey's People

Contributors

acid-chicken avatar akihikodaki avatar anatawa12 avatar ayamorisawa avatar dakkar avatar dependabot-preview[bot] avatar dependabot-support avatar dependabot[bot] avatar ebiselutica avatar futchitwo avatar greenkeeper[bot] avatar ha-dai avatar insert5starname avatar johann150 avatar kakkokari-gtyih avatar mar0xy avatar marihachi avatar massongit avatar mei23 avatar nenohi avatar otofune avatar pixeldesu avatar rinsuki avatar saschanaz avatar shittykopper avatar syuilo avatar tamaina avatar tosuke avatar u1-liquid avatar xianonn avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

sharkey's Issues

feat: Automatically mark NSFW all media from user

Summary

Add a toggle in user moderation, to automatically mark NSFW all media from user.
I believe this used to be a thing in previous versions of Misskey, but it got moved to roles, however it'd still be nice to have it as a toggle, so you don't have to assign a role to a remote user, just to do this...
Mock-up:
image
There is also already a property in the user, for this:
image

Copy Link (origin)

Summary

I would like there to be a "Copy Link (Origin)" button, something like FireFish has, in the ellipse menu under a post. not nessisarily behind the extra menu because it's buggy
image

Make profile content background transparent

Summary

Make the background of the content in profiles semi-transparent so profile backgrounds are more visible.

Inspired by Firefish's profile background transparency.

Screenshot_2023-10-08-14-10-02-544_com android chrome

Bonus fearures

  • Make background transparency optional with a toggle in edit profile
  • Make the above toggle federate with other sharkey instances / other instances that want to support the feaure.

bug: Changing emoji name to an existing one causes an internal error

๐Ÿ’ก Summary

changing an emoji's name to an already taken name causes an internal server error

๐Ÿฅฐ Expected Behavior

when the situation occurs it should give a useful error
having a dialog that shows both versions would be amazing

๐Ÿคฌ Actual Behavior

Endpoint: admin/emoji/update
Info: {"e":{"message":"name already exists","code":"Error","id":"4c38ea0f-8916-40e2-974e-17cd3e1f4971"}}
Date: 2023-09-26T16:13:14.516Z

๐Ÿ“ Steps to Reproduce

  1. have an emoji with an existing name
  2. change another emoji to the same name

๐Ÿ“Œ Environment

https://ambrosia.moe
running on commit 586ec6e

๐Ÿ’ป Frontend

  • Model and OS of the device(s):
    Arch Linux
  • Browser:
    Firefox 115.0.2 (64-bit) (Flatpak)
  • Server URL:
    ambrosia.moe

๐Ÿ›ฐ Backend (for server admin)

  • Installation Method or Hosting Service: systemd
  • Node: v19.90
  • PostgreSQL: docker i forgor how to check version
  • Redis: docker
  • OS and Architecture: Debian 11

"notes and replies" not showing replies as intended

Summary

I've confirmed this behaviour across two instances, transfem.social and ambrosia.moe, but the "notes and replies" tab doesn't seem to be showing replies, only posts, I don't think I was having this issue before so I'm not sure what changed

URLs containing apostrophes are not displayed correctly

๐Ÿ’ก Summary

If you post a URL containing an apostrophe, Sharkey interprets everything before the first apostrophe as the full URL, and everything after the apostrophe as not part of the URL. This leads to a broken link.

๐Ÿฅฐ Expected Behavior

A URL I put in a post should show up as a hyperlink.

๐Ÿคฌ Actual Behavior

Only part of the URL is hyperlinked, making the link point to the wrong place.

๐Ÿ“ Steps to Reproduce

  1. Find a web page with a URL containing an apostrophe, such as https://pandorastale.miraheze.org/wiki/Pandora's_Tale_Wiki:Moving_to_a_Custom_Domain
  2. Copy and paste the URL from step (1) into a Sharkey post.

๐Ÿ“Œ Environment

Reproduced on :
estrogen.plus running Sharkey 2023.9.1.beta3
transfem.social running Sharkey 2023.9.1.beta3

๐Ÿ’ป Frontend

  • Model and OS of the device(s):
    Linux Mint 21.2 Cinnamon desktop
  • Browser:
    Firefox 118.0.1 Flatpak
  • Server URL:
    estrogen.plus and
    transfem.social
  • Sharkey 2023.9.1.beta3

Edit Post

Required API/Backend Changes

  • Clone migration from Firefish
  • Create notes/edit api endpoint
  • Create Models and Entities for note edits

Required Frontend Changes

  • Show edit button and make MkPostForm.vue compatible with editing
  • Show an edit icon to indicate a post was edited

[Accessibility] Add tooltips

Summary

Tooltips allow users to understand what they're clicking on. This should be brought to Sharkey, so that people know what they're doing before they do it.

Bring back refresh profile information

Summary

Bring back the functionality to manually update a remote user's profile.
There used to be a button in what used to be user information (now renamed to "Moderation"), for updating remote user information. It was very handy, and it was removed for some reason... Firefish still has it:
image

Could we bring that back?

Group reaction emojis by emoji hash

Summary

When reacting from different instances, custom emoji reactions that are the same have separate counts depending on which instance they were sent from.

image

Proposed implementation idea

It would be awesome to have these grouped by image hash. Also, when a custom emoji reaction from a remote instance that is also present on the local instance is clicked, nothing happens. I propose checking for the image hash on the local instance, and if one with the same hash is present, send that.

Edits do not properly federate

๐Ÿ’ก Summary

Edits SK->FF work perfectly fine, but it seems that most of the other instance types reject the edits.

Sharkey's editing system misses the mark a bit.
https://fedi.cpluspatch.com/notice/AaQrPdpsYoJnVNOaem - Sharkey to Akkoma โŒ
https://kitsunes.club/notes/9kfjfrdoxujlb38i - Sharkey to Firefish โœ”๏ธ
https://tech.lgbt/@[email protected]/111177732228061879 - Sharkey to Mastodon โŒ

Firefish's editing system seems to work perfectly fine.
https://fedi.cpluspatch.com/notice/AaQqpKPpHqyQqitV20 - Firefish to Akkoma โœ”๏ธ
https://kitsunes.gay/notes/9kfj7augrx - Firefish to SK โœ”๏ธ
https://tech.lgbt/@[email protected]/111177706403113308 - Firefish to Mastodon โœ”๏ธ

๐Ÿฅฐ Expected Behavior

Edits propogate to most/all instances.

๐Ÿคฌ Actual Behavior

Edits are discarded by most other software types.

๐Ÿ“ Steps to Reproduce

  1. Make a post
  2. Edit a post
  3. Veiw yruo msaterpeece on another instance

๐Ÿ“Œ Environment

๐Ÿ’ป Frontend

  • Model and OS of the device(s):
    Custom Built PC on Ubuntu.
  • Browser:
    Firefox 117.0.1 Snap
  • Server URL:
    Kitsunes.gay
  • Misskey:
    2023.9.1.beta3

๐Ÿ›ฐ Backend (for server admin)

  • Installation Method or Hosting Service: Docker Stack w/ Swarm
  • Misskey: 2023.9.1.beta3

non-nyaify cat mode

Summary

separate the option for cat ears and nyaified text (like firefish)

Force sensitivity

Summary

A toggle to force an entire instance to be hidden as sensitive would be appreciated.

feat: Silence User & Bots

Bots

  • - Hide Bots from trending as admin option
  • - Hide Bots in timeline as user option

Users

  • Instance based silencing

Page jumps to top when new posts are loaded in the profile page

๐Ÿ’ก Summary

When you scroll down to load more posts in someone's profile, the page seems to jump around a lot, and mainly goes back to the top of the page

๐Ÿฅฐ Expected Behavior

The page should not jump around

๐Ÿคฌ Actual Behavior

Screencast.from.2023-10-16.17-23-24.webm

๐Ÿ“Œ Environment

Any profile page, v.2023.10.1

๐Ÿ’ป Frontend

  • Model and OS of the device(s): Fedora 38 w/ Gnome
  • Browser: Firefox
  • Server URL: kitsunes.club
  • Misskey: 2023.10.1

feat: Keyboard support & proper labeling of things

Summary

Am not sure if this should count as a bug or feature, but having keyboard support, as well as properly labeling buttons for screen readers should be a needed thing.

I know one way most of the labeling was done in Firefish was setting the aria-label attribute in the script that adds the tooltips, so that should make that bit easier. Some cherry-picking could also probably be done for especially the form components i think? I hope I didn't make those commits too messy, I'll try to find them later
Edit: This should be the commit for the form inputs in Calckey: https://codeberg.org/firefish/firefish/commit/1cc7c3f8dd685cc0ec62d55b0bdaf32c0475735c (https://codeberg.org/firefish/firefish/pulls/10130/files)
I hope that not much has changed in misskey's input components ?

Buttons should also have an outline shown when they're focused

There's a bunch more stuff that would need to be done, but that's the most basic stuff to make it at least sort of usable. Am still learning this stuff also

bug: mobile UI can be scrolled sideways on a user's profile if the name is too long

๐Ÿ’ก Summary

In mobile UI, if a user's profile name is too long and overflows, it'll allow the view to scroll sideways

I guess you could truncate the display name or wrap it somehow to fix this

๐Ÿฅฐ Expected Behavior

the view shouldn't be able to scroll sideways

๐Ÿคฌ Actual Behavior

the view can be scrolled sideways a bit
as shown here
Screenshot_20231017-112900

๐Ÿ“ Steps to Reproduce

  1. open a user profile that has a long display name this one, for example
  2. scroll to the right

๐Ÿ“Œ Environment

๐Ÿ’ป Frontend

  • Model and OS of the device(s):
    Google Pixel 6; GrapheneOS
  • Browser:
    Firefox Mobile
  • Server URL:
    ambrosia.moe
  • Misskey:
    13.x.x

๐Ÿ›ฐ Backend (for server admin)

  • Installation Method or Hosting Service: baremetal/systemd
  • Sharkey: commit f71a675
  • Node: 19.9.0
  • PostgreSQL: unknown
  • Redis: unknown
  • OS and Architecture: Debian 11 x86-64

Icons do not work specifically on Firefox Nightly for Mobile

๐Ÿ’ก Summary

No icon is able to load.

๐Ÿฅฐ Expected Behavior

Screenshot_20230930_100822_Firefox

๐Ÿคฌ Actual Behavior

Screenshot_20230930_100829_Firefox Nightly

๐Ÿ“ Steps to Reproduce

  1. Use Firefox Nightly for Android.

๐Ÿ“Œ Environment

๐Ÿ’ป Frontend

  • Model and OS of the device(s):

Z Fold5.

  • Browser: Firefox Nightly 120.0a1
  • Server URL: anon
  • Misskey:
    2023.9.1.beta2

bug: Translating doesnt work on parent/child notes

๐Ÿ’ก Summary

Translate button doesn't work when using it on a note that isn't the primary note being viewed (parent/child post)
on the primary note it works fine

๐Ÿฅฐ Expected Behavior

translation should appear on the reply when pressing the translate button

๐Ÿคฌ Actual Behavior

input is eaten and translation doesnt appear. no error message is produced
i couldn't find any error logs either

๐Ÿ“ Steps to Reproduce

  1. open a post with a reply in another language, this one for example
  2. open the menu on the reply and press translate
  3. the translation does not appear

๐Ÿ“Œ Environment

๐Ÿ’ป Frontend

  • Model and OS of the device(s):
    Arch Linux
  • Browser:
    Firefox 115.0.2 (flatpak)
  • Server URL:
    ambrosia.moe
  • Misskey:
    13.x.x

๐Ÿ›ฐ Backend (for server admin)

  • Installation Method or Hosting Service: baremetal
  • Sharkey: commit f71a675
  • Node: v19.9.0
  • PostgreSQL: unknown
  • Redis: unknown
  • OS and Architecture: debian 11

Improve size of CW

Summary

The show CW button is too small, especially on mobile devices. A bigger button would be better for users, and possibly more accessible for those who require bigger buttons.

feat: Notify when a re-noted note is edited

Summary

  1. Notify a user when a note they re-noted was edited.
  2. When editing a note, send the "update" activity also to all instances that re-noted it.

Longer version

Scenario:

It would be very useful if @[email protected] got notified of the edit, because the new contents may not be something they want to have re-noted

(I think Sharkey doesn't do this currently, feel free to just close this issue otherwise!)

I understand that, in general, the originating instance (one.example.com in the scenario) may not send the edit/update to all instances that have re-noted the original note; it would be nice if Sharkey did, though: we already track all re-notes, so we know who to send the edit/update to.

feat: add the proper chat feature

Summary

Sharkey doesn't have the proper DM chat system that prior versions of Misskey and also forks like Firefish happened to have, since it seems like the newest version of Misskey that Sharkey is based on removed that. I hope that if it's possible to do so that if it can be reimplemented back here. I'm just not a fan of the Mastodon-style DMs.

MFM Cheatsheet on all Make a post screens

Summary

Having an MFM cheatsheet for users is something that has been requested, as there's no proper way to see MFM except for looking through the cheatsheet made on another instance currently (that I'm aware of.)

This button should be intergrated into the post itself for easy reference.

bug: follow requests not approved on mobile

๐Ÿ’ก Summary

In the notifications tab on the mobile client the buttons of a follow request is of no use, they will neither approve nor reject the follow request.

๐Ÿฅฐ Expected Behavior

Follow requests should be approved or denied.

๐Ÿคฌ Actual Behavior

Nothing happens. The request stays as is.

๐Ÿ“ Steps to Reproduce

  1. (After receiving a follow request) open notifications tab in mobile web client
  2. Approve or deny the follow request
  3. Observe

๐Ÿ“Œ Environment

๐Ÿ’ป Frontend

  • Model and OS of the device(s): Xiaomi Redmi Note 9 (M2003J15SC), MIUI 13 with no modifications, Android 12
  • Browser: Firefox for Android 118.1.1 (Build #2015977611)
  • Server URL: https://transfem.social
  • Misskey: Sharkey 2023.9.1.beta4

Mastodon API

Required backend

  • Add megalodon to backend
  • Create mastodon api endpoints

Autopopulate user settings on Migrated user Setup

Summary

If an instance migrates to Sharkey, the users should be able to hit the floor running.

If there have not been changes since moving, the setup prompt should be automatically skipped.

Specifically for ff->sk migrations, it may be better to customize the setup prompt to show people the new features they have access to, instead of requiring account setup.

Currently, the setup menu requires the user to reinitialize if they don't skip, which may make them lose important settings, like "followers require approval", which has happened to one of my users already.

Fix click to open post related issues

Click to open tends to cause a lot of issues like opening up a post when showing a CW note, causing the router to freak out and etc these should all be fixed relatively quickly.

Video of router glitching out:

Peek.2023-10-11.21-07.mp4

bug: Sending messages doesn't show in the detailed view unless you refresh or change the page.

๐Ÿ’ก Summary

Timeline conversations don't refresh while sending or receiving new messages

๐Ÿฅฐ Expected Behavior

They should refresh when you send a new message or receive a new message from someone else during a conversation.

๐Ÿคฌ Actual Behavior

Instead only the notification bar seems to update while the timeline doens't update unless you change to a different page or refresh.

๐Ÿ“ Steps to Reproduce

  1. Try to send a message to someone
  2. Alternatively, wait for them to send a message
  3. The bug should come in effect

๐Ÿ“Œ Environment

Sharkey 2023.9.0-beta.10

๐Ÿ’ป Frontend

  • Model and OS of the device(s):
    Dual Boot System, currently running Windows 10 Pro 22H2
  • Browser:
    Firefox 177.0.1 (64-bit)
  • Server URL:
    ambrosia.moe
  • Sharkey:
    2023.9.0-beta.10

Switch to accessible font

Summary

The current font, while fun and intriguing, has the international users unable to use their own glyphs. The font should be changed to be more accessible and international.

Add buttons to all posts

Summary

all posts should be easily repliable, with a quick way to add a reaction, or send a post to the bottom of the thread.

Mark the presence of a poll when showing a non-detailed note

When showing a note up-thread, that has an image or video, the little "โ–ถ๏ธ(1 files(s))" is shown:
image

When the note has a poll, nothing is shown:
image
(and yes, that note has a poll:
image
)

It would be helpful to have something like "โ–ถ๏ธ(poll)" that can be expanded to show the poll

bug: Security Fixes: Admin Secrets

๐Ÿ’ก Summary

Currently Secrets such as S3 and Email Passwords are hidden behind a password field that can just be changed to type text this is not Unique to Sharkey as this is possible to do on Misskey and FireFish but this should be fixed as its dumb, and in my opinion a big flaw in securing secrets further more the Misskey Moderation Tab seems to leak all Secrets aswell when updating a Server, User, Role or other action, begging the question if Server Moderators can view secrets that they are not supposed to see and that are only intended for Admins

๐Ÿฅฐ Expected Behavior

Secrets in password fields should be properly hidden and not be able to exposed by changing the field to text
Secrets should not be exposed in the mod logs as this has security risks, also Moderators shouldn't have access to these secrets

๐Ÿคฌ Actual Behavior

Secrets in password fields can be exposed by changing the type to text with html edit (inspect)
Mod Log exposes secrets on some actions this might be visible to all Moderators not just Admins

๐Ÿ“ Steps to Reproduce

  1. Open Admin Control Panel with Secrets (SMTP for example)
  2. Open Inspector(ctrl + shift + i)
  3. Edit Password field to text

๐Ÿ“Œ Environment

๐Ÿ’ป Frontend

  • Model and OS of the device(s): Any
  • Browser: Any (with inspect)
  • Server URL: Any
  • Sharkey: Any
  • Other Environments that could be affected by this and should be informed: firefish, misskey and iceshrimp

Custom font on the administrator frontend

Summary

Just as I said on discord yesterday evening, I had the idea of being able to add custom font files directly in the admin interface, just like the custom icons and so on in the branding menu.

Ideally ttf, woff and woff2.

When hovering over a user's avatar, popup window should indicate if the user has follow-requests on

Summary

This is a request to port a feature from Firefish.

What I Want

Currently, if you view the profile of another user, and following that user requires their approval, a small lock icon is displayed next to their username.

On the other hand, if you are viewing a thread, and you hover your mouse over a user's avatar, the summarized version of their profile does not display this lock icon. As far as I can tell, it gives no indication as to whether the user in question requires followers to be manually approved.

I believe this interface should be changed so that the pop-up shows some indication that the user approves follow requests.

Why this feature would be useful

You can follow a user (or submit a follow-request) directly from the pop-up window without needing to load their full profile. But if a user requires follow-requests, then it's probably a better idea to go to their full profile and read their pinned posts before sending a request. I think it would be helpful to know right away which users are open to quick follows.
My particular use case is that when I read threads, I tend to want to quickly follow every user who makes a reply I like, as long as they are open to new followers. I really like the pop-up profiles on Sharkey because it makes doing this much faster: when I used Mastodon, I had to load every user's profile in a new tab to check if I already followed them and to start following them if I didn't.
If I try to follow a user who approves followers, then I don't find out until after I have sent the follow request and see an hour-glass symbol. That leaves me with two options:
1)Stop reading the thread, go to the user's profile, read carefully to make sure that I am the kind of person they are okay getting a follow-request from, and then (preferably) send them a DM saying why I am following. If I'm the kind of person they don't want to follow them for some reason, then I should revoke my follow request.
2)Immediately withdraw my follow-request and continue reading the thread. I'm not sure if sending a follow-request and immediately withdrawing it gives them a notification: if it does then I'd rather avoid this step.
This process would go much faster if I could see who locks their followers directly from the pop-up window.

ListenBrainz status not appearing

๐Ÿ’ก Summary

ListenBrainz status not appearing when scrobbling to listenbrainz

๐Ÿฅฐ Expected Behavior

Music status should appear on profile

๐Ÿคฌ Actual Behavior

Music status does not appear

this is the full console output when viewing my profile (i dont think its related but i thought i should include it anyway)

Misskey v2023.9.1.beta2 [app-52ebf1f4.js:35:34055](https://ambrosia.moe/vite/app-52ebf1f4.js)
Autoplay is only allowed when approved by the user, the site is activated by the user, or media is muted. [app-52ebf1f4.js:15:16788](https://ambrosia.moe/vite/app-52ebf1f4.js)
Uncaught (in promise) DOMException: The play method is not allowed by the user agent or the platform in the current context, possibly because the user denied permission. 2

my profile:
https://ambrosia.moe/@moshibar
my listenbrainz user:
moshibar

๐Ÿ“ Steps to Reproduce

  1. add musicbrainz username to profile
  2. played music, scrobbling to listenbrainz
  3. Status not appearing on profile

๐Ÿ“Œ Environment

ambrosia.moe
commit aac4c8b

๐Ÿ’ป Frontend

  • Model and OS of the device(s):
    Arch Linux (also tested on Android)
  • Browser:
    Firefox 118 (Flatpak)
    also tested on Vivaldi 6.1.3035.111
  • Server URL:
    ambrosia.moe
  • Misskey:
    v2023.9.1.beta2

๐Ÿ›ฐ Backend (for server admin)

  • Installation Method or Hosting Service: systemd
  • Misskey: v2023.9.1.beta2
  • Sharkey: commit aac4c8b
  • Node: v19.9.0
  • PostgreSQL: unsure, docker version
  • Redis: unsure, docker version
  • OS and Architecture: Debian 11

bug: Reports are not emailed

๐Ÿ’ก Summary

It appears that when I have changed my email. I have lost the ability to receive emails about reports that were made on or against the server.

๐Ÿฅฐ Expected Behavior

When a report is created, Sharkey will send an email to the administrators, regardless if it's been changed or not.

๐Ÿคฌ Actual Behavior

Nothing.

๐Ÿ“ Steps to Reproduce

  1. Change your email
  2. Make a report.

๐Ÿ›ฐ Backend (for server admin)

  • Installation Method or Hosting Service: Docker-Compose
  • Misskey: 2023.10.1
  • Node: Unknown.
  • PostgreSQL: postgresql:15
  • Redis: redis:latest

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.